Re: [xwiki-devs] [xwiki-notifications] r31048 - platform/web/trunk/standard/src/main/webapp/templates
Hi Alex, All commits that fix something or make some changes (except refactoring, ie same behavior, just internal way the code is written) must reference a jira issue. If this problem was caused by some changes in the trunk that wasn't released yet, you should use the same jira issue. If it's a fix over some previously released version then it needs a new jira issue. The idea is that a user who looks at the release notes must be able to see what was modified vs the version he has. Thanks -Vincent On Sep 11, 2010, at 7:15 PM, abusenius (SVN) wrote:
Author: abusenius Date: 2010-09-11 19:15:10 +0200 (Sat, 11 Sep 2010) New Revision: 31048
Modified: platform/web/trunk/standard/src/main/webapp/templates/editobject.vm Log: [misc] Fixed broken URL
Modified: platform/web/trunk/standard/src/main/webapp/templates/editobject.vm =================================================================== --- platform/web/trunk/standard/src/main/webapp/templates/editobject.vm 2010-09-11 02:32:40 UTC (rev 31047) +++ platform/web/trunk/standard/src/main/webapp/templates/editobject.vm 2010-09-11 17:15:10 UTC (rev 31048) @@ -16,7 +16,7 @@ #macro(displayObject $obj $class $props $firstfield) <div id="xobject_${escapetool.xml($class.name)}_${obj.number}" class="xobject"> <div id="xobject_${escapetool.xml($class.name)}_${obj.number}_title" class="xobject-title"><h3>#cleanClassname(${class.name}) ${obj.number}: $!{escapetool.xml($doc.display($firstfield, $obj))} - <a href="$doc.getURL('objectremove', "classname=${escapetool.url($class.name)}&classid=${obj.number}&xredirect=${doc.getURL('edit', 'editor=object')}")" class="xobject-action delete" title="$msg.get('core.editors.object.removeObject.tooltip')">$msg.get('core.editors.object.removeObject')</a> + <a href="$doc.getURL('objectremove', "classname=${escapetool.url($class.name)}&classid=${obj.number}&xredirect=${escapetool.url($doc.getURL('edit', 'editor=object'))}")" class="xobject-action delete" title="$msg.get('core.editors.object.removeObject.tooltip')">$msg.get('core.editors.object.removeObject')</a> #if(!$hasCustomObject) <a href="$doc.getURL("edit", "editor=object&classname=${escapetool.url($class.name)}&object=${obj.number}")" class="xobject-action edit" title="$msg.get('core.editors.object.editSingleObject.tooltip')">$msg.get('core.editors.object.editSingleObject')</a> #end </h3></div> <div id="xobject_${escapetool.xml($class.name)}_${obj.number}_content" class="xobject-content"><div>
Right, forgot about this, sorry. This would have been XWIKI-5242 (once again). Alex On 09/13/2010 09:00 AM, Vincent Massol wrote:
Hi Alex,
All commits that fix something or make some changes (except refactoring, ie same behavior, just internal way the code is written) must reference a jira issue.
If this problem was caused by some changes in the trunk that wasn't released yet, you should use the same jira issue. If it's a fix over some previously released version then it needs a new jira issue. The idea is that a user who looks at the release notes must be able to see what was modified vs the version he has.
Thanks -Vincent
On Sep 11, 2010, at 7:15 PM, abusenius (SVN) wrote:
Author: abusenius Date: 2010-09-11 19:15:10 +0200 (Sat, 11 Sep 2010) New Revision: 31048
Modified: platform/web/trunk/standard/src/main/webapp/templates/editobject.vm Log: [misc] Fixed broken URL
Modified: platform/web/trunk/standard/src/main/webapp/templates/editobject.vm =================================================================== --- platform/web/trunk/standard/src/main/webapp/templates/editobject.vm 2010-09-11 02:32:40 UTC (rev 31047) +++ platform/web/trunk/standard/src/main/webapp/templates/editobject.vm 2010-09-11 17:15:10 UTC (rev 31048) @@ -16,7 +16,7 @@ #macro(displayObject $obj $class $props $firstfield) <div id="xobject_${escapetool.xml($class.name)}_${obj.number}" class="xobject"> <div id="xobject_${escapetool.xml($class.name)}_${obj.number}_title" class="xobject-title"><h3>#cleanClassname(${class.name}) ${obj.number}: $!{escapetool.xml($doc.display($firstfield, $obj))} - <a href="$doc.getURL('objectremove', "classname=${escapetool.url($class.name)}&classid=${obj.number}&xredirect=${doc.getURL('edit', 'editor=object')}")" class="xobject-action delete" title="$msg.get('core.editors.object.removeObject.tooltip')">$msg.get('core.editors.object.removeObject')</a> + <a href="$doc.getURL('objectremove', "classname=${escapetool.url($class.name)}&classid=${obj.number}&xredirect=${escapetool.url($doc.getURL('edit', 'editor=object'))}")" class="xobject-action delete" title="$msg.get('core.editors.object.removeObject.tooltip')">$msg.get('core.editors.object.removeObject')</a> #if(!$hasCustomObject) <a href="$doc.getURL("edit", "editor=object&classname=${escapetool.url($class.name)}&object=${obj.number}")" class="xobject-action edit" title="$msg.get('core.editors.object.editSingleObject.tooltip')">$msg.get('core.editors.object.editSingleObject')</a> #end </h3></div> <div id="xobject_${escapetool.xml($class.name)}_${obj.number}_content" class="xobject-content"><div>
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Alex Busenius -
Vincent Massol