Re: XWiki 1.0 Beta 3 issue with rev 1946
On Jan 23, 2007, at 4:53 PM, Sergiu Dumitriu wrote:
I think we should revert this in the B3 branch, since it is experimental code. For the trunk, it's your call. I'll fix it as soon as I can.
ok. I think we should revert it both for the trunk and for the B3 branch. The reason is that some people are using the trunk (like curriki for example) and this is breaking them. Sergiu, could you please revert this change on both the trunk and the B3 branch (and update the jira issue accordingly)? Thanks -Vincent
On 1/23/07, Vincent Massol <[email protected]> wrote: Hi Sergiu,
Ludovic has noticed several important issues with beta 3. Apparently this is cause by a modification you made, see http:// svn.forge.objectweb.org/cgi-bin/viewcvs.cgi/xwiki/xwiki/trunk/core/ src/main/java/com/xpn/xwiki/XWiki.java?r2=1946&r1=1944&rev=1946
Apparently there are some data loss happening, some strange stuff with history, some panels do not work anymore (the Add Object panel doesn't work for example).
Ludovic is suggesting we rollback this change.
WDYT?
Thanks -Vincent
PS: I'm holding of the release till this is resolved.
______________________________________________________________________ _____ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com
Hi Sergiu, On Jan 23, 2007, at 5:00 PM, Vincent Massol wrote:
On Jan 23, 2007, at 4:53 PM, Sergiu Dumitriu wrote:
I think we should revert this in the B3 branch, since it is experimental code. For the trunk, it's your call. I'll fix it as soon as I can.
ok. I think we should revert it both for the trunk and for the B3 branch. The reason is that some people are using the trunk (like curriki for example) and this is breaking them.
Sergiu, could you please revert this change on both the trunk and the B3 branch (and update the jira issue accordingly)?
Sergiu I didn't hear from you about this. I see Ludovic has reverted XWIKI-744 in both trunk and b3 branch. However this issue was linked to 2 other issues: XWIKI-613 and XWIKI-780. I've now reopened these issues too. However I don't know if code also needs to be reverted for XWIKI-613 and XWII-780 now that XWIKI-744 was reverted. Please let us know quickly as we really need to release b3 today. Thanks -Vincent
On 1/23/07, Vincent Massol <[email protected]> wrote: Hi Sergiu,
Ludovic has noticed several important issues with beta 3. Apparently this is cause by a modification you made, see http:// svn.forge.objectweb.org/cgi-bin/viewcvs.cgi/xwiki/xwiki/trunk/core/ src/main/java/com/xpn/xwiki/XWiki.java?r2=1946&r1=1944&rev=1946
Apparently there are some data loss happening, some strange stuff with history, some panels do not work anymore (the Add Object panel doesn't work for example).
Ludovic is suggesting we rollback this change.
WDYT?
Thanks -Vincent
PS: I'm holding of the release till this is resolved.
_____________________________________________________________________ ______ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com
I'm still having problems with the edit panels (Add object, Add property) having lost their context although I reverted XWIKI-744. I'm now wondering if the panel problem is related to the XWIKI-744 commit or to more code. Sergiu can you help ? Ludovic Vincent Massol a écrit :
Hi Sergiu,
On Jan 23, 2007, at 5:00 PM, Vincent Massol wrote:
On Jan 23, 2007, at 4:53 PM, Sergiu Dumitriu wrote:
I think we should revert this in the B3 branch, since it is experimental code. For the trunk, it's your call. I'll fix it as soon as I can.
ok. I think we should revert it both for the trunk and for the B3 branch. The reason is that some people are using the trunk (like curriki for example) and this is breaking them.
Sergiu, could you please revert this change on both the trunk and the B3 branch (and update the jira issue accordingly)?
Sergiu I didn't hear from you about this. I see Ludovic has reverted XWIKI-744 in both trunk and b3 branch. However this issue was linked to 2 other issues: XWIKI-613 and XWIKI-780. I've now reopened these issues too.
However I don't know if code also needs to be reverted for XWIKI-613 and XWII-780 now that XWIKI-744 was reverted.
Please let us know quickly as we really need to release b3 today.
Thanks -Vincent
On 1/23/07, * Vincent Massol* <[email protected] <mailto:[email protected]>> wrote:
Hi Sergiu,
Ludovic has noticed several important issues with beta 3. Apparently this is cause by a modification you made, see http:// svn.forge.objectweb.org/cgi-bin/viewcvs.cgi/xwiki/xwiki/trunk/core/ <http://svn.forge.objectweb.org/cgi-bin/viewcvs.cgi/xwiki/xwiki/trunk/core/> src/main/java/com/xpn/xwiki/XWiki.java?r2=1946&r1=1944&rev=1946
Apparently there are some data loss happening, some strange stuff with history, some panels do not work anymore (the Add Object panel doesn't work for example).
Ludovic is suggesting we rollback this change.
WDYT?
Thanks -Vincent
PS: I'm holding of the release till this is resolved.
___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com
------------------------------------------------------------------------
-- You receive this message as a subscriber of the [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
-- Ludovic Dubost Blog: http://www.ludovic.org/blog/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost AIM: nvludo Yahoo: ludovic
participants (2)
-
Ludovic Dubost -
Vincent Massol