Re: [xwiki-devs] [xwiki-notifications] r27643 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web
On Mar 16, 2010, at 10:14 AM, Caleb James DeLisle wrote:
Actually I was trying to be hip and use gedit to write the log so I could use multiple lines. Maybe I'll set a newline variable in my .bashrc so I can keep on using the command line...
FWIW I use vi and it works well. I just type "svn commit", then vi opens, I enter my comment and save it and it just works for me. -Vincent
Marius Dumitru Florea wrote:
cjdelisle (SVN) wrote:
Author: cjdelisle Date: 2010-03-16 09:50:34 +0100 (Tue, 16 Mar 2010) New Revision: 27643
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java
Log:
You forgot the log :)
Thanks, Marius
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java =================================================================== --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java 2010-03-16 08:34:35 UTC (rev 27642) +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java 2010-03-16 08:50:34 UTC (rev 27643) @@ -40,6 +40,10 @@ * @see XWikiAction#render(com.xpn.xwiki.XWikiContext) */ public String render(XWikiContext context) throws XWikiException { - return context.getWiki().Param("xwiki.unknownActionResponse", "exception"); + String defaultAction = context.getWiki().Param("xwiki.unknownActionResponse", "exception"); + // Set the action in the context because code which uses $xcontext.getAction() + // should get the desired action instead of "unknown" + context.setAction(defaultAction); + return defaultAction; } }
_______________________________________________ notifications mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/notifications
_______________________________________________ notifications mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/notifications
_______________________________________________ notifications mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/notifications
On 03/16/2010 10:25 AM, Vincent Massol wrote:
On Mar 16, 2010, at 10:14 AM, Caleb James DeLisle wrote:
Actually I was trying to be hip and use gedit to write the log so I could use multiple lines. Maybe I'll set a newline variable in my .bashrc so I can keep on using the command line...
FWIW I use vi and it works well. I just type "svn commit", then vi opens, I enter my comment and save it and it just works for me.
You must make sure that $EDITOR is defined. I use mcedit.
-Vincent
Marius Dumitru Florea wrote:
cjdelisle (SVN) wrote:
Author: cjdelisle Date: 2010-03-16 09:50:34 +0100 (Tue, 16 Mar 2010) New Revision: 27643
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java
Log:
You forgot the log :)
Thanks, Marius
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java =================================================================== --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java 2010-03-16 08:34:35 UTC (rev 27642) +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/web/UnknownAction.java 2010-03-16 08:50:34 UTC (rev 27643) @@ -40,6 +40,10 @@ * @see XWikiAction#render(com.xpn.xwiki.XWikiContext) */ public String render(XWikiContext context) throws XWikiException { - return context.getWiki().Param("xwiki.unknownActionResponse", "exception"); + String defaultAction = context.getWiki().Param("xwiki.unknownActionResponse", "exception"); + // Set the action in the context because code which uses $xcontext.getAction() + // should get the desired action instead of "unknown" + context.setAction(defaultAction); + return defaultAction; } }
-- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Sergiu Dumitriu -
Vincent Massol