+1 Jean-Vincent Drean wrote:

Since attachments modifications create document versions is sounds logical. +1,

JV.

On Fri, Dec 4, 2009 at 2:27 PM, Thomas Mortagne <[email protected]> wrote:

...

Hi devs,

Currently when you attach or delete a new file on a document it does not produce any document related event. Thing is it does modify the document but since it bypass XWiki#saveDocument it does not produce any event.Whic mean currently to know that an attachment as been added you can only listen to upload action event (and it works only if it has been done with the UI).

I propose to make attachment modification also produce document modification events.

WDYT ?

Here is my +1

-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

On Fri, Dec 4, 2009 at 15:33, Vincent Massol <[email protected]> wrote:

On Dec 4, 2009, at 2:27 PM, Thomas Mortagne wrote:

...

Hi devs,

Currently when you attach or delete a new file on a document it does not produce any document related event. Thing is it does modify the document but since it bypass XWiki#saveDocument it does not produce any event.Whic mean currently to know that an attachment as been added you can only listen to upload action event (and it works only if it has been done with the UI).

I propose to make attachment modification also produce document modification events.

WDYT ?

Here is my +1

+1

I think that right now we consider the Document as: content + objects + class + attachments Maybe we should have both Document events but also content events + object events + class events + attachment events. We can do that later. The reason would be for listeners who want more specific events since otherwise it's hard to know what's changed if you only receive a Doc event.

Sure we need theses but it's more work.

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

-- Thomas Mortagne

On 12/4/09 3:33 PM, Vincent Massol wrote:

On Dec 4, 2009, at 2:27 PM, Thomas Mortagne wrote:

...

Hi devs,

Currently when you attach or delete a new file on a document it does not produce any document related event. Thing is it does modify the document but since it bypass XWiki#saveDocument it does not produce any event.Whic mean currently to know that an attachment as been added you can only listen to upload action event (and it works only if it has been done with the UI).

I propose to make attachment modification also produce document modification events.

WDYT ?

Here is my +1

+1

+1

I think that right now we consider the Document as: content + objects + class + attachments

+ metadata ?

Maybe we should have both Document events but also content events + object events + class events + attachment events. We can do that later. The reason would be for listeners who want more specific events since otherwise it's hard to know what's changed if you only receive a Doc event.

+1 for the future Jerome.

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs

+1 I agree on what Thomas Mortagne said on bypass and on Attachment events log (upload/delete/edit). Regards, Flavius On Fri, Dec 4, 2009 at 5:29 PM, Thomas Mortagne <[email protected]>wrote:

On Fri, Dec 4, 2009 at 14:27, Thomas Mortagne <[email protected]> wrote:

...

Hi devs,

Currently when you attach or delete a new file on a document it does not produce any document related event. Thing is it does modify the document but since it bypass XWiki#saveDocument it does not produce any event.Whic mean currently to know that an attachment as been added you can only listen to upload action event (and it works only if it has been done with the UI).

I propose to make attachment modification also produce document modification events.

WDYT ?

Here is my +1

-- Thomas Mortagne

For the details i propose to make UploadAction call

context.getWiki().saveDocument instead of context.getWiki().getStore().saveXWikiDoc (which make document save bypass even generation)

(same for DeleteAttachmentAction)

say if you think it could be an issue.

-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs