XECLIPSE.R.1.0.M1
Hi all, This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin). We have completed following tasks in this release, 1. Cleaned up source code ( need to be confirmed by Vincent ) 2. Implemented adding/deleting pages. - Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki. 3. Implemented adding/deleting spaces. - Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki) As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap. We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :) Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences. Hope to hear from you very soon. Thanks a lot! - Tharindu & Asiri
Hi Tharindu, I have done a first pass on the code review and I have a few comments: 1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file: /** * This code was edited or generated using CloudGarden's Jigloo SWT/ Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */ We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code. Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think. 2) Thanks for your javadoc. It's nice and helps a lot. However it can be improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?". Also please see: http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotuse27public27ininterfaces http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotduplicatemethodcommentswithparameterscomments Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions. 3) Please add copyright to all classes and don't use the @author tag. Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits. The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above. Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-) Thanks again and keep up the good work! -Vincent On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
<xeclipse.r.1.0.m1.eclipse.project.zip> <xeclipse_1.0.0.jar>
-- You receive this message as a subscriber of the xwiki- [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws
On 7/16/07, Vincent Massol <[email protected]> wrote:
Hi Tharindu, I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
I was thinking whether it would be legal (and ethical) if we look at jigloo generated code and write our own code (without copy and paste...) ?. I really have this doubt over all open source software, what if some commercial vendor looks at XWiki code, rewrite the code, do some feature additions, remove all the licensing info and claim that it's a new product (which they own) ? Thanks. - Asiri 2) Thanks for your javadoc. It's nice and helps a lot. However it can be
improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?".
Also please see:
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotuse27public27i...
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotduplicatemetho...
Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions.
3) Please add copyright to all classes and don't use the @author tag.
Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits.
The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above.
Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-)
Thanks again and keep up the good work! -Vincent
On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
<xeclipse.r.1.0.m1.eclipse.project.zip> <xeclipse_1.0.0.jar>
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected]<[email protected]> For general help: mailto:[email protected]?subject=help<[email protected]?subject=help> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
On 7/16/07, Asiri Rathnayake <[email protected]> wrote:
On 7/16/07, Vincent Massol <[email protected]> wrote:
Hi Tharindu, I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
I was thinking whether it would be legal (and ethical) if we look at jigloo generated code and write our own code (without copy and paste...) ?. I really have this doubt over all open source software, what if some commercial vendor looks at XWiki code, rewrite the code, do some feature additions, remove all the licensing info and claim that it's a new product (which they own) ?
After writing this mail I had second thoughts whether this was a appropriate question to ask, kind of feeling guilty... In any case, please apologize me.... - Asiri Thanks.
- Asiri
2) Thanks for your javadoc. It's nice and helps a lot. However it can be
improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?".
Also please see:
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotuse27public27i...
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotduplicatemetho...
Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions.
3) Please add copyright to all classes and don't use the @author tag.
Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits.
The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above.
Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-)
Thanks again and keep up the good work! -Vincent
On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
<xeclipse.r.1.0.m1.eclipse.project.zip> <xeclipse_1.0.0.jar>
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected] <[email protected]> For general help: mailto:[email protected]?subject=help<[email protected]?subject=help> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected] For general help: mailto: [email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
On Jul 16, 2007, at 5:00 PM, Asiri Rathnayake wrote:
On 7/16/07, Asiri Rathnayake <[email protected]> wrote:
On 7/16/07, Vincent Massol < [email protected]> wrote: Hi Tharindu,
I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/ Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
I was thinking whether it would be legal (and ethical) if we look at jigloo generated code and write our own code (without copy and paste...) ?. I really have this doubt over all open source software, what if some commercial vendor looks at XWiki code, rewrite the code, do some feature additions, remove all the licensing info and claim that it's a new product (which they own) ?
After writing this mail I had second thoughts whether this was a appropriate question to ask, kind of feeling guilty...
In any case, please apologize me....
Don't feel bad, this is a very relevant and natural question :) You do have this right of course as there are only so many ways of implementing UI in Eclipse. However if your code has too many similarities with the code from igloo they'd have the right to sue you/us. I think the best is really not to look at that code and redo that part. Thanks -Vincent
2) Thanks for your javadoc. It's nice and helps a lot. However it can be improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?".
Also please see: http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotuse27public27ininterfaces http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotduplicatemethodcommentswithparameterscomments
Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions. 3) Please add copyright to all classes and don't use the @author tag. Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits.
The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above.
Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-)
Thanks again and keep up the good work! -Vincent
On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
<xeclipse.r.1.0.m1.eclipse.project.zip> <xeclipse_1.0.0.jar>
On 7/16/07, Vincent Massol <[email protected]> wrote:
On Jul 16, 2007, at 5:00 PM, Asiri Rathnayake wrote:
On 7/16/07, Asiri Rathnayake <[email protected]> wrote:
On 7/16/07, Vincent Massol < [email protected]> wrote:
Hi Tharindu, I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE.
*/
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
I was thinking whether it would be legal (and ethical) if we look at jigloo generated code and write our own code (without copy and paste...) ?. I really have this doubt over all open source software, what if some commercial vendor looks at XWiki code, rewrite the code, do some feature additions, remove all the licensing info and claim that it's a new product (which they own) ?
After writing this mail I had second thoughts whether this was a appropriate question to ask, kind of feeling guilty...
In any case, please apologize me....
Don't feel bad, this is a very relevant and natural question :)
You do have this right of course as there are only so many ways of implementing UI in Eclipse. However if your code has too many similarities with the code from igloo they'd have the right to sue you/us. I think the best is really not to look at that code and redo that part.
Thanks, that helped a lot. :) - Asiri Thanks
-Vincent
2) Thanks for your javadoc. It's nice and helps a lot. However it can be
improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?".
Also please see:
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotuse27public27i...
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotduplicatemetho...
Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions.
3) Please add copyright to all classes and don't use the @author tag.
Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits.
The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above.
Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-)
Thanks again and keep up the good work! -Vincent
On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
<xeclipse.r.1.0.m1.eclipse.project.zip> <xeclipse_1.0.0.jar>
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
On Jul 16, 2007, at 6:10 PM, Vincent Massol wrote:
On Jul 16, 2007, at 5:00 PM, Asiri Rathnayake wrote:
On 7/16/07, Asiri Rathnayake <[email protected]> wrote:
On 7/16/07, Vincent Massol < [email protected]> wrote: Hi Tharindu,
I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/ Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
I was thinking whether it would be legal (and ethical) if we look at jigloo generated code and write our own code (without copy and paste...) ?. I really have this doubt over all open source software, what if some commercial vendor looks at XWiki code, rewrite the code, do some feature additions, remove all the licensing info and claim that it's a new product (which they own) ?
After writing this mail I had second thoughts whether this was a appropriate question to ask, kind of feeling guilty...
In any case, please apologize me....
Don't feel bad, this is a very relevant and natural question :)
You do have this right of course as there are only so many ways of implementing UI in Eclipse. However if your code has too many similarities with the code from igloo they'd have the right to sue you/us. I think the best is really not to look at that code and redo that part.
I found this interesting related to somewhere similar: http://www.reactos.org/wiki/index.php/Audit [snip] -Vincent
On 7/18/07, Vincent Massol <[email protected]> wrote:
On Jul 16, 2007, at 6:10 PM, Vincent Massol wrote:
On Jul 16, 2007, at 5:00 PM, Asiri Rathnayake wrote:
On 7/16/07, Asiri Rathnayake <[email protected]> wrote:
On 7/16/07, Vincent Massol < [email protected]> wrote:
Hi Tharindu, I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE.
*/
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
I was thinking whether it would be legal (and ethical) if we look at jigloo generated code and write our own code (without copy and paste...) ?. I really have this doubt over all open source software, what if some commercial vendor looks at XWiki code, rewrite the code, do some feature additions, remove all the licensing info and claim that it's a new product (which they own) ?
After writing this mail I had second thoughts whether this was a appropriate question to ask, kind of feeling guilty...
In any case, please apologize me....
Don't feel bad, this is a very relevant and natural question :)
You do have this right of course as there are only so many ways of implementing UI in Eclipse. However if your code has too many similarities with the code from igloo they'd have the right to sue you/us. I think the best is really not to look at that code and redo that part.
I found this interesting related to somewhere similar: http://www.reactos.org/wiki/index.php/Audit
[snip]
Thanks. BTW, i'm having problems with xwiki-dev list(or so it seems). Was the dev-list quite for past couple of days ? or is it that we cannot send mails to it ? I'm confused. I sent a mail today morning but it looks like it still hasn't reached the list. let's hope this one reaches the destination. - Asiri -Vincent
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
The mailing has been down since the 16th and it just went up again. However only new emails are coming in. All emails sent in between have not been received yet. I have asked the ObjectWeb admin why this is so. Let's hope they haven't been lost because I also sent quite a few emails... Thanks -Vincent On Jul 18, 2007, at 8:37 PM, Asiri Rathnayake wrote:
On 7/18/07, Vincent Massol <[email protected]> wrote:
On Jul 16, 2007, at 6:10 PM, Vincent Massol wrote:
On Jul 16, 2007, at 5:00 PM, Asiri Rathnayake wrote:
On 7/16/07, Asiri Rathnayake <[email protected]> wrote:
On 7/16/07, Vincent Massol < [email protected]> wrote: Hi Tharindu,
I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
I was thinking whether it would be legal (and ethical) if we look at jigloo generated code and write our own code (without copy and paste...) ?. I really have this doubt over all open source software, what if some commercial vendor looks at XWiki code, rewrite the code, do some feature additions, remove all the licensing info and claim that it's a new product (which they own) ?
After writing this mail I had second thoughts whether this was a appropriate question to ask, kind of feeling guilty...
In any case, please apologize me....
Don't feel bad, this is a very relevant and natural question :)
You do have this right of course as there are only so many ways of implementing UI in Eclipse. However if your code has too many similarities with the code from igloo they'd have the right to sue you/us. I think the best is really not to look at that code and redo that part.
I found this interesting related to somewhere similar: http://www.reactos.org/wiki/index.php/Audit
[snip]
Thanks. BTW, i'm having problems with xwiki-dev list(or so it seems). Was the dev-list quite for past couple of days ? or is it that we cannot send mails to it ? I'm confused. I sent a mail today morning but it looks like it still hasn't reached the list. let's hope this one reaches the destination.
Hi All, Attached are the latest sources and binaries of XEclipse m1. Issues Fixed, 1. All Jigloo dependencies removed. 2. Code documentation improved according to instructions from Vincent. 3. Back-End XML RPC's patched to suite XEclipse (Asiri) http://jira.xwiki.org/jira/browse/XWIKI-1520 http://jira.xwiki.org/jira/browse/XWIKI-1521 http://jira.xwiki.org/jira/browse/XWIKI-1524 Let's hope this would finalize XEclipse m1 ... :) Hoping to hear from you soon... Thanks. - Tharindu & Asiri On 7/16/07, Vincent Massol <[email protected]> wrote:
Hi Tharindu, I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
2) Thanks for your javadoc. It's nice and helps a lot. However it can be improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?".
Also please see:
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotuse27public27i...
http://www.xwiki.org/xwiki/bin/view/Community/CodeStyle#HDonotduplicatemetho...
Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions.
3) Please add copyright to all classes and don't use the @author tag. Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits.
The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above.
Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-)
Thanks again and keep up the good work! -Vincent
On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
<xeclipse.r.1.0.m1.eclipse.project.zip> <xeclipse_1.0.0.jar>
-- You receive this message as a subscriber of the [email protected] list. To unsubscribe: mailto:[email protected]<[email protected]> For general help: mailto:[email protected]?subject=help<[email protected]?subject=help> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
Hi Tharindu, I'll review this latest patch later today or tomorrow. Thanks -Vincent On Jul 28, 2007, at 7:32 PM, tharindu jayasuriya wrote:
Hi All,
Attached are the latest sources and binaries of XEclipse m1.
Issues Fixed,
1. All Jigloo dependencies removed.
2. Code documentation improved according to instructions from Vincent.
3. Back-End XML RPC's patched to suite XEclipse (Asiri)
http://jira.xwiki.org/jira/browse/XWIKI-1520
http://jira.xwiki.org/jira/browse/XWIKI-1521
http://jira.xwiki.org/jira/browse/XWIKI-1524
Let's hope this would finalize XEclipse m1 ... :)
Hoping to hear from you soon...
Thanks.
- Tharindu & Asiri
On 7/16/07, Vincent Massol <[email protected] > wrote: Hi Tharindu,
I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/ Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
2) Thanks for your javadoc. It's nice and helps a lot. However it can be improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?".
Also please see: http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotuse27public27ininterfaces http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotduplicatemethodcommentswithparameterscomments
Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions.
3) Please add copyright to all classes and don't use the @author tag. Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits.
The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above.
Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-)
Thanks again and keep up the good work! -Vincent
On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
Hi Tharindu/Asiri, I have reviewed the patch and it looks good. Only potential issue is the package name you've used: org.xwiki.plugins. So far we've used com.xpn.xwiki.*. However you're correct that we want to move to org.xwiki. That said we need to decide if we want to do the move right now for the Eclipse extension. I think it's a good idea to do so and the strategy would be that any new extension/plugin or any component in the new architecture should be located in the org.xwiki package. What do others think? I'm going to commit it to xwiki-sandbox for now (till we have a maven2 build for it, then I'll move it to xwiki-extensions/eclipse) and we have already voted to give you access to it. I'll just need your ObjectWeb user id to give you write access. Thanks -Vincent On Jul 31, 2007, at 2:45 PM, Vincent Massol wrote:
Hi Tharindu,
I'll review this latest patch later today or tomorrow.
Thanks -Vincent
On Jul 28, 2007, at 7:32 PM, tharindu jayasuriya wrote:
Hi All,
Attached are the latest sources and binaries of XEclipse m1.
Issues Fixed,
1. All Jigloo dependencies removed.
2. Code documentation improved according to instructions from Vincent.
3. Back-End XML RPC's patched to suite XEclipse (Asiri)
http://jira.xwiki.org/jira/browse/XWIKI-1520
http://jira.xwiki.org/jira/browse/XWIKI-1521
http://jira.xwiki.org/jira/browse/XWIKI-1524
Let's hope this would finalize XEclipse m1 ... :)
Hoping to hear from you soon...
Thanks.
- Tharindu & Asiri
On 7/16/07, Vincent Massol <[email protected] > wrote: Hi Tharindu,
I have done a first pass on the code review and I have a few comments:
1) You seem to have use Cloudgarden's Jigloo and unfortunately the license isn't good enough for us so we cannot use it... Here's what it says in the generated file:
/** * This code was edited or generated using CloudGarden's Jigloo SWT/ Swing GUI Builder, which is free * for non-commercial use. If Jigloo is being used commercially (ie, by a corporation, company or * business for any purpose whatever) then you should purchase a license for each developer using * Jigloo. Please visit www.cloudgarden.com for details. Use of Jigloo implies acceptance of these * licensing terms. A COMMERCIAL LICENSE HAS NOT BEEN PURCHASED FOR THIS MACHINE, SO JIGLOO OR THIS * CODE CANNOT BE USED LEGALLY FOR ANY CORPORATE OR COMMERCIAL PURPOSE. */
We cannot use Jigloo because we want commercial companies using XWiki under the LGPL license. Thus we cannot commit this code.
Could you find some alternative? The UI doesn't seem too complex so I should be easy to do it by hand I think.
2) Thanks for your javadoc. It's nice and helps a lot. However it can be improved, especially for Classes. This is the most important Javadoc and should answer the question "what is the class for?".
Also please see: http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotuse27public27ininterfaces http://www.xwiki.org/xwiki/bin/view/Community/ CodeStyle#HDonotduplicatemethodcommentswithparameterscomments
Parameters and return value shouldn't start with "-" in javadoc. See the Sun's Javadoc coding conventions.
3) Please add copyright to all classes and don't use the @author tag. Instead we'll add Asiri and yourself to the Hall of Fame + in the SVN commits.
The rest sounds good. We need to add maven build of course. I'll start looking into that after we fix the points above.
Also, I haven't coded plugins in Eclipse for a very very long time so I have no idea if what you've done is the right way of doing it so I'll assume it is :-)
Thanks again and keep up the good work! -Vincent
On Jul 15, 2007, at 10:04 AM, tharindu jayasuriya wrote:
Hi all,
This is about r.1.0.m1 version of xeclipse (XWiki-Eclipse-Plugin).
We have completed following tasks in this release,
1. Cleaned up source code ( need to be confirmed by Vincent )
2. Implemented adding/deleting pages.
- Adding pages does not seem to work correctly due to some errors in XML-RPC implementation of XWiki, need to look into this. - Removing pages does not work at all because the corresponding XML-RPC is not implemented in XWiki.
3. Implemented adding/deleting spaces.
- Adding spaces work fine. - Deleting spaces does not work (RPC not implemented in XWiki)
As it's obvious by now, we need to peek into XWiki internals to get these issues fixed. But since we have a scheduled release today (and these issues showed up all of a sudden), we thought of finishing the work from the plugin's end and uploading the relevant work. Anyway, those issues need to be fixed asap.
We have tested the work on a stand alone (HSQLDB) Xwiki installation, it would be really nice if someone can test the plugin on a real server and confirm the results :)
Vincent, I couldn't find an appropriate place to upload the files in XWIKI JIRA, so i thought of attaching relevant files into this email. I'm really sorry for any inconveniences.
Hope to hear from you very soon.
Thanks a lot!
- Tharindu & Asiri
-- You receive this message as a subscriber of the xwiki- [email protected] mailing list. To unsubscribe: mailto:[email protected] For general help: mailto:[email protected]?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws
participants (3)
-
Asiri Rathnayake -
tharindu jayasuriya -
Vincent Massol