Le lun. 4 févr. 2019 à 14:35, Thomas Mortagne <[email protected]> a écrit :

On Mon, Feb 4, 2019 at 12:50 PM Guillaume Delhumeau <[email protected]> wrote:

...

Dear developers,

Now that we consider notifications as an achieved replacement for both Activity Stream and the Watchlist, I propose to stop maintaining them and to move them into the "attic" section.

You need to know that we had a dependency on the Activity Stream API, as the only implementation of the Event Stream, on which the Notifications

are

...

based. So to get rid of this dependency (the code is not using our component system and is not well tested), I have written a new implementation of the Event Stream that I have called "Event Stream Store". It's fully backward compatible with the old implementation, since it is using the same Database schema. In practice, I re-used some pieces of Activity Stream that I have modified to fit into components. For more information, see: https://jira.xwiki.org/browse/XWIKI-16052

So my proposal is this one: - use the new store in 11.1

...

- stop bundle Watchlist and AS in 11.1

Will 11.1 version be easily installable as extension (in case some old extension needs it for example) ?

AS needs a custom property in hibernate.cfg.xml plus a special config in xwiki.cfg (since it is a plugin), and the Watchlist needs AS to be installed. So, in short, not easy installable.

...

- move Watchlist and AS into "attic" in 11.2

Thanks you,

-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project

-- Thomas Mortagne

-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project

Le mar. 5 févr. 2019 à 11:33, Vincent Massol <[email protected]> a écrit :

Hi Guillaume,

...

On 4 Feb 2019, at 12:50, Guillaume Delhumeau < [email protected]> wrote:

Dear developers,

Now that we consider notifications as an achieved replacement for both Activity Stream and the Watchlist, I propose to stop maintaining them and to move them into the "attic" section.

+1

...

You need to know that we had a dependency on the Activity Stream API, as the only implementation of the Event Stream, on which the Notifications are based. So to get rid of this dependency (the code is not using our component system and is not well tested), I have written a new implementation of the Event Stream that I have called "Event Stream Store". It's fully backward compatible with the old implementation, since it is using the same Database schema. In practice, I re-used some pieces of Activity Stream that I have modified to fit into components. For more information, see: https://jira.xwiki.org/browse/XWIKI-16052

So my proposal is this one: - use the new store in 11.1

Already in action! +1

...

- stop bundle Watchlist and AS in 11.1

+1

...

- move Watchlist and AS into "attic" in 11.2

IMO this could be done in 11.1 too since if we stop bundling Watchlist/AS then we don’t need to keep the modules in platform.

I wanted to release a new "official" version of AS before moving it to attic, because I made a few changes on it (like moving some components that had nothing to do in AS).

Thanks -Vincent

...

Thanks you,

-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project

-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project

+1 in general, but please consider migration issues, specially calls to the {{activity/}} macro that will be still found in wiki pages that will stop working if the ActivityStream (which is a macro) is removed. Also, for anyone using or extending the ActivityStream plugin's API directly, their code will fail. I doubt there were many (if any) users of the relatively obscure EventStream API, so the effect of the backwards compatible "Event Stream Store" implementation will not compensate for much, IMO. What I am personally concerned about is that, ideally, the upgrade to the new XWiki version (which no longer bundles these modules) require as less (preferably none) manual operations as possible. Thanks, Eduard On Wed, Feb 6, 2019 at 5:10 PM Marius Dumitru Florea < [email protected]> wrote:

+1

Thanks, Marius

On Mon, Feb 4, 2019 at 1:50 PM Guillaume Delhumeau < [email protected]> wrote:

...

Dear developers,

Now that we consider notifications as an achieved replacement for both Activity Stream and the Watchlist, I propose to stop maintaining them and to move them into the "attic" section.

You need to know that we had a dependency on the Activity Stream API, as the only implementation of the Event Stream, on which the Notifications are based. So to get rid of this dependency (the code is not using our component system and is not well tested), I have written a new implementation of the Event Stream that I have called "Event Stream Store". It's fully backward compatible with the old implementation, since it is using the same Database schema. In practice, I re-used some pieces of Activity Stream that I have modified to fit into components. For more information, see: https://jira.xwiki.org/browse/XWIKI-16052

So my proposal is this one: - use the new store in 11.1 - stop bundle Watchlist and AS in 11.1 - move Watchlist and AS into "attic" in 11.2

Thanks you,

-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project