[xwiki-devs] [vote] Move the dependencies to macros from com.xpn.xwiki.platform:xwiki-core to com.xpn.xwiki.platform:xwiki-web-standard
Hi devs, currently the rendering macros are added to the build as runtime dependencies to the old core, which would pull them further in web-standard so that they are packed in the war. I propose to change this and add them as dependencies to the standard web war, just like the other core components that need to be packed in the platform by default (e.g. annotations), for the following reasons: * core does not depend on these macros, they're there only for packaging purposes. Semantically speaking this is a little odd since the "packaging" module is the war, not the core jar. * it would allow sinner macros take the wrong way and depend on xwiki-core (the old core), without creating circular dependencies. my +1 (I will do it as soon as I get 3 votes since I already added this circular dep in the build and I need to fix it). WDYT? Thanks, Anca
On Wed, Feb 9, 2011 at 12:30, Anca Luca <[email protected]> wrote:
Hi devs,
currently the rendering macros are added to the build as runtime dependencies to the old core, which would pull them further in web-standard so that they are packed in the war.
I propose to change this and add them as dependencies to the standard web war, just like the other core components that need to be packed in the platform by default (e.g. annotations), for the following reasons:
* core does not depend on these macros, they're there only for packaging purposes. Semantically speaking this is a little odd since the "packaging" module is the war, not the core jar. * it would allow sinner macros take the wrong way and depend on xwiki-core (the old core), without creating circular dependencies.
Make easier for macros to depends on the old core is not a good point for me since that's supposed to be avoided as much as possible...
my +1 (I will do it as soon as I get 3 votes since I already added this circular dep in the build and I need to fix it).
WDYT?
+0
Thanks, Anca _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Feb 9, 2011, at 12:30 PM, Anca Luca wrote:
Hi devs,
currently the rendering macros are added to the build as runtime dependencies to the old core, which would pull them further in web-standard so that they are packed in the war.
I propose to change this and add them as dependencies to the standard web war, just like the other core components that need to be packed in the platform by default (e.g. annotations), for the following reasons:
* core does not depend on these macros, they're there only for packaging purposes. Semantically speaking this is a little odd since the "packaging" module is the war, not the core jar. * it would allow sinner macros take the wrong way and depend on xwiki-core (the old core), without creating circular dependencies.
my +1 (I will do it as soon as I get 3 votes since I already added this circular dep in the build and I need to fix it).
+1 Thanks -Vincent
On 02/09/2011 12:30 PM, Anca Luca wrote:
Hi devs,
currently the rendering macros are added to the build as runtime dependencies to the old core, which would pull them further in web-standard so that they are packed in the war.
I propose to change this and add them as dependencies to the standard web war, just like the other core components that need to be packed in the platform by default (e.g. annotations), for the following reasons:
* core does not depend on these macros, they're there only for packaging purposes. Semantically speaking this is a little odd since the "packaging" module is the war, not the core jar.
+1.
* it would allow sinner macros take the wrong way and depend on xwiki-core (the old core), without creating circular dependencies.
Nice, "sinner macros".
my +1 (I will do it as soon as I get 3 votes since I already added this circular dep in the build and I need to fix it).
-- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (4)
-
Anca Luca -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol