Re: [xwiki-devs] [Proposal] Move xwiki-application-invitation to platform-applications and include in XEnterprise
Hi Caleb, Just a quick remark : The application creates a space "Invitation" for which the home page does not exists. This home page should probably be what currently is "Invitation.Invitation" (i.e. the user interface entry point). I'll test more and give more feedback. Jerome. ----- "Caleb James DeLisle" <[email protected]> wrote:
Hello all,
First my proposal: I propose we add the invitation application to platform/applications and give it a jira top level project name, I further propose we add a dependency to the Enterprise pom.xml and merge the UI tests which I have wrote into the Enterprise UI tests. I would rather not move the translation keys into the default document bundle until nearer release time because it would be nice to use the new internationalization module if possible and as development is still going fast, there will be changes to translations.
The state of the invitation application: All major refactoring is finished and I am now just squashing bugs and adding new features.
Lately I have been debugging using tests rather than manual debugging, So far I have 7 UI tests which with framework comprise 1207 lines in 8 files. Maintaining a fork of the UI tests is becoming burdensome and I think the invitation application is ready to be included.
Improvements since the version which is on the incubator: * Each message has a "history", a list of status changes, the user who made the change and a log (if any) which they left regarding the change. * An invitation sent to multiple addresses is handled as a group of invitations each of which may be accepted/declined individually, the sender or admin can view the group and see all of the messages in it as a table. * Users see an info macro at the bottom of the screen telling them how many pending invitations they have (if any). * Admins see a warning macro at the bottom of the page telling them how many message have been reported as spam (if any have). * Templates are translatable and (should be) compatible with more email clients.
Tasks still to be done include: * A means by which invitees can be allowed into a closed wiki. * Invitation of a mailing list. * Handling "join requests". * Use javascript to make it easier to use and implement livetable * Improve CSS.
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Jerome Velociter wrote:
Hi Caleb,
Just a quick remark :
The application creates a space "Invitation" for which the home page does not exists. This home page should probably be what currently is "Invitation.Invitation" (i.e. the user interface entry point).
Done r29341 Thanks for mentioning it.
I'll test more and give more feedback.
Great thanks. Caleb
Jerome.
----- "Caleb James DeLisle" <[email protected]> wrote:
Hello all,
First my proposal: I propose we add the invitation application to platform/applications and give it a jira top level project name, I further propose we add a dependency to the Enterprise pom.xml and merge the UI tests which I have wrote into the Enterprise UI tests. I would rather not move the translation keys into the default document bundle until nearer release time because it would be nice to use the new internationalization module if possible and as development is still going fast, there will be changes to translations.
The state of the invitation application: All major refactoring is finished and I am now just squashing bugs and adding new features.
Lately I have been debugging using tests rather than manual debugging, So far I have 7 UI tests which with framework comprise 1207 lines in 8 files. Maintaining a fork of the UI tests is becoming burdensome and I think the invitation application is ready to be included.
Improvements since the version which is on the incubator: * Each message has a "history", a list of status changes, the user who made the change and a log (if any) which they left regarding the change. * An invitation sent to multiple addresses is handled as a group of invitations each of which may be accepted/declined individually, the sender or admin can view the group and see all of the messages in it as a table. * Users see an info macro at the bottom of the screen telling them how many pending invitations they have (if any). * Admins see a warning macro at the bottom of the page telling them how many message have been reported as spam (if any have). * Templates are translatable and (should be) compatible with more email clients.
Tasks still to be done include: * A means by which invitees can be allowed into a closed wiki. * Invitation of a mailing list. * Handling "join requests". * Use javascript to make it easier to use and implement livetable * Improve CSS.
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Re testing: I added the UI tests to Enterprise tests, they are @Ignored so if you feel like running them Add this to enterprise/trunk/wiki/pom.xml <dependency> <groupId>org.xwiki.platform.applications</groupId> <artifactId>xwiki-application-invitation</artifactId> <version>1.0-SNAPSHOT</version> <type>xar</type> </dependency> Check out and build the invitation application then remove @Ignore from enterprise/trunk/distribution-test/ui-test/...../InvitationTest.java Caleb Caleb James DeLisle wrote:
Jerome Velociter wrote:
Hi Caleb,
Just a quick remark :
The application creates a space "Invitation" for which the home page does not exists. This home page should probably be what currently is "Invitation.Invitation" (i.e. the user interface entry point).
Done r29341 Thanks for mentioning it.
I'll test more and give more feedback.
Great thanks.
Caleb
Jerome.
----- "Caleb James DeLisle" <[email protected]> wrote:
Hello all,
First my proposal: I propose we add the invitation application to platform/applications and give it a jira top level project name, I further propose we add a dependency to the Enterprise pom.xml and merge the UI tests which I have wrote into the Enterprise UI tests. I would rather not move the translation keys into the default document bundle until nearer release time because it would be nice to use the new internationalization module if possible and as development is still going fast, there will be changes to translations.
The state of the invitation application: All major refactoring is finished and I am now just squashing bugs and adding new features.
Lately I have been debugging using tests rather than manual debugging, So far I have 7 UI tests which with framework comprise 1207 lines in 8 files. Maintaining a fork of the UI tests is becoming burdensome and I think the invitation application is ready to be included.
Improvements since the version which is on the incubator: * Each message has a "history", a list of status changes, the user who made the change and a log (if any) which they left regarding the change. * An invitation sent to multiple addresses is handled as a group of invitations each of which may be accepted/declined individually, the sender or admin can view the group and see all of the messages in it as a table. * Users see an info macro at the bottom of the screen telling them how many pending invitations they have (if any). * Admins see a warning macro at the bottom of the page telling them how many message have been reported as spam (if any have). * Templates are translatable and (should be) compatible with more email clients.
Tasks still to be done include: * A means by which invitees can be allowed into a closed wiki. * Invitation of a mailing list. * Handling "join requests". * Use javascript to make it easier to use and implement livetable * Improve CSS.
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
----- "Jerome Velociter" <[email protected]> wrote:
Hi Caleb,
Just a quick remark :
The application creates a space "Invitation" for which the home page does not exists. This home page should probably be what currently is "Invitation.Invitation" (i.e. the user interface entry point).
I'll test more and give more feedback.
The home page feels a bit "out of context" : http://img210.imageshack.us/img210/4299/invitationnoheader.png I think it lacks some introductory text that explains what's it's all about You might also want to add some margin below the preview and send mail button. Hope this helps, Jerome.
Jerome.
----- "Caleb James DeLisle" <[email protected]> wrote:
Hello all,
First my proposal: I propose we add the invitation application to platform/applications and give it a jira top level project name, I further propose we add a dependency to the Enterprise pom.xml and merge the UI tests which I have wrote into the Enterprise UI tests. I would rather not move the translation keys into the default document bundle until nearer release time because it would be nice to use the new internationalization module if possible and as development is still going fast, there will be changes to translations.
The state of the invitation application: All major refactoring is finished and I am now just squashing bugs and adding new features.
Lately I have been debugging using tests rather than manual debugging, So far I have 7 UI tests which with framework comprise 1207 lines in 8 files. Maintaining a fork of the UI tests is becoming burdensome and I think the invitation application is ready to be included.
Improvements since the version which is on the incubator: * Each message has a "history", a list of status changes, the user who made the change and a log (if any) which they left regarding the change. * An invitation sent to multiple addresses is handled as a group of invitations each of which may be accepted/declined individually, the sender or admin can view the group and see all of the messages in it as a table. * Users see an info macro at the bottom of the screen telling them how many pending invitations they have (if any). * Admins see a warning macro at the bottom of the page telling them how many message have been reported as spam (if any have). * Templates are translatable and (should be) compatible with more email clients.
Tasks still to be done include: * A means by which invitees can be allowed into a closed wiki. * Invitation of a mailing list. * Handling "join requests". * Use javascript to make it easier to use and implement livetable * Improve CSS.
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
Hi, On Wed, Jun 9, 2010 at 18:23, Jerome Velociter <[email protected]> wrote:
----- "Jerome Velociter" <[email protected]> wrote:
Hi Caleb,
Just a quick remark :
The application creates a space "Invitation" for which the home page does not exists. This home page should probably be what currently is "Invitation.Invitation" (i.e. the user interface entry point).
I'll test more and give more feedback.
The home page feels a bit "out of context" : http://img210.imageshack.us/img210/4299/invitationnoheader.png
WDYM "out of context"? Chromeless interfaces are the future, just ask the Windows Phone 7 guys ;-) Guillaume
I think it lacks some introductory text that explains what's it's all about
You might also want to add some margin below the preview and send mail button.
Hope this helps,
Jerome.
Jerome.
----- "Caleb James DeLisle" <[email protected]> wrote:
Hello all,
First my proposal: I propose we add the invitation application to platform/applications and give it a jira top level project name, I further propose we add a dependency to the Enterprise pom.xml and merge the UI tests which I have wrote into the Enterprise UI tests. I would rather not move the translation keys into the default document bundle until nearer release time because it would be nice to use the new internationalization module if possible and as development is still going fast, there will be changes to translations.
The state of the invitation application: All major refactoring is finished and I am now just squashing bugs and adding new features.
Lately I have been debugging using tests rather than manual debugging, So far I have 7 UI tests which with framework comprise 1207 lines in 8 files. Maintaining a fork of the UI tests is becoming burdensome and I think the invitation application is ready to be included.
Improvements since the version which is on the incubator: * Each message has a "history", a list of status changes, the user who made the change and a log (if any) which they left regarding the change. * An invitation sent to multiple addresses is handled as a group of invitations each of which may be accepted/declined individually, the sender or admin can view the group and see all of the messages in it as a table. * Users see an info macro at the bottom of the screen telling them how many pending invitations they have (if any). * Admins see a warning macro at the bottom of the page telling them how many message have been reported as spam (if any have). * Templates are translatable and (should be) compatible with more email clients.
Tasks still to be done include: * A means by which invitees can be allowed into a closed wiki. * Invitation of a mailing list. * Handling "join requests". * Use javascript to make it easier to use and implement livetable * Improve CSS.
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Lerouge Sales - XWiki SAS Skype: wikibc Twitter: glerouge http://guillaumelerouge.com/
Guillaume Lerouge wrote:
Hi,
On Wed, Jun 9, 2010 at 18:23, Jerome Velociter <[email protected]> wrote:
----- "Jerome Velociter" <[email protected]> wrote:
Hi Caleb,
Just a quick remark :
The application creates a space "Invitation" for which the home page does not exists. This home page should probably be what currently is "Invitation.Invitation" (i.e. the user interface entry point).
I'll test more and give more feedback. The home page feels a bit "out of context" : http://img210.imageshack.us/img210/4299/invitationnoheader.png
Hey if we're talking about little look and feel stuff like this then I think we're doing well ;) It's been near 3 days since the proposal, I have moved the tests into enterprise tests. If nobody has any complaints, I'd like to go ahead and move this in on Friday. Caleb
WDYM "out of context"? Chromeless interfaces are the future, just ask the Windows Phone 7 guys ;-)
Guillaume
I think it lacks some introductory text that explains what's it's all about
You might also want to add some margin below the preview and send mail button.
Hope this helps,
Jerome.
Jerome.
----- "Caleb James DeLisle" <[email protected]> wrote:
Hello all,
First my proposal: I propose we add the invitation application to platform/applications and give it a jira top level project name, I further propose we add a dependency to the Enterprise pom.xml and merge the UI tests which I have wrote into the Enterprise UI tests. I would rather not move the translation keys into the default document bundle until nearer release time because it would be nice to use the new internationalization module if possible and as development is still going fast, there will be changes to translations.
The state of the invitation application: All major refactoring is finished and I am now just squashing bugs and adding new features.
Lately I have been debugging using tests rather than manual debugging, So far I have 7 UI tests which with framework comprise 1207 lines in 8 files. Maintaining a fork of the UI tests is becoming burdensome and I think the invitation application is ready to be included.
Improvements since the version which is on the incubator: * Each message has a "history", a list of status changes, the user who made the change and a log (if any) which they left regarding the change. * An invitation sent to multiple addresses is handled as a group of invitations each of which may be accepted/declined individually, the sender or admin can view the group and see all of the messages in it as a table. * Users see an info macro at the bottom of the screen telling them how many pending invitations they have (if any). * Admins see a warning macro at the bottom of the page telling them how many message have been reported as spam (if any have). * Templates are translatable and (should be) compatible with more email clients.
Tasks still to be done include: * A means by which invitees can be allowed into a closed wiki. * Invitation of a mailing list. * Handling "join requests". * Use javascript to make it easier to use and implement livetable * Improve CSS.
WDYT?
Caleb
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
participants (3)
-
Caleb James DeLisle -
Guillaume Lerouge -
Jerome Velociter