On Mon, Feb 22, 2010 at 10:50, stefan bachert <[email protected]> wrote:

Hi,

I figured out the macro capability. That is real powerful stuff.

However, I failed to pass a list to macros. Is this a bug or by design?

It depends what you mean exactly by "pass a list to macros".

Stefan Bachert

__________________________________________________ Do You Yahoo!? Sie sind Spam leid? Yahoo! Mail verfügt über einen herausragenden Schutz gegen Massenmails. http://mail.yahoo.com _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users

-- Thomas Mortagne

On Tue, Feb 23, 2010 at 09:07, Stefan Bachert <[email protected]> wrote:

Ok, let's go into details.

I want to create a macro which build a <select> with its <option> tag. Let call them {{buildSelect values=.. /}} For the option items I need a list of string values calling {{buildSelect values=["a","b","c"] /}} does not work. Display values in the macro just shows "[".

You need to escape " because it's part of the macro parameter syntax. {{buildSelect values=[~"a~",~"b~",~"c~"] /}} But are you sure you need " characters ? {{buildSelect values=a,b,c /}} should be enough Unless you want to interpret this string as velocity code in a wiki macro but it seems very dangerous (a user could put any velocity he wants as parameter of your macro).

OK, there is a workaround. Passing a string

{{buildSelect values=["a|b|c"] /}} and applying $util.split works

I guess this is a bug. -- View this message in context: http://n2.nabble.com/macros-and-lists-tp4611119p4617554.html Sent from the XWiki- Users mailing list archive at Nabble.com. _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users

-- Thomas Mortagne

Hi Thomas, For me it looks that ALL parameter will be converted to STRING Let's go into concrete ------------ How to be defined ------------- {{velocity}} #set($list = $xcontext.macro.params.listX) list = $list #foreach($x in $list) item = $x #end {{/velocity}} ------------ How to apply ------------- {{velocity}} #set($list =["aha","oho"]) {{passList listX=$list /}} #set($list =["aha","oho"]) {{passList listX=list /}} #set($list ="aha oho") {{passList listX=$list /}} {{passList listX="aha|oho" /}} {{passList listX=["aha","oho"] /}} {{passList listX="aha","oho" /}} {{passList listX=[aha,oho] /}} {{passList listX=aha,oho /}} {{/velocity}} -------- this is the output ---------- list = [aha, list = list list = aha list = aha|oho list = [ list = aha list = [aha,oho] list = aha,oho ----------------------------------- Stefan Bachert -- View this message in context: http://n2.nabble.com/macros-and-lists-tp4611119p4617869.html Sent from the XWiki- Users mailing list archive at Nabble.com.

On 02/23/2010 10:33 AM, Stefan Bachert wrote:

Hi Thomas,

For me it looks that ALL parameter will be converted to STRING Let's go into concrete

------------ How to be defined ------------- {{velocity}} #set($list = $xcontext.macro.params.listX) list = $list #foreach($x in $list) item = $x #end {{/velocity}} ------------ How to apply ------------- {{velocity}}

#set($list =["aha","oho"]) {{passList listX=$list /}}

Macros don't speak Velocity. This should never work as you expect it to. First, velocity is executed, and $list is printed, resulting in: {{passList listX=[aha, oho] /}} Then the parameters are normalized, resulting in {{passList listX="[aha," oho]="" /}} Thus the actual result, listX = "aha[".

#set($list =["aha","oho"]) {{passList listX=list /}}

Here velocity does not affect the macro in any way, since it does not contain any velocity code. It's important to understand that Velocity is not a central dogma in the wiki syntax anymore, it's just a scripting language that can be executed inside a {{velocity}} marker. Macros don't natively know about velocity, they don't use velocity variables in any way. So, again, velocity is executed, but this time nothing is printed, resulting in just the macro line: {{passList listX=list /}} which is normalized to {{passList listX="list" /}} and thus the "list" result.

#set($list ="aha oho") {{passList listX=$list /}}

After executing velocity, this becomes: {{passList listX=aha oho /}} normalized as: {{passList listX="aha" oho="" /}} thus listX = "aha"

{{passList listX="aha|oho" /}}

Nothing special, listX is the string "aha|oho"

{{passList listX=["aha","oho"] /}}

I don't know how exactly this gets normalized, but it starts as: {{passList listX="["

{{passList listX="aha","oho" /}}

{{passList listX="aha" oho="" /}}

{{passList listX=[aha,oho] /}}

Normalized as {{passList listX="[aha,oho]" /}}

{{passList listX=aha,oho /}}

Normalized as {{passList listX="aha,oho" /}} So, in conclusion, it's impossible to pass lists as macro parameter values, but not because it's a bug (macro parameters don't know velocity, and they don't use the same syntax), but because this is how we defined the behavior. The only workaround is to pass a string and split it in the macro code. If you think that this is an important requirement, you can propose it as an improvement of the upcoming xwiki/2.1 syntax.

{{/velocity}} -------- this is the output ---------- list = [aha,

list = list

list = aha

list = aha|oho

list = [

list = aha

list = [aha,oho]

list = aha,oho

-- Sergiu Dumitriu http://purl.org/net/sergiu/

On Wed, Feb 24, 2010 at 23:57, Jeremie BOUSQUET <[email protected]> wrote:

If I can give my opinion, I think it would be more coherent if macro parameters were defined like class properties are (lists, strings, numbers, Dates, list of users or groups, and so on...).

That's exactly how real (JAVA) macros are defined and what is supported by the WYSIWYG. It's just a temporary limitation of WIKI macros. (See http://platform.xwiki.org/xwiki/bin/view/DevGuide/RenderingMacroTutorial)

But it would not be a requirement for me, just an interesting improvement. And I'm not sure about how this could be done ... Maybe having a XWikiMacroParameterXxxClass for each property type Xxx ? At the end it's more the way data is entered by user that's interesting. Having a macro {{avatar}} in wich user can choose from a list of wiki users would definitely make macros even more extraordinary :) Of course the macros would have to accept the possible java types of the various properties types (strings, lists, integers...) so it would be a change in syntax.

2010/2/23 Sergiu Dumitriu <[email protected]>

...

If you think that this is an important requirement, you can propose it as an improvement of the upcoming xwiki/2.1 syntax.

_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users

-- Thomas Mortagne