Fair question. The reason it's not been applied yet IMO is because none of the current committers are using LDAP and thus noboydy has taken the time to learn how to set up a LDAP environment and test the patch.

As a side note, the JBoss Portal has a testing infrastructure for their ldap integration using OpenDS. If someone wants to get serious about integrating ldap into XWiki, that might be a good starting point.

So what would help would be if you could apply the patch on a XWiki SVN trunk version and verify it works fine and doesn't break anything existing. Reporting that in the jira issue will help a lot and then one of the committer could more easily apply the patch.

Basically, things work. I have checked authentication and mapping of ldap groups to XWiki groups and will start to use this in production in a week or two. However, the comments that 'simple user' made in jira are all very valid. There are edge cases where the code isn't correct, and it definitively needs a review by someone experienced with XWiki internals. The author of the patch, Gunter Leeb, already statet this, as he had to made a lot of assumptions in the code.

From looking at the code, there's a lot of "if xwiki.internal.isTrue(), then everything should work" without else cases. For example I remember something like xwikicontext.isVirtual(), where nothing is done if the context is not virtual.

So, basically, I couldn't tell you anything more than others already did. I will make a comment in jira once I had the patch running for a few weeks. Thanks, Tobias