[xwiki-users] How to add a sub-menu button for image menu in wysiwyg editor inline form
Hi, all, I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called? Thanks very much in advance!! Dave
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote:
Hi, all,
I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called?
You can find here https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... . The actual code that fills the image menu is https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik... . You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time. Hope this helps, Marius
Thanks very much in advance!!
Dave _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
Ok, thanks very much for your help. Dave On Fri, Apr 6, 2012 at 6:50 AM, Marius Dumitru Florea < [email protected]> wrote:
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote:
Hi, all,
I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called?
You can find here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... . The actual code that fills the image menu is
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik... .
You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time.
Hope this helps, Marius
Thanks very much in advance!!
Dave _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
Hi, Marius, I looked at the source code, and downloaded the whole 4.1 source code zip file, it seems like I need to change the source code in the plugin.image package, but I am using the 3.5 version stable release, I can see these two jar files have WYSIWYG editor: xwiki-platform-wysiwyg-client-3.5-shared.jar, xwiki-platform-legacy-oldcore-3.5.jar, so I have to either change code for 3.5 version, or upgrade my deployment to 4.1 with my new image handling code for addComment tool, also If I change the original source code, in the future if we need upgrade to new xwiki release, we need to merge the addComment tool again, so what is the best way to do that? is there a way to add the tool by coding in javascript without touching the gwt plugin java code, or write java code by extending ImagePlugin with new method to add comment, and then built into a new Jar. Thanks for your response again. Dave On Fri, Apr 6, 2012 at 7:17 PM, du du <[email protected]> wrote:
Ok, thanks very much for your help. Dave
On Fri, Apr 6, 2012 at 6:50 AM, Marius Dumitru Florea < [email protected]> wrote:
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote:
Hi, all,
I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called?
You can find here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... . The actual code that fills the image menu is
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik... .
You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time.
Hope this helps, Marius
Thanks very much in advance!!
Dave _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
On Sat, Apr 28, 2012 at 5:23 AM, Geo Du <[email protected]> wrote:
Hi, Marius,
I looked at the source code, and downloaded the whole 4.1 source code zip
You should clone/fork https://github.com/xwiki/xwiki-platform instead and then create a branch based on the tag corresponding to the version of XWiki Enterprise you're using (i.e. checkout xwiki-platform-3.5 tag and then create a branch from it where you make your changes). Unfortunately you can't add your new feature without modifying a bit the code of the WYSIWYG editor, but it should be pretty easy to merge your changes automatically with Git when you upgrade to a new version of XWiki Enterprise. In your branch, you can either modify the existing image plugin or extend it in a new plugin (kept inside xwiki-platform/xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client under org.xwiki.gwt.wysiwyg.client.plugin package).
file, it seems like I need to change the source code in the plugin.image package, but I am using the 3.5 version stable release, I can see these two jar files have WYSIWYG editor: xwiki-platform-wysiwyg-client-3.5-shared.jar, xwiki-platform-legacy-oldcore-3.5.jar, so I have to either change code for
Note that the editor has a client side and a server side. If you modify the server side it's enough to rebuild the xwiki-platform-wysiwyg-server jar and overwrite the one from your XE's WEB-INF/lib folder. If you modify the client side then you must rebuild xwiki-platform-wysiwyg-client and then xwiki-platform-wysiwyg-war and replace resources/js/xwiki/wysiwyg/xwe folder from XE with the one from the generated war.
3.5 version, or upgrade my deployment to 4.1 with my new image handling
The editor version should match the XE version.
code for addComment tool, also If I change the original source code, in the future if we need upgrade to new xwiki release, we need to merge the addComment tool again, so what is the best way to do that? is there a way
As I said above, using Git you should be able to automatically merge your changes most of the time.
to add the tool by coding in javascript without touching the gwt plugin
You could try, see the JavaScript API exposed by the WYSIWYG editor http://extensions.xwiki.org/xwiki/bin/view/Extension/WYSIWYG+Editor+Module#H... .
java code, or write java code by extending ImagePlugin with new method to
It's not that easy because when we wrote the image plugin we didn't thought to much of how it could be extended. Some methods are private and some are hard to extends. But still, you can try. Hope this helps, Marius
add comment, and then built into a new Jar.
Thanks for your response again.
Dave
On Fri, Apr 6, 2012 at 7:17 PM, du du <[email protected]> wrote:
Ok, thanks very much for your help. Dave
On Fri, Apr 6, 2012 at 6:50 AM, Marius Dumitru Florea < [email protected]> wrote:
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote:
Hi, all,
I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called?
You can find here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik... . The actual code that fills the image menu is
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik... .
You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time.
Hope this helps, Marius
Thanks very much in advance!!
Dave _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
Hi, Marius, Thanks very much, I will follow your instruction. Dave On Sat, Apr 28, 2012 at 5:28 AM, Marius Dumitru Florea < [email protected]> wrote:
On Sat, Apr 28, 2012 at 5:23 AM, Geo Du <[email protected]> wrote:
Hi, Marius,
I looked at the source code, and downloaded the whole 4.1 source code zip
You should clone/fork https://github.com/xwiki/xwiki-platform instead and then create a branch based on the tag corresponding to the version of XWiki Enterprise you're using (i.e. checkout xwiki-platform-3.5 tag and then create a branch from it where you make your changes).
Unfortunately you can't add your new feature without modifying a bit the code of the WYSIWYG editor, but it should be pretty easy to merge your changes automatically with Git when you upgrade to a new version of XWiki Enterprise.
In your branch, you can either modify the existing image plugin or extend it in a new plugin (kept inside
xwiki-platform/xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client under org.xwiki.gwt.wysiwyg.client.plugin package).
file, it seems like I need to change the source code in the plugin.image package, but I am using the 3.5 version stable release, I can see these two jar files have WYSIWYG editor: xwiki-platform-wysiwyg-client-3.5-shared.jar, xwiki-platform-legacy-oldcore-3.5.jar, so I have to either change code for
Note that the editor has a client side and a server side. If you modify the server side it's enough to rebuild the xwiki-platform-wysiwyg-server jar and overwrite the one from your XE's WEB-INF/lib folder. If you modify the client side then you must rebuild xwiki-platform-wysiwyg-client and then xwiki-platform-wysiwyg-war and replace resources/js/xwiki/wysiwyg/xwe folder from XE with the one from the generated war.
3.5 version, or upgrade my deployment to 4.1 with my new image handling
The editor version should match the XE version.
code for addComment tool, also If I change the original source code, in the future if we need upgrade to new xwiki release, we need to merge the addComment tool again, so what is the best way to do that? is there a way
As I said above, using Git you should be able to automatically merge your changes most of the time.
to add the tool by coding in javascript without touching the gwt plugin
You could try, see the JavaScript API exposed by the WYSIWYG editor
http://extensions.xwiki.org/xwiki/bin/view/Extension/WYSIWYG+Editor+Module#H... .
java code, or write java code by extending ImagePlugin with new method to
It's not that easy because when we wrote the image plugin we didn't thought to much of how it could be extended. Some methods are private and some are hard to extends. But still, you can try.
Hope this helps, Marius
add comment, and then built into a new Jar.
Thanks for your response again.
Dave
On Fri, Apr 6, 2012 at 7:17 PM, du du <[email protected]> wrote:
Ok, thanks very much for your help. Dave
On Fri, Apr 6, 2012 at 6:50 AM, Marius Dumitru Florea < [email protected]> wrote:
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote:
Hi, all,
I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called?
You can find here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
. The actual code that fills the image menu is
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik...
.
You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time.
Hope this helps, Marius
Thanks very much in advance!!
Dave _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
Hi, Marius, Thanks for your response, I have two more questions, 1. When I test the Blog.CreatePost page, I can see the XWikiWysiwyg.js file loaded when it is on wysiwyg editor mode, but I donot see anywhere importing the XWikiWysiwyg.js file except the macros.vm where #macro(wysiwyg_import $lazy) uses the javascript as: $xwiki.jsfx.use("js/xwiki/wysiwyg/xwe/XWikiWysiwyg.js", {"forceSkinAction": true, "lazy": ${lazy}, 'defer': false}) so I created my own javascript XWikiWysiwygExt.js, loaded as this: $xwiki.jsfx.use("js/xwiki/wysiwyg/xwe/XWikiWysiwygExt.js", {"forceSkinAction": true, "lazy": ${lazy}, 'defer': false}) but when I debug with firebug and load the CreatePost page in WYSIWYG mode, I can see the XWikiWysiwyg.js is loaded, but my XWikiWysiwygExt.js file is not loaded, I already put the file in the same directory as the XWikiWysiwyg.js file. 2. So I tried different approach by creating a BlogScript javascript extension and addeds as this: {{include document="Blog.BlogCode"/}} {{velocity filter="none"}} {{html clean="false" wiki="true"}} #if($hasEdit) $xwiki.jsx.use($blogScriptsDocumentName,{'minify':false,'defer':false})## ## My issue is the 'minify':false does not work, it always shows the minified version of the code, which I cannot debug, but I can see the minified code. So do you have any solutions about these two issues? Thanks again for your great help. Dave On Sat, Apr 28, 2012 at 5:28 AM, Marius Dumitru Florea < [email protected]> wrote:
On Sat, Apr 28, 2012 at 5:23 AM, Geo Du <[email protected]> wrote:
Hi, Marius,
I looked at the source code, and downloaded the whole 4.1 source code zip
You should clone/fork https://github.com/xwiki/xwiki-platform instead and then create a branch based on the tag corresponding to the version of XWiki Enterprise you're using (i.e. checkout xwiki-platform-3.5 tag and then create a branch from it where you make your changes).
Unfortunately you can't add your new feature without modifying a bit the code of the WYSIWYG editor, but it should be pretty easy to merge your changes automatically with Git when you upgrade to a new version of XWiki Enterprise.
In your branch, you can either modify the existing image plugin or extend it in a new plugin (kept inside
xwiki-platform/xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client under org.xwiki.gwt.wysiwyg.client.plugin package).
file, it seems like I need to change the source code in the plugin.image package, but I am using the 3.5 version stable release, I can see these two jar files have WYSIWYG editor: xwiki-platform-wysiwyg-client-3.5-shared.jar, xwiki-platform-legacy-oldcore-3.5.jar, so I have to either change code for
Note that the editor has a client side and a server side. If you modify the server side it's enough to rebuild the xwiki-platform-wysiwyg-server jar and overwrite the one from your XE's WEB-INF/lib folder. If you modify the client side then you must rebuild xwiki-platform-wysiwyg-client and then xwiki-platform-wysiwyg-war and replace resources/js/xwiki/wysiwyg/xwe folder from XE with the one from the generated war.
3.5 version, or upgrade my deployment to 4.1 with my new image handling
The editor version should match the XE version.
code for addComment tool, also If I change the original source code, in the future if we need upgrade to new xwiki release, we need to merge the addComment tool again, so what is the best way to do that? is there a way
As I said above, using Git you should be able to automatically merge your changes most of the time.
to add the tool by coding in javascript without touching the gwt plugin
You could try, see the JavaScript API exposed by the WYSIWYG editor
http://extensions.xwiki.org/xwiki/bin/view/Extension/WYSIWYG+Editor+Module#H... .
java code, or write java code by extending ImagePlugin with new method to
It's not that easy because when we wrote the image plugin we didn't thought to much of how it could be extended. Some methods are private and some are hard to extends. But still, you can try.
Hope this helps, Marius
add comment, and then built into a new Jar.
Thanks for your response again.
Dave
On Fri, Apr 6, 2012 at 7:17 PM, du du <[email protected]> wrote:
Ok, thanks very much for your help. Dave
On Fri, Apr 6, 2012 at 6:50 AM, Marius Dumitru Florea < [email protected]> wrote:
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote:
Hi, all,
I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called?
You can find here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
. The actual code that fills the image menu is
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik...
.
You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time.
Hope this helps, Marius
Thanks very much in advance!!
Dave _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
I got the second problem solved. but first one still not solved. Thanks On Mon, Apr 30, 2012 at 11:32 PM, Geo Du <[email protected]> wrote:
Hi, Marius,
Thanks for your response, I have two more questions, 1. When I test the Blog.CreatePost page, I can see the XWikiWysiwyg.js file loaded when it is on wysiwyg editor mode, but I donot see anywhere importing the XWikiWysiwyg.js file except the macros.vm where #macro(wysiwyg_import $lazy) uses the javascript as: $xwiki.jsfx.use("js/xwiki/wysiwyg/xwe/XWikiWysiwyg.js", {"forceSkinAction": true, "lazy": ${lazy}, 'defer': false})
so I created my own javascript XWikiWysiwygExt.js, loaded as this:
$xwiki.jsfx.use("js/xwiki/wysiwyg/xwe/XWikiWysiwygExt.js", {"forceSkinAction": true, "lazy": ${lazy}, 'defer': false})
but when I debug with firebug and load the CreatePost page in WYSIWYG mode, I can see the XWikiWysiwyg.js is loaded, but my XWikiWysiwygExt.js file is not loaded, I already put the file in the same directory as the XWikiWysiwyg.js file.
2. So I tried different approach by creating a BlogScript javascript extension and addeds as this:
{{include document="Blog.BlogCode"/}}
{{velocity filter="none"}} {{html clean="false" wiki="true"}}
#if($hasEdit) $xwiki.jsx.use($blogScriptsDocumentName,{'minify':false,'defer':false})## ##
My issue is the 'minify':false does not work, it always shows the minified version of the code, which I cannot debug, but I can see the minified code.
So do you have any solutions about these two issues?
Thanks again for your great help.
Dave
On Sat, Apr 28, 2012 at 5:28 AM, Marius Dumitru Florea < [email protected]> wrote:
On Sat, Apr 28, 2012 at 5:23 AM, Geo Du <[email protected]> wrote:
Hi, Marius,
I looked at the source code, and downloaded the whole 4.1 source code zip
You should clone/fork https://github.com/xwiki/xwiki-platform instead and then create a branch based on the tag corresponding to the version of XWiki Enterprise you're using (i.e. checkout xwiki-platform-3.5 tag and then create a branch from it where you make your changes).
Unfortunately you can't add your new feature without modifying a bit the code of the WYSIWYG editor, but it should be pretty easy to merge your changes automatically with Git when you upgrade to a new version of XWiki Enterprise.
In your branch, you can either modify the existing image plugin or extend it in a new plugin (kept inside
xwiki-platform/xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client under org.xwiki.gwt.wysiwyg.client.plugin package).
file, it seems like I need to change the source code in the plugin.image package, but I am using the 3.5 version stable release, I can see these two jar files have WYSIWYG editor: xwiki-platform-wysiwyg-client-3.5-shared.jar, xwiki-platform-legacy-oldcore-3.5.jar, so I have to either change code for
Note that the editor has a client side and a server side. If you modify the server side it's enough to rebuild the xwiki-platform-wysiwyg-server jar and overwrite the one from your XE's WEB-INF/lib folder. If you modify the client side then you must rebuild xwiki-platform-wysiwyg-client and then xwiki-platform-wysiwyg-war and replace resources/js/xwiki/wysiwyg/xwe folder from XE with the one from the generated war.
3.5 version, or upgrade my deployment to 4.1 with my new image handling
The editor version should match the XE version.
code for addComment tool, also If I change the original source code, in the future if we need upgrade to new xwiki release, we need to merge the addComment tool again, so what is the best way to do that? is there a way
As I said above, using Git you should be able to automatically merge your changes most of the time.
to add the tool by coding in javascript without touching the gwt plugin
You could try, see the JavaScript API exposed by the WYSIWYG editor
http://extensions.xwiki.org/xwiki/bin/view/Extension/WYSIWYG+Editor+Module#H... .
java code, or write java code by extending ImagePlugin with new method to
It's not that easy because when we wrote the image plugin we didn't thought to much of how it could be extended. Some methods are private and some are hard to extends. But still, you can try.
Hope this helps, Marius
add comment, and then built into a new Jar.
Thanks for your response again.
Dave
On Fri, Apr 6, 2012 at 7:17 PM, du du <[email protected]> wrote:
Ok, thanks very much for your help. Dave
On Fri, Apr 6, 2012 at 6:50 AM, Marius Dumitru Florea < [email protected]> wrote:
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote:
Hi, all,
I am trying to add an addComments sub-menu item to image button from the menu bar of WYSIWYG editor, what it does is to add comments for an image inserted in the editor because I need to explain what each image is about after I put it in the editor, I checked the class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a sub-menu in the WysiwygEditorConfigClass for image menu, but after that, I got lost, this sub-menu button is supposed to connect to a plugin to trigger java to run I believe since it is a plugin and each sub-menu like imageInsertAttached, imageInsertURL is a plugin, but I could not find the code where it calls a plugin, so how is the sub-menu button hooked to the plugin? when a user clicks on the submenu button in the editor (inline form) page, which javascript function gets called?
You can find here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
. The actual code that fills the image menu is
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik...
.
You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time.
Hope this helps, Marius
Thanks very much in advance!!
Dave _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
On Wed, May 2, 2012 at 5:50 AM, Geo Du <[email protected]> wrote:
I got the second problem solved. but first one still not solved.
Thanks
On Mon, Apr 30, 2012 at 11:32 PM, Geo Du <[email protected]> wrote:
Hi, Marius,
Thanks for your response, I have two more questions, 1. When I test the Blog.CreatePost page, I can see the XWikiWysiwyg.js file loaded when it is on wysiwyg editor mode, but I donot see anywhere importing the XWikiWysiwyg.js file except the macros.vm where #macro(wysiwyg_import $lazy) uses the javascript as: $xwiki.jsfx.use("js/xwiki/wysiwyg/xwe/XWikiWysiwyg.js", {"forceSkinAction": true, "lazy": ${lazy}, 'defer': false})
BlogPostClass has two TextArea properties. BlogPostSheet displays these properties by calling $doc.display. This method adds the property ID to a list if the property is editable with the WYSIWYG editor. This list can be retrieved with $xcontext.getEditorWysiwyg() . textarea_wysiwyg.vm Velocity template, included (indirectly) from edit.vm, takes this list and creates the necessary WYSIWYG editors by calling macros (e.g. #wysiwyg_editProperties) from macros.vm . #wysiwyg_import is one of these macros.
so I created my own javascript XWikiWysiwygExt.js, loaded as this:
Why do you need your own XWikiWysiwyg.js file?
$xwiki.jsfx.use("js/xwiki/wysiwyg/xwe/XWikiWysiwygExt.js", {"forceSkinAction": true, "lazy": ${lazy}, 'defer': false})
"forceSkinAction": true is for parsing XWikiWysiwyg.js for Velocity code. Do you have Velocity code in your file? "lazy": ${lazy} is read from the request URL using Velocity code inside XWikiWysiwyg.js . Do you need it?
but when I debug with firebug and load the CreatePost page in WYSIWYG mode, I can see the XWikiWysiwyg.js is loaded, but my XWikiWysiwygExt.js file is not loaded, I already put the file in the same directory as the XWikiWysiwyg.js file.
macros.vm is cached after each server restart to improve performance. Each modification requires a server restart. Hope this helps, Marius
2. So I tried different approach by creating a BlogScript javascript extension and addeds as this:
{{include document="Blog.BlogCode"/}}
{{velocity filter="none"}} {{html clean="false" wiki="true"}}
#if($hasEdit) $xwiki.jsx.use($blogScriptsDocumentName,{'minify':false,'defer':false})## ##
My issue is the 'minify':false does not work, it always shows the minified version of the code, which I cannot debug, but I can see the minified code.
So do you have any solutions about these two issues?
Thanks again for your great help.
Dave
On Sat, Apr 28, 2012 at 5:28 AM, Marius Dumitru Florea < [email protected]> wrote:
On Sat, Apr 28, 2012 at 5:23 AM, Geo Du <[email protected]> wrote:
Hi, Marius,
I looked at the source code, and downloaded the whole 4.1 source code zip
You should clone/fork https://github.com/xwiki/xwiki-platform instead and then create a branch based on the tag corresponding to the version of XWiki Enterprise you're using (i.e. checkout xwiki-platform-3.5 tag and then create a branch from it where you make your changes).
Unfortunately you can't add your new feature without modifying a bit the code of the WYSIWYG editor, but it should be pretty easy to merge your changes automatically with Git when you upgrade to a new version of XWiki Enterprise.
In your branch, you can either modify the existing image plugin or extend it in a new plugin (kept inside
xwiki-platform/xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client under org.xwiki.gwt.wysiwyg.client.plugin package).
file, it seems like I need to change the source code in the plugin.image package, but I am using the 3.5 version stable release, I can see these two jar files have WYSIWYG editor: xwiki-platform-wysiwyg-client-3.5-shared.jar, xwiki-platform-legacy-oldcore-3.5.jar, so I have to either change code for
Note that the editor has a client side and a server side. If you modify the server side it's enough to rebuild the xwiki-platform-wysiwyg-server jar and overwrite the one from your XE's WEB-INF/lib folder. If you modify the client side then you must rebuild xwiki-platform-wysiwyg-client and then xwiki-platform-wysiwyg-war and replace resources/js/xwiki/wysiwyg/xwe folder from XE with the one from the generated war.
3.5 version, or upgrade my deployment to 4.1 with my new image handling
The editor version should match the XE version.
code for addComment tool, also If I change the original source code, in the future if we need upgrade to new xwiki release, we need to merge the addComment tool again, so what is the best way to do that? is there a way
As I said above, using Git you should be able to automatically merge your changes most of the time.
to add the tool by coding in javascript without touching the gwt plugin
You could try, see the JavaScript API exposed by the WYSIWYG editor
http://extensions.xwiki.org/xwiki/bin/view/Extension/WYSIWYG+Editor+Module#H... .
java code, or write java code by extending ImagePlugin with new method to
It's not that easy because when we wrote the image plugin we didn't thought to much of how it could be extended. Some methods are private and some are hard to extends. But still, you can try.
Hope this helps, Marius
add comment, and then built into a new Jar.
Thanks for your response again.
Dave
On Fri, Apr 6, 2012 at 7:17 PM, du du <[email protected]> wrote:
Ok, thanks very much for your help. Dave
On Fri, Apr 6, 2012 at 6:50 AM, Marius Dumitru Florea < [email protected]> wrote:
On Fri, Apr 6, 2012 at 1:49 AM, du du <[email protected]> wrote: > Hi, all, > > I am trying to add an addComments sub-menu item to image button from the > menu bar of WYSIWYG editor, what it does is to add comments for an image > inserted in the editor because I need to explain what each image is about > after I put it in the editor, I checked the > class:XWiki.WysiwygEditorConfigClass and the wysiwyg.js, I added a > sub-menu in > the WysiwygEditorConfigClass for image menu, but after that, I got lost, > this sub-menu button is supposed to connect to a plugin to trigger java to > run I believe since it is a plugin and each sub-menu like > imageInsertAttached, imageInsertURL is a plugin, but I could not find the > code where it calls a plugin, so how is the sub-menu button hooked to the > plugin? when a user clicks on the submenu button in the editor (inline > form) page, which javascript function gets called?
You can find here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
the code of the WYSIWYG content editor. For instance, the image plugin, which handles the image menu, is located here
https://github.com/xwiki/xwiki-platform/tree/master/xwiki-platform-core/xwik...
. The actual code that fills the image menu is
https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwik...
.
You should know that the WYSIWYG content editor is written using Google WebToolkit (GWT). The Java code is compiled into JavaScript at build time.
Hope this helps, Marius
> > Thanks very much in advance!! > > Dave > _______________________________________________ > users mailing list > [email protected] > http://lists.xwiki.org/mailman/listinfo/users _______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
_______________________________________________ users mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/users
participants (3)
-
du du -
Geo Du
-
Marius Dumitru Florea