August 2026 - notifications

[xwiki/xwiki-platform] e92bd7: [Misc] Fix SonarQube issues in test code (nested m...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/claude/clever-feynman-gcoqad Home: https://github.com/xwiki/xwiki-platform Commit: e92bd7924eced3018e1712d6dffaf808a1bf251a https://github.com/xwiki/xwiki-platform/commit/e92bd7924eced3018e1712d6dffa… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/test/java/org/xwiki/eventstream/internal/UntypedEventListenerTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/test/java/org/xwiki/eventstream/internal/UntypedRecordableEventDescriptorComponentBuilderTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/integration/AuthenticatingIntegrationTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/integration/ScriptingIntegrationTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/factory/files/SerializedFilesMimeMessageIteratorTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/factory/group/GroupMimeMessageIteratorTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/factory/template/DefaultMailTemplateManagerTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/thread/PrepareMailRunnableTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/thread/SendMailRunnableTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/test/java/org/xwiki/notifications/filters/internal/DefaultNotificationFilterDisplayerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/test/java/org/xwiki/notifications/filters/internal/DefaultNotificationFilterPreferenceManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/test/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilterTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/test/java/org/xwiki/notifications/filters/internal/DocumentMovedListenerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/test/java/org/xwiki/notifications/filters/internal/UserAddedEventListenerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailSenderTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/rss/DefaultNotificationRSSRendererTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiAttachmentTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/stats/impl/StatsUtilTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStoreTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/XWikiHibernateStoreTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutorTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/web/ExportActionTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/web/SaveActionTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/SolrRatingsManagerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/averagerating/SolrAverageRatingManagerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/job/XClassDeletingListenerTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/classes/StaticListClassPropertyValuesProviderTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/classes/UsersClassPropertyValuesProviderTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/pages/PageResourceImplTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/DefaultUserPropertiesResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentUserManagerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/NormalUserPreferencesConfigurationSourceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/UserPreferencesConfigurationSourceTest.java Log Message: ----------- [Misc] Fix SonarQube issues in test code (nested mock creation, useless eq() matchers) * java:S9016: extract nested mock creations into local variables (52 occurrences) * java:S6068: remove useless Mockito eq() matchers (18 occurrences) Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-rendering] 3a0fd1: [Misc] Fix various SonarQube issues
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/claude/peaceful-archimedes-gcoqad Home: https://github.com/xwiki/xwiki-rendering Commit: 3a0fd15af869eef504a5847680a3f8e398a8b8c4 https://github.com/xwiki/xwiki-rendering/commit/3a0fd15af869eef504a5847680a… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-rendering-legacy/xwiki-rendering-legacy-api/src/test/java/org/xwiki/rendering/internal/syntax/DeprecatedSyntaxConverterTest.java R xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki20/src/main/java/org/xwiki/rendering/internal/renderer/xwiki20/AbstractXWikiSyntaxResourceRenderer.java M xwiki-rendering-test/src/main/java/org/xwiki/rendering/test/integration/TestDataParser.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/main/java/org/xwiki/rendering/macro/AbstractMacro.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/xhtml/impl/MacroInfo.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S1117: rename two local variables hiding a field * java:S2094: remove an unused empty abstract class * java:S4719: use StandardCharsets.UTF_8 instead of the "UTF-8" charset name * java:S8714: replace the try/catch/fail() idiom with assertThrows() Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-commons] 10e5c4: [Misc] Fix SonarQube issues in test code (nested m...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/claude/nifty-bell-gcoqad Home: https://github.com/xwiki/xwiki-commons Commit: 10e5c445bed57bcb557154ebd618a317a25b7d5e https://github.com/xwiki/xwiki-commons/commit/10e5c445bed57bcb557154ebd618a… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/AbstractExtensionHandlerTest.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/DefaultJobExecutorTest.java M xwiki-commons-core/xwiki-commons-store/xwiki-commons-store-blob/xwiki-commons-store-blob-s3/src/test/java/org/xwiki/store/blob/internal/S3CopyOperationsTest.java Log Message: ----------- [Misc] Fix SonarQube issues in test code (nested mock creation, useless eq() matchers) * java:S9016: extract nested mock creations into local variables (6 occurrences) * java:S6068: remove useless Mockito eq() matchers (4 occurrences) Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-commons] fa2b50: [Misc] Fix SonarQube issues: use assertThrows() in...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/claude/nifty-bell-gcoqad-s8714 Home: https://github.com/xwiki/xwiki-commons Commit: fa2b5037f7b3c62c085dfb3266a67818f50de565 https://github.com/xwiki/xwiki-commons/commit/fa2b5037f7b3c62c085dfb3266a67… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/repository/core/DefaultCoreExtensionRepositoryTest.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-handlers/xwiki-commons-extension-handler-jar/src/test/java/org/xwiki/extension/jar/JarExtensionHandlerTest.java M xwiki-commons-core/xwiki-commons-groovy/src/test/java/org/xwiki/groovy/internal/TimedInterruptGroovyCompilationCustomizerTest.java M xwiki-commons-core/xwiki-commons-websocket/src/test/java/org/xwiki/websocket/PartialBinaryMessageHandlerTest.java M xwiki-commons-core/xwiki-commons-websocket/src/test/java/org/xwiki/websocket/PartialStringMessageHandlerTest.java M xwiki-commons-core/xwiki-commons-websocket/src/test/java/org/xwiki/websocket/internal/XWikiEndpointConfiguratorTest.java Log Message: ----------- [Misc] Fix SonarQube issues: use assertThrows() in tests instead of try/catch/fail() * java:S8714: replace the try/catch/fail() idiom with assertThrows() (12 occurrences) Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform] 138a0c: [Misc] Apply the logging best practices to oldcore...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-batch6 Home: https://github.com/xwiki/xwiki-platform Commit: 138a0c6749e0c6d909a6ce1d32af8c094c784af5 https://github.com/xwiki/xwiki-platform/commit/138a0c6749e0c6d909a6ce1d32af… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-versioncheck/src/main/java/org/xwiki/extension/versioncheck/internal/VersionCheckInitializer.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/thread/MailSenderInitializerListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/User.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/context/RequestInitializer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/DocumentReferenceConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/pdf/FOPXSLFORenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/AbstractSheetBinder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/skin/AbstractSkin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/PropertyConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/InternalTemplateManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseElement.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/PdfExportImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R35102XWIKI7771DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/util/Util.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiServletURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/document/DocumentRequiredRightsReader.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/document/DocumentRequiredRightsReaderTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/XWikiResource.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/sx/AbstractSxAction.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/main/java/org/xwiki/wiki/internal/provisioning/DefaultWikiCopier.java Log Message: ----------- [Misc] Apply the logging best practices to oldcore and 5 more platform modules Closes out the SLF4J logging audit: the xwiki-platform-oldcore sites left over from the exceptions-discarded-in-a-catch pass, plus the last stragglers a re-run of both parsers surfaced elsewhere. * warn() in a catch now appends the root cause instead of dropping the exception; error() in a catch receives the caught exception itself. * XWiki.evaluateVelocity passed xe.getCause(), which is null when the exception has no cause, so no stack trace was ever logged. * VersionCheckInitializer passed the exception where a value was expected: the placeholder rendered literally and a warning printed a stack trace. * MailSenderInitializerListener announced the Prepare thread after stopping the Sender thread and vice versa. * User.isUserInGroup built its message with MessageFormat, XWikiResource used quotes and a trailing newline instead of brackets, DefaultWikiCopier logged the message-less form, AbstractSxAction used getMessage(). Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 8e8519: [Misc] Apply the logging best practices to 26 more...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-batch5 Home: https://github.com/xwiki/xwiki-platform Commit: 8e8519d66e093b1e9cb74dd51639839f8a0958e0 https://github.com/xwiki/xwiki-platform/commit/8e8519d66e093b1e9cb74dd51639… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/ActiveInstallsPingRunnable.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-validation/xwiki-platform-attachment-validation-api/src/main/java/org/xwiki/attachment/validation/AttachmentValidationScriptService.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-api/src/main/java/org/xwiki/captcha/script/CaptchaScriptService.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/bridge/DefaultWikiComponentBridge.java M xwiki-platform-core/xwiki-platform-csrf/src/main/java/org/xwiki/csrf/internal/DefaultCSRFToken.java M xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/main/java/org/xwiki/rendering/internal/macro/dashboard/DashboardMacro.java M xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/main/java/org/xwiki/rendering/internal/macro/dashboard/EditableGadgetRenderer.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-distribution/src/main/java/org/xwiki/extension/distribution/internal/job/AbstractDistributionJob.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-distribution/src/main/java/org/xwiki/extension/distribution/internal/job/step/CleanExtensionsDistributionStep.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/doc/InstalledExtensionDocumentListener.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/XarExtensionHandler.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/repository/InstalledExtensionSynchronizer.java M xwiki-platform-core/xwiki-platform-filter/xwiki-platform-filter-streams/xwiki-platform-filter-stream-xar/src/main/java/org/xwiki/filter/xar/internal/input/WikiReader.java M xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-default/src/main/java/org/xwiki/icon/internal/context/IconContextStore.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-processing/xwiki-platform-image-processing-plugin/src/main/java/com/xpn/xwiki/plugin/image/ImagePlugin.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/store/internal/RecordableEventMigrator.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/notify/XWikiPageNotification.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-wiki/src/main/java/org/xwiki/localization/wiki/internal/ComponentDocumentTranslationBundle.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-wiki/src/test/java/org/xwiki/localization/wiki/internal/ComponentDocumentTranslationBundleTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/MailConfigMandatoryDocumentInitializer.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/factory/usersandgroups/AddressUserDataExtractor.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/internal/reference/converter/EntityReferenceConverter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/AbstractMimeMessageIterator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-sources/src/main/java/org/xwiki/notifications/sources/internal/DefaultGroupingEventManager.java M xwiki-platform-core/xwiki-platform-panels/xwiki-platform-panels-api/src/main/java/org/xwiki/panels/internal/AbstractPanelsUIExtensionManager.java M xwiki-platform-core/xwiki-platform-panels/xwiki-platform-panels-api/src/test/java/org/xwiki/panels/internal/AbstractPanelsUIExtensionManagerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/RatingDeletedEntityListener.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/RatingMovedEntityListener.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/script/AbstractScriptRatingsManager.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractReplaceUserJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/job/ReplaceUserJob.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/ExtensionStore.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-script/src/main/java/org/xwiki/security/authentication/script/AuthenticationScriptService.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/sx/SxDocumentSource.java M xwiki-platform-core/xwiki-platform-tag/xwiki-platform-tag-api/src/main/java/com/xpn/xwiki/plugin/tag/TagPlugin.java M xwiki-platform-core/xwiki-platform-tag/xwiki-platform-tag-api/src/main/java/org/xwiki/tag/internal/selector/DefaultTagsSelector.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/src/main/java/org/xwiki/uiextension/script/UIExtensionScriptService.java M xwiki-platform-core/xwiki-platform-velocity/xwiki-platform-velocity-webapp/src/main/java/org/xwiki/velocity/XWikiWebappResourceLoader.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/property/DateXarObjectPropertySerializer.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/test/java/org/xwiki/xar/internal/property/DateXarObjectPropertySerializerTest.java Log Message: ----------- [Misc] Apply the logging best practices to 26 more platform modules Second pass of the SLF4J logging audit, covering a class the first pass excluded wholesale: log calls inside a catch block that throw away the exception they are holding. The blanket "error() without a Throwable is fine when no exception is in scope" exclusion does not apply inside a catch -- there the exception *is* in scope. 54 such sites are fixed across 26 modules: error() now receives the caught exception in the SLF4J Throwable slot, and warn() (which must not print a stack trace) now appends ExceptionUtils.getRootCauseMessage(e). Several were more than a style issue. Since SLF4J 1.7.26 a trailing Throwable is always trimmed off the argument array, so: * logger.error("... [{}]", e) logged the trace but left the {} unsubstituted, printing it literally. In IconContextStore that placeholder was meant for the icon set name, which was therefore never logged. * logger.error("... [{}]", ref, ExceptionUtils.getRootCause(e)) logged no trace at all whenever the exception had no cause, because getRootCause returns null then. All of xwiki-platform-ratings used this idiom. * XWikiPageNotification built a throwaway XWikiException in both of its catch blocks purely to format a string via getFullMessage(), logged that string and dropped the exception, so no stack trace was ever produced. Also picked up along the way: two WARNSTACK sites the first parser missed (WikiReader uses the Marker overload, which shifts the argument positions; DocumentContentAnnotationUpdateListener used the message-less warn(e.getMessage(), e) form), and the "Unexcepted" misspelling in IconContextStore. Deliberately left alone: InterruptedException catches (the root cause message renders as "InterruptedException: null"), expected-control-flow fallbacks, and the 26 remaining sites in xwiki-platform-oldcore, which are left for a follow-up. Tests and checkstyle (-Plegacy,quality) were run from each of the 31 affected module directories; all pass. Three tests asserting on a changed message were updated (AbstractPanelsUIExtensionManagerTest, ComponentDocumentTranslationBundleTest, DateXarObjectPropertySerializerTest). Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d903f8: [Misc] Apply the logging best practices to 15 more...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-batch4 Home: https://github.com/xwiki/xwiki-platform Commit: d903f8cb2f87607b018d1a7bc9319cd325d8d528 https://github.com/xwiki/xwiki-platform/commit/d903f8cb2f87607b018d1a7bc931… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-container/xwiki-platform-container-servlet/src/main/java/org/xwiki/container/servlet/HttpServletUtils.java M xwiki-platform-core/xwiki-platform-container/xwiki-platform-container-servlet/src/main/java/org/xwiki/container/servlet/filters/internal/SafeRedirectFilter.java M xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/main/java/org/xwiki/rendering/internal/macro/dashboard/DashboardMacro.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-default/src/main/java/org/xwiki/index/internal/DefaultTasksManager.java M xwiki-platform-core/xwiki-platform-javascript/xwiki-platform-javascript-importmap/src/main/java/org/xwiki/javascript/importmap/internal/JavascriptImportmapResolver.java M xwiki-platform-core/xwiki-platform-javascript/xwiki-platform-javascript-importmap/src/test/java/org/xwiki/javascript/importmap/internal/JavascriptImportmapResolverTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-script/src/main/java/org/xwiki/localization/script/LocalizationScriptService.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/main/java/org/xwiki/sheet/internal/DefaultSheetManager.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/main/java/org/xwiki/sheet/internal/SheetDocumentDisplayer.java M xwiki-platform-core/xwiki-platform-tika/xwiki-platform-tika-detect/src/main/java/org/xwiki/tika/internal/TikaUtils.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/main/java/org/xwiki/uiextension/internal/WikiUIExtensionParameters.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/WikiUIExtensionParametersTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-script/src/main/java/org/xwiki/user/script/GroupScriptService.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-script/src/test/java/org/xwiki/user/script/GroupScriptServiceTest.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/internal/converter/AbstractRequestParameterConverter.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptService.java M xwiki-platform-core/xwiki-platform-xml/xwiki-platform-xml-script/src/main/java/org/xwiki/xml/script/XMLScriptService.java M xwiki-platform-core/xwiki-platform-zipexplorer/src/main/java/com/xpn/xwiki/plugin/zipexplorer/ZipExplorerPlugin.java M xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards/src/test/it/org/xwiki/test/webstandards/framework/AbstractValidationTest.java Log Message: ----------- [Misc] Apply the logging best practices to 15 more platform modules Last batch of the logging best-practices audit: the 15 modules that had only one or two offending call sites each. * `warn()` no longer passes a Throwable: the stack trace leaves the SLF4J slot and the cause is surfaced through `ExceptionUtils.getRootCauseMessage()`. * `String.format()` and string concatenation replaced with `{}` placeholders and arguments. * `warn()` calls using `e.getMessage()` switched to `ExceptionUtils.getRootCauseMessage()`, which surfaces the underlying cause. * Values wrapped in `[]`, and trailing whitespace trimmed from messages. `DashboardMacro` also stopped discarding its `ComponentLookupException` entirely: the log line now names its root cause. The two `LogCaptureExtension`-based tests that assert the rendered message were updated. Their exception fixtures had no message, which would have rendered an uninformative `[GroupException: ]`, so they now carry a distinct message each. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] c4113d: [Misc] Apply the logging best practices to 15 more...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-batch3 Home: https://github.com/xwiki/xwiki-platform Commit: c4113d0450729e7fc4034a6bd09fa8303a1e19fc https://github.com/xwiki/xwiki-platform/commit/c4113d0450729e7fc4034a6bd09f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-configuration/xwiki-platform-configuration-default/src/main/java/org/xwiki/configuration/internal/XWikiPropertiesConfigurationSource.java M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-api/src/main/java/org/xwiki/display/internal/AbstractDocumentTitleDisplayer.java M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-api/src/main/java/org/xwiki/display/internal/DocumentContentAsyncExecutor.java M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/util/TidyMessageLogger.java M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/main/java/org/xwiki/test/SecurityCachePerformanceTestScriptService.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-processing/xwiki-platform-image-processing-plugin/src/main/java/com/xpn/xwiki/plugin/image/ImagePlugin.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-processing/xwiki-platform-image-processing-plugin/src/main/java/com/xpn/xwiki/plugin/image/ImagePluginAPI.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/AbstractMailListener.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/MailConfigMandatoryDocumentInitializer.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/MemoryMailListener.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/factory/html/HTMLMimeBodyPartFactory.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/main/java/org/xwiki/observation/remote/internal/DefaultRemoteObservationManager.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/main/java/org/xwiki/observation/remote/internal/jgroups/JGroupsNetworkChannel.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/migration/R120901000XWIKI17761DataMigration.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/migration/SolrDocumentMigration120900000.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/script/RatingsScriptService.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-jersey/src/main/java/org/xwiki/rest/jersey/internal/ConsumedBodyRestoringRequestWrapper.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/ModelFactory.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/PreMatchingRequestFilter.java M xwiki-platform-core/xwiki-platform-scheduler/xwiki-platform-scheduler-api/src/main/java/com/xpn/xwiki/plugin/scheduler/SchedulerPlugin.java M xwiki-platform-core/xwiki-platform-scheduler/xwiki-platform-scheduler-api/src/main/java/com/xpn/xwiki/plugin/scheduler/internal/StatusListener.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractDocumentSkinExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/sx/CssExtension.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-migrations/src/main/java/org/xwiki/store/filesystem/internal/migration/R1100000XWIKI15620DataMigration.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/store/internal/FilesystemAttachmentStore.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/main/java/org/xwiki/url/script/URLSecurityScriptService.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-default/src/main/java/org/xwiki/url/internal/DefaultURLSecurityManager.java M xwiki-platform-core/xwiki-platform-websocket/src/main/java/org/xwiki/websocket/AbstractXWikiEndpoint.java M xwiki-platform-core/xwiki-platform-websocket/src/main/java/org/xwiki/websocket/internal/DefaultWebSocketContext.java M xwiki-platform-core/xwiki-platform-websocket/src/main/java/org/xwiki/websocket/internal/StaticEchoEndpoint.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-creationjob/src/main/java/org/xwiki/platform/wiki/creationjob/script/WikiCreationJobScriptServices.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-creationjob/src/test/java/org/xwiki/platform/wiki/creationjob/script/WikiCreationJobScriptServicesTest.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/main/java/org/xwiki/wiki/internal/descriptor/migrator/WikiDescriptorMigrator.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/main/java/org/xwiki/wiki/internal/descriptor/properties/DefaultWikiPropertyGroupManager.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/test/java/org/xwiki/wiki/internal/descriptor/migrator/WikiDescriptorMigratorTest.java Log Message: ----------- [Misc] Apply the logging best practices to 15 more platform modules Apply https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… to mail, ratings, rest, image, configuration, feed, flamingo, scheduler, skin, store, wiki, display, observation, websocket and url: bracket placeholder values, replace String concatenation and String.format() with {} placeholders, move the Throwable out of warn() in favour of ExceptionUtils.getRootCauseMessage(), use the root cause instead of e.getMessage(), and trim trailing whitespace from messages. Fixes found along the way: * MemoryMailListener, AbstractMailListener and MailConfigMandatoryDocumentInitializer logged nothing at all about the exception they had in scope; they now pass it in the SLF4J Throwable slot. * SchedulerPlugin logged "Failed to register" on the job-deleted branch, which calls unregister(). * FilesystemAttachmentStore misspelled "versionning". * StatusListener dropped its dangling colon: Quartz passes a null exception on success. SxDocumentSource and AbstractXWIKI14697DataMigration are left as they are: the former uses the compound-identifier form [{}#{}], the latter logs a List, which already brackets itself. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-batch2 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d0e725: [Misc] Apply the logging best practices to 8 more ...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: d0e725405f9aa9bb461823d25066f1a62678a195 https://github.com/xwiki/xwiki-platform/commit/d0e725405f9aa9bb461823d25066… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-io/src/main/java/org/xwiki/annotation/io/internal/migration/hibernate/R40001XWIKI7540DataMigration.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-io/src/main/java/org/xwiki/annotation/rights/internal/XWikiAnnotationRightService.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-api/src/main/java/org/xwiki/export/pdf/browser/AbstractBrowserPDFPrinter.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-api/src/test/java/org/xwiki/export/pdf/browser/BrowserPDFPrinterTest.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/chrome/ChromeManager.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/chrome/ChromeManagerManager.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/main/java/org/xwiki/like/script/LikeScriptService.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/script/LikeScriptServiceTest.java M xwiki-platform-core/xwiki-platform-mailsender/src/main/java/com/xpn/xwiki/plugin/mailsender/MailSenderPlugin.java M xwiki-platform-core/xwiki-platform-mailsender/src/main/java/com/xpn/xwiki/plugin/mailsender/MailSenderPluginApi.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer/src/main/java/org/xwiki/officeimporter/internal/filter/ImageFilter.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer/src/main/java/org/xwiki/officeimporter/internal/server/DefaultOfficeServer.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-viewer/src/main/java/org/xwiki/office/viewer/internal/DefaultOfficeResourceViewer.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-viewer/src/main/java/org/xwiki/office/viewer/script/DefaultOfficeViewerScriptService.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-viewer/src/test/java/org/xwiki/office/viewer/script/DefaultOfficeViewerScriptServiceTest.java M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-test/xwiki-platform-realtime-wysiwyg-test-docker/src/test/it/org/xwiki/realtime/wysiwyg/test/ui/RealtimeTestDebugger.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/ExtensionStore.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/RepositoryManager.java M xwiki-platform-core/xwiki-platform-tag/xwiki-platform-tag-api/src/main/java/com/xpn/xwiki/plugin/tag/TagPluginApi.java Log Message: ----------- [Misc] Apply the logging best practices to 8 more platform modules (#6062) * Batch 2 of the logging audit: xwiki-platform-repository, -export, -like, -office, -realtime, -mailsender, -annotation and -tag. * Wrapped bare {} placeholders in [], moved String concatenations and String.format() calls into placeholders, replaced e.getMessage() with ExceptionUtils.getRootCauseMessage(), and removed the Throwable from warn() calls (which is reserved for error()), appending the root cause message instead. * Also fixed the "anotations" typo in R40001XWIKI7540DataMigration. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0