September 2026 - notifications

[xwiki/xwiki-dev-llm] 759081: [Misc] Record the SonarCloud routine's prompt and ...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/sonarcloud-routine-prompt Home: https://github.com/xwiki/xwiki-dev-llm Commit: 759081684f869f8328460057ba8db2cdb4c3a697 https://github.com/xwiki/xwiki-dev-llm/commit/759081684f869f8328460057ba8db… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M README.md M xwiki/instructions/xwiki-org.md A xwiki/okf/architecture/platform-modules.md M xwiki/okf/index.md M xwiki/skills/xwiki-build/SKILL.md A xwiki/skills/xwiki-fix-sonarqube-issue/routine-prompt.md Log Message: ----------- [Misc] Record the SonarCloud routine's prompt and environment * Add skills/xwiki-fix-sonarqube-issue/routine-prompt.md, the record of the scheduled SonarCloud routine: the prompt verbatim, the variables it is given, the repos it has checked out, the setup script it runs, and the memory repo it reads and writes. The routine lives in a config box in the web UI that nobody else can read, review or restore, so a change to it was invisible and a lost routine unrebuildable; recorded here, a change to it is a pull request. Mirrors what xwiki-ci-check already carries * Record how the routine's pull requests are actually opened, that being the thing most easily got wrong by reasoning from a token's permissions: the Claude GitHub App installed on the org pushes the branch into the upstream repo itself, no fork and no personal access token are involved, and the bot identity is carried by the commit author. GH_TOKEN is the bot's, which the memory repo's own history shows * Point the prompt at the memory repo's new home: it was transferred on 2026-09-17 from vmassol/claude-routine-memory to xwikiorg-llm-bot/sonarcloud-routine-memory, so that the routine's memory belongs to the routine's identity rather than to a person. Both questions the move raised are answered and recorded: GH_TOKEN still pushes, more strongly than before since the bot now owns the repository outright, and the sonarqube/ prefix stays — flattening it would rewrite the paths inside learnings.md's own Rule index and every cross-reference under rules/, which is content churn in the one place whose whole value is that it accumulates. GitHub answers the old path with a redirect, so nothing was broken by the move; the reference is updated anyway, a redirect keeping code running while teaching every later reader the wrong owner * Move the XWiki knowledge out of the prompt and into the plugin, where every session gets it and where it is reviewed when it goes stale: add okf/architecture/platform-modules.md (the tools/core/distribution split, the modules worth knowing by name, the OSGi manifest each JAR carries and what xwiki.extension.features advertises) and a pnpm/Nx section to the xwiki-build skill, that being a build procedure rather than declarative knowledge. Two of the prompt's claims were in the OKF already and are simply dropped: never grow oldcore, and the event-listener model, both in component-system.md and the latter in more detail than the prompt had it * Rewrite the prompt around what is left: the three repositories named once at the top rather than one of them in the first sentence and two in a later bullet, the memory protocol as one block rather than a sentence and two overlapping bullets, dropped-issues.md named rather than "somewhere in the memory files", and "assign it to me" as "assign it to xwikiorg-llm-bot" — a routine has no "me" to resolve the pronoun against, and the work is the bot's, so the bot carries it rather than landing in a person's assigned list nightly. Record how to check an assignee while there: GitHub takes assignees only from the users a repository accepts and drops the rest without an error, so a mistyped name is a PR that is never assigned with nothing anywhere saying so — repos/{owner}/{repo}/assignees/{user} answers 204 or 404, and xwikiorg-llm-bot answers 204 on all three * Drop SONARQUBE_PROJECT_KEY from the routine's environment: it names one SonarCloud project and the routine sweeps three, so any value was wrong for two of them. Nothing depended on it, the MCP server declaring it optional and resolving the project per workspace; it stays in .mcp.json for the developer case of one checkout, one project Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-commons] 436b01: XCOMMONS-2092: Possible race condition in ReadWrit...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/XCOMMONS-2092 Home: https://github.com/xwiki/xwiki-commons Commit: 436b01d4797001e85faaec3192666367b2039c37 https://github.com/xwiki/xwiki-commons/commit/436b01d4797001e85faaec3192666… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/DefaultJobExecutorTest.java Log Message: ----------- XCOMMONS-2092: Possible race condition in ReadWriteSemaphore Follow-up to the review of the previous commit: restore every assertion it had removed from DefaultJobExecutorTest, and clear java:S5961 by fixing what actually inflated the count instead. * waitJobState() reported its timeout through fail(), and assertion-aware analysis resolves helper methods transitively, so every waitJobWaiting()/waitJobFinished() call counted as an assertion of the calling test. Each checkpoint of these tests was therefore counted twice: once for the barrier that drives the choreography to its next step, and once for the assertion that states what is expected there. That is what took matchingGroupPathAreBlockedPoolMultiSizeParentFirst to 28 for a method stating 18 expectations. * Raise that timeout by throwing instead. Assertions.fail() is itself a throw of an AssertionError subclass, so behaviour and Surefire reporting are unchanged, and the count now equals the number of expectations each test states: 28 -> 18, 29 -> 17 and 18 -> 12. The java:S5961 suppression added by the previous commit is dropped. * The same helper resolution applies to "tests should include assertions", where the effect is worse: a test whose only assertion-like call is a wait would have looked like it verifies something. It no longer does. * Restore the interrupt flag and keep the InterruptedException as the cause, instead of swallowing both. * Extract the repeated GroupedJobInitializer stubbing into mockPool(poolSize, path...) and mockAllPools(poolSize), so each test opens with the pool sizes its scenario comment describes. * Fix the last assertion of matchingGroupPathAreBlocked, which was on job1 twice instead of job12 and job1. * Fix two comments mangled by a search and replace ("taken into ABcount", "they are ABtually after"). Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform] 9042d3: XWIKI-22942: isSuperAdmin is implemented in many d...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/XWIKI-22942 Home: https://github.com/xwiki/xwiki-platform Commit: 9042d3481ee47d448eb3797943fc9a979b3918c8 https://github.com/xwiki/xwiki-platform/commit/9042d3481ee47d448eb3797943fc… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/security/XarSecurityTool.java M xwiki-platform-core/xwiki-platform-oldcore/pom.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/DefaultDocumentAccessBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/plugin/rightsmanager/UserIterator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/api/XWikiRightService.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/api/XWikiUser.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/AbstractXWikiAuthService.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/AppServerTrustedAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/AppServerTrustedKerberosAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImplTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/pom.xml M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/AuthorizationManager.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/AbstractAuthorizationTestCase.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/DefaultAuthorizationManagerTest.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-checker/src/main/java/org/xwiki/test/checker/internal/ProgrammingRightCheckerAuthorizationManager.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/pom.xml M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/main/java/org/xwiki/user/SuperAdminUserReference.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/SuperAdminUserReferenceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/AbstractUserPropertiesResolver.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/DefaultUserManager.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/document/AbstractDocumentStringUserReferenceResolver.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/document/AbstractUserReferenceResolver.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/document/CurrentUserManager.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/document/DocumentDocumentReferenceUserReferenceResolver.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/document/DocumentDocumentReferenceUserReferenceSerializer.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/document/DocumentStringUserReferenceSerializer.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/main/java/org/xwiki/user/internal/document/UserPreferencesConfigurationSource.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentDocumentReferenceUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-resource/src/main/java/org/xwiki/user/resource/internal/ConfiguredUserResourceReferenceSerializer.java Log Message: ----------- XWIKI-22942: isSuperAdmin is implemented in many different ways * Make SuperAdminUserReference the single source of truth for the Super Admin user: add SUPERADMIN_USER_NAME, SUPERADMIN_USER_SPACE, SUPERADMIN_LOCAL_REFERENCE, isSuperAdmin(UserReference), isSuperAdminReference(EntityReference) and isSuperAdminName(String) * Only recognize XWiki.superadmin as the Super Admin user, i.e. check the space on top of the name everywhere a reference is available, and resolve a user document named superadmin outside of the XWiki space as an ordinary user reference * Make AuthorizationManager, XWikiRightService, XWikiUser, UserIterator, DefaultDocumentAccessBridge, AbstractXWikiAuthService, XWikiRightServiceImpl and the user reference resolvers and serializers all rely on SuperAdminUserReference rather than on their own comparison * Add AuthorizationManager#isSuperAdmin(UserReference) * Deprecate XWikiRightService#isSuperAdmin(EntityReference) * Resolve the user reference in ProgrammingRightCheckerAuthorizationManager rather than comparing it to InternalTemplateManager#SUPERADMIN_REFERENCE * Keep the name only rule for the authentication services, which compare a name resolved with the default document reference resolver * Check the superadmin name against the user name XWikiAuthServiceImpl actually looks up, which is not parsed out of the entered string the same way as the name the existing check compares * Do not take the superadmin user name from the application server in the trusted authentication services Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24623: ExtensionIT#testDowngrade is flickering
by XWiki Notifications 17 Sep '26

17 Sep '26

1 0

[[email protected]][Issue] Updates for XWIKI-18223: ExtensionIT#testDowngrade is flickering on the 17.10.x branch
by XWiki Notifications 17 Sep '26

17 Sep '26

1 0

[xwiki/xwiki-rendering] 6973de: [Misc] Correct what author_association says about ...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-rendering Commit: 6973ded5fd4ff4ca539414a5f05512712e9b6e71 https://github.com/xwiki/xwiki-rendering/commit/6973ded5fd4ff4ca539414a5f05… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M .github/workflows/quality-pr-sonar.yml Log Message: ----------- [Misc] Correct what author_association says about a private organization membership * The guard of this workflow claimed that author_association covers a member whose organization membership is private. It does not: the value says what the one asking is allowed to see, and the payload a workflow is handed is computed for no one in particular, so only a membership its owner has made public reads as MEMBER there. A private member arrives as CONTRIBUTOR, the guard does not match, and their fork pull request falls to quality-pr.yml and its Checkstyle-only verdict. * Comment change only, no behaviour change. The canonical text lives in https://github.com/xwiki/.github Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-commons] 02597c: [Misc] Correct what author_association says about ...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-commons Commit: 02597c04d4f48f7b941d3ba42d40c3cafbddfcd0 https://github.com/xwiki/xwiki-commons/commit/02597c04d4f48f7b941d3ba42d40c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M .github/workflows/quality-pr-sonar.yml Log Message: ----------- [Misc] Correct what author_association says about a private organization membership * The guard of this workflow claimed that author_association covers a member whose organization membership is private. It does not: the value says what the one asking is allowed to see, and the payload a workflow is handed is computed for no one in particular, so only a membership its owner has made public reads as MEMBER there. A private member arrives as CONTRIBUTOR, the guard does not match, and their fork pull request falls to quality-pr.yml and its Checkstyle-only verdict. * Comment change only, no behaviour change. The canonical text lives in https://github.com/xwiki/.github Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform] 8e683e: [Misc] Correct what author_association says about ...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 8e683ef58529f068a091373472e1152b391461d6 https://github.com/xwiki/xwiki-platform/commit/8e683ef58529f068a091373472e1… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M .github/workflows/quality-pr-sonar.yml Log Message: ----------- [Misc] Correct what author_association says about a private organization membership * The guard of this workflow claimed that author_association covers a member whose organization membership is private. It does not: the value says what the one asking is allowed to see, and the payload a workflow is handed is computed for no one in particular, so only a membership its owner has made public reads as MEMBER there. A private member arrives as CONTRIBUTOR, the guard does not match, and their fork pull request falls to quality-pr.yml and its Checkstyle-only verdict. * Comment change only, no behaviour change. The canonical text lives in https://github.com/xwiki/.github Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/.github] ceb835: [Misc] Correct what author_association says about ...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/master Home: https://github.com/xwiki/.github Commit: ceb835eeeaaca50a59442ec24b7d84260c13ce9d https://github.com/xwiki/.github/commit/ceb835eeeaaca50a59442ec24b7d84260c1… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M README.md Log Message: ----------- [Misc] Correct what author_association says about a private organization membership * The guard of quality-pr-sonar.yml, and the README section describing it, both claimed that author_association covers a member whose organization membership is private. It does not: the value says what the one asking is allowed to see, and the payload a workflow is handed is computed for no one in particular, so only a membership its owner has made public reads as MEMBER there. A private member arrives as CONTRIBUTOR, the guard does not match, and their fork pull request falls to quality-pr.yml and its Checkstyle-only verdict -- which is what happened to every fork pull request but one since the workflow was added. * Say so in the three places that stated the opposite: the table of the three cases, the paragraph explaining the guard, and the guard's own comment in the stub. Name the remedy, each member setting their own membership to public, since nothing in these workflows can do it for them. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/.github/settings/notifications

1 0

[xwiki/xwiki-dev-llm] 6564f5: [Misc] Require backticking @ tokens in commit and ...
by XWiki Notifications 17 Sep '26

17 Sep '26

Branch: refs/heads/commit-message-at-escaping Home: https://github.com/xwiki/xwiki-dev-llm Commit: 6564f552c199aa77dcdd586c910c83b7735b5e44 https://github.com/xwiki/xwiki-dev-llm/commit/6564f552c199aa77dcdd586c910c8… Author: Thomas Mortagne <thomas.mortagne(a)gmail.com> Date: 2026-09-17 (Thu, 17 Sep 2026) Changed paths: M scripts/validate.mjs M xwiki/instructions/xwiki-org.md M xwiki/okf/conventions/commit-messages.md M xwiki/skills/xwiki-pull-request/SKILL.md Log Message: ----------- [Misc] Require backticking @ tokens in commit and pull request text * GitHub renders a bare @since in a commit message as a mention of that account, linking and notifying an unrelated third party, and a pushed commit message cannot be corrected without rewriting a shared branch * Add the rule to the commit-message convention, to the xwiki-pull-request skill, and to the always-on instructions, the only surface present when a commit message is composed * Raise the always-on byte budget from 8000 to 8192 to fit that line Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0