- notifications - lists.xwiki.org

[xwiki/xwiki-dev-llm] fd0af2: [Misc] Record the LandingPageClass xobject and the...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: fd0af24e73d2573b151c30d94f05821fbd46c921 https://github.com/xwiki/xwiki-dev-llm/commit/fd0af24e73d2573b151c30d94f058… Author: elenicojocariu <cojocariu.eleni24(a)gmail.com> Date: 2026-08-08 (Sat, 08 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/instructions/xwiki-org.md M xwiki/okf/conventions/documentation-mechanics.md M xwiki/okf/index.md Log Message: ----------- [Misc] Record the LandingPageClass xobject and the DocumentationClass sweep trap * Landing pages on xwiki.org carry DocApp.Code.LandingPageClass instead of DocumentationClass, and no DocumentationExtensionClass. Both kinds named by the DocGuide's Create Landing Pages use it: the target landing pages (documentation.xs.user / .admin / .dev) and the Diataxis type landing pages nested under each. The class was absent from the documentation-mechanics xobject table, which listed only the three DocumentationClass-family ones. * On a type landing page, type and target are the filter its table applies rather than a classification of the page itself — it lists every page of that type for that audience across documentation.xs, so it normally has no child pages of its own. * Record the audit trap this sets: a sweep selecting pages by DocumentationClass silently skips every landing page, and landing pages carry the tree's most visible Highlights. Auditing the Highlights of documentation.xs.user that way reports "nothing to fix" while missing the one page that needed it — the Explanations landing page, which lists 51 pages and had no Highlights at all. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> Commit: 6cba781ba94d1b99b4b0f1861da8fa37ad3d66f4 https://github.com/xwiki/xwiki-dev-llm/commit/6cba781ba94d1b99b4b0f1861da8f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki/instructions/xwiki-org.md M xwiki/okf/conventions/documentation-mechanics.md M xwiki/okf/index.md Log Message: ----------- [Misc] Record the LandingPageClass xobject and the DocumentationClass sweep trapa Compare: https://github.com/xwiki/xwiki-dev-llm/compare/904b9d67c2c9...6cba781ba94d To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-dev-llm] bd8d4f: [Misc] Correct the S3457 toString() guidance and p...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/claude/cool-tesla-jwqn4a Home: https://github.com/xwiki/xwiki-dev-llm Commit: bd8d4ff98b0f9b01ee81819ad8ac3230bb4660e5 https://github.com/xwiki/xwiki-dev-llm/commit/bd8d4ff98b0f9b01ee81819ad8ac3… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/simplification-rules.md Log Message: ----------- [Misc] Correct the S3457 toString() guidance and point it at the logging convention The first version of this PR said the "No need to call toString()" shape was a free deletion. That is wrong for a logging call and contradicts conventions/logging.md: Message.formattedMessage is transient, so a captured LogEvent keeps the raw Object[] and the job-status log XStream-serializes each argument, meaning an explicit toString() is often load-bearing. Document String.valueOf(x) as the form that clears the rule while keeping the eager snapshot, and cross-reference logging.md. Also add a universal drop condition for the more general trap behind it: a rationale is not always a comment, sometimes it is a commit message, so check the flagged line's own history before "fixing" a shape a recent JIRA-numbered commit introduced on purpose. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-commons]
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/claude/nifty-bell-jwqn4a Home: https://github.com/xwiki/xwiki-commons To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-commons] a0adda: [Misc] Fix mechanical SonarQube issues in several ...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-commons Commit: a0adda2dd5b5e7265b0ada953d3cd8f175d0aa2d https://github.com/xwiki/xwiki-commons/commit/a0adda2dd5b5e7265b0ada953d3cd… Author: claude[bot] <209825114+claude[bot](a)users.noreply.github.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/RepositoryUtils.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-test/src/main/java/org/xwiki/filter/test/integration/junit5/InternalFilterTest.java M xwiki-commons-core/xwiki-commons-legacy/xwiki-commons-legacy-classloader/xwiki-commons-legacy-classloader-api/src/main/java/org/xwiki/classloader/internal/ResourceLoader.java M xwiki-commons-core/xwiki-commons-velocity/src/main/java/org/xwiki/velocity/tools/URLTool.java Log Message: ----------- [Misc] Fix mechanical SonarQube issues in several modules (#1894) * [Misc] Fix mechanical SonarQube issues in several modules * java:S3824: replace Map.get()/containsKey() followed by a conditional put with Map.computeIfAbsent() * java:S3457: drop a redundant toString() on a parameterized log argument Co-Authored-By: Vincent Massol <vincent(a)massol.net> * [Misc] Keep the eager String for the RepositoryUtils search log * The java:S3457 fix on RepositoryUtils reverted the hunk XWIKI-24665 (#1884) had just applied. RepositoryUtils.search runs on extension job threads, where AbstractJobStatus captures the LogEvent with its raw Object[] and SafeMessageConverter XStream-serializes it into the job log, so the eager String is deliberate. * Use String.valueOf(...) instead: it clears java:S3457 (no toString() call) while keeping the snapshot, as done in DefaultJobProgress by #1872. No java:S2629 suppression is needed here since the call sits in a catch block, which that rule skips. Co-Authored-By: Vincent Massol <vincent(a)massol.net> --------- Co-authored-by: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-commons] 816355: [Misc] Keep the eager String for the RepositoryUti...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/claude/nifty-bell-jwqn4a Home: https://github.com/xwiki/xwiki-commons Commit: 816355e66056efce4e72eb204a7b34aa6d962ea5 https://github.com/xwiki/xwiki-commons/commit/816355e66056efce4e72eb204a7b3… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/RepositoryUtils.java Log Message: ----------- [Misc] Keep the eager String for the RepositoryUtils search log * The java:S3457 fix on RepositoryUtils reverted the hunk XWIKI-24665 (#1884) had just applied. RepositoryUtils.search runs on extension job threads, where AbstractJobStatus captures the LogEvent with its raw Object[] and SafeMessageConverter XStream-serializes it into the job log, so the eager String is deliberate. * Use String.valueOf(...) instead: it clears java:S3457 (no toString() call) while keeping the snapshot, as done in DefaultJobProgress by #1872. No java:S2629 suppression is needed here since the call sits in a catch block, which that rule skips. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-dev-llm]
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/claude/cool-tesla-je8lo7 Home: https://github.com/xwiki/xwiki-dev-llm To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-dev-llm] ca26e1: Document S2629 and S3358, and widen the S1130 safe...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: ca26e115d0c5c28ac63ac1522e659fe23a2d152d https://github.com/xwiki/xwiki-dev-llm/commit/ca26e115d0c5c28ac63ac1522e659… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-08 (Sat, 08 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/okf/sonarqube/dead-code-rules.md M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/simplification-rules.md Log Message: ----------- Document S2629 and S3358, and widen the S1130 safe set to private helpers * S1130: a private helper in a test class cannot be overridden by a test-jar consumer, so it is as safe as an annotated test method. Also add the XWiki test-framework hooks (@BeforeComponent) to the safe annotation set. * S2629: the only mechanical shape is a redundant toString() on an argument of an already-parameterized SLF4J call; everything else needs an isXxxEnabled() guard, which is a judgement call. * S3358: extract the inner ternary; exact-negation branches collapse to one local plus a unary minus. Ship it separately, it is a readability judgement. * Denylist javabugs:S2259, S899/S4042, S1948 and S2386, with the reason each looks mechanical but is not. Co-Authored-By: Vincent Massol <vincent(a)massol.net> Commit: e3243c3ed428f0347b99be8e79b56b6c38197f87 https://github.com/xwiki/xwiki-dev-llm/commit/e3243c3ed428f0347b99be8e79b56… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/simplification-rules.md M xwiki/skills/xwiki-fix-sonarqube-issue/SKILL.md Log Message: ----------- Deny S2629 and route it to conventions/logging.md instead The S2629 section added in the previous commit was wrong: it advised deleting a redundant toString() from a parameterized log call, which contradicts conventions/logging.md ("Never silently remove an explicit toString()"). In XWiki a log argument is stored as an object and XStream-serialized into the job log, so the eager String is usually a deliberate snapshot. * Move S2629 out of the simplification family and into the index denylist, with a pointer to conventions/logging.md. * Tell the skill that a convention-owned rule's knowledge lives in okf/conventions/, not okf/sonarqube/, so the pointer gets followed. Co-Authored-By: Vincent Massol <vincent(a)massol.net> Commit: 904b9d67c2c99333fbab6ae0a871585971a10ef7 https://github.com/xwiki/xwiki-dev-llm/commit/904b9d67c2c99333fbab6ae0a8715… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/okf/sonarqube/dead-code-rules.md M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/simplification-rules.md M xwiki/skills/xwiki-fix-sonarqube-issue/SKILL.md Log Message: ----------- [Misc] Document S2629 and S3358, and widen the S1130 safe set to private helpers Compare: https://github.com/xwiki/xwiki-dev-llm/compare/99d9fa1393e2...904b9d67c2c9 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-commons]
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/claude/nifty-bell-7ki1p0 Home: https://github.com/xwiki/xwiki-commons To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-commons] 18a0de: [Misc] Rename local variables not matching the nam...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-commons Commit: 18a0de0396258eac3602aa003ad4d125fda924a6 https://github.com/xwiki/xwiki-commons/commit/18a0de0396258eac3602aa003ad4d… Author: claude[bot] <209825114+claude[bot](a)users.noreply.github.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/job/internal/InstallJobTest.java Log Message: ----------- [Misc] Rename local variables not matching the naming convention (SonarQube) (#1892) * Fix 2 java:S117 issues in InstallJobTest: two locals were named as if they were constants. Co-authored-by: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-commons]
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/claude/nifty-bell-je8lo7-s3358 Home: https://github.com/xwiki/xwiki-commons To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0