Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: ed10820f925314e51b19b7cd98af2a894349b1c4 https://github.com/xwiki/xwiki-platform/commit/ed10820f925314e51b19b7cd98af2... Author: Vincent Massol <[email protected]> Date: 2026-09-01 (Tue, 01 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-lightbox/xwiki-platform-image-lightbox-test/xwiki-platform-image-lightbox-test-docker/src/test/it/org/xwiki/image/lightbox/test/ui/LightboxIT.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-lightbox/xwiki-platform-image-lightbox-test/xwiki-platform-image-lightbox-test-pageobjects/src/main/java/org/xwiki/image/lightbox/test/po/LightboxPage.java Log Message: ----------- XWIKI-21734: LightboxIT.disabledLightbox is flickering (#6278) * The test failed because the popover did appear: the page had been rendered with the lightbox enabled although the test had just set isLightboxEnabled to 0. It is the first test of the class and it runs shortly after the test extensions, which ship the configuration document, have been provisioned, so a copy of that document read while the save was running can outlive it in the document cache and keep the previous value in effect for the whole test. * Make enableLightbox() verify that the new value is the one page renders see, on the page the save action already lands on, and save again when it is not, since saving the document again is what drops the stale copy. Fail with an explicit message rather than let a later assertion report a misleading symptom. * Add LightboxPage.isLightboxEnabled(), which tells whether the displayed page was rendered with the lightbox, from the configuration script the UI extension only emits when it is enabled. * Assert that precondition in disabledLightbox: not finding a popover only means the lightbox is disabled if the page was rendered without it. Co-authored-by: Vincent Massol <[email protected]> Co-authored-by: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications