Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 12036c6b56afce78c8fe14aceedf4316dbdac7d2 https://github.com/xwiki/xwiki-platform/commit/12036c6b56afce78c8fe14aceedf4... Author: Michael Hamann <[email protected]> Date: 2026-09-14 (Mon, 14 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/AbstractTest.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/LoginPage.java M xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-storage/src/test/it/org/xwiki/test/storage/framework/StoreTestUtils.java Log Message: ----------- XCOMMONS-3481: Stop using http client 3 in the build * don't follow the redirects in the storage functional tests, as HttpClient 3 didn't for POST requests. They assert on the status code of the response and on the state of the wiki afterwards, and following the redirect of the save action rendered the saved page, whose content is a script that modifies the wiki: the attachment ended up with 2 versions instead of 1. * make LoginPage synchronize the credentials used for REST calls with the user the browser was logged in as, which TestUtils#loginAndGotoPage() already does but the page object didn't, so a test logging in through it kept performing its REST calls as the superadmin TestUtils defaults to. The credentials are only synchronized once the displayed page confirms the login succeeded, so that the tests logging in with wrong credentials on purpose are unaffected. * introduce TestUtils#setPrivilegedCredentials() to declare which user the test framework authenticates as when it needs full rights, and make the functional tests of the flavor use Admin: they run against the distribution as it is shipped, which leaves xwiki.superadminpassword commented out and thus has no superadmin. This used to go unnoticed because the HTTP client kept its cookies across credential switches, so a session opened as Admin authenticated the following superadmin requests, which now get a 401. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 3e8e8ece4f9c4c22d9e6959a4918c5cc61daa7d5 https://github.com/xwiki/xwiki-platform/commit/3e8e8ece4f9c4c22d9e6959a4918c... Author: Michael Hamann <[email protected]> Date: 2026-09-14 (Mon, 14 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CompareIT.java Log Message: ----------- XWIKI-24639: In a docker test allow easily switch from browser or http client as default access * make CompareIT#compareRenderedImageChanges() use the HTTP client as the wiki descriptor target. It references the images to compare by the URL through which the HTTP client accesses XWiki, and the rendered diff only downloads an image whose domain is trusted, which the domain of the wiki descriptor is. Since the descriptor now targets the browser, the images were no longer downloaded and the diff compared their URLs, which differ on purpose. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Compare: https://github.com/xwiki/xwiki-platform/compare/d432e8115654...3e8e8ece4f9c To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications