Branch: refs/heads/master Home: https://github.com/xwiki-contrib/application-releasenotes Commit: a9d6e417b3c2c504da1f21a8a7a5baed02cfa38b https://github.com/xwiki-contrib/application-releasenotes/commit/a9d6e417b3c... Author: Vincent Massol <[email protected]> Date: 2026-09-06 (Sun, 06 Sep 2026) Changed paths: M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ApplicationsPanelEntry.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerFlow.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerGrid.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerList.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerSimple.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/GetChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HTML5Video.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNoteClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfig.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfigClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Report.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebHome.xml A application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebPreferences.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/RequiredRightsTest.java Log Message: ----------- RN-111: The application pages do not declare the rights they require * Declare and enforce required rights on 29 of the application's pages, at the level XWiki's own required-rights analyzer computes for each of them: script on the 21 script-bearing pages, wiki_admin on Code.ApplicationsPanelEntry for its wiki-scoped UI extension and on Code.Translations for its wiki-scoped translation bundle, and nothing at all on the 6 pages that need nothing, which is the setting that stops a later editor from introducing script into them. Code.MigrationFrom1x already enforced wiki_admin and keeps it. * Add ReleaseNotes.Code.WebPreferences, restricting edit and delete on the code space to XWiki.XWikiAdminGroup. Nested spaces inherit it, so it covers ReleaseNotes.Code.Change too. view is deliberately absent: an allow rule is exclusive, so listing it would deny view to everyone outside the group. * Leave ReleaseNotes.WebHome, ReleaseNotes.Data.WebHome, Code.HomeReleaseNotes and Code.ReleaseNoteTemplate not enforcing. Enforcement caps the rights of whatever a page includes and is forced onto every document an enforcing page's script saves, so enforcing the release note creation chain either breaks the Velocity the template copies onto a new release note or makes script right a condition of editing one, against RN-30. RN-112 covers taking the Velocity out of the template so that these four can enforce as well. * Add RequiredRightsTest, asserting the expected level page by page so that adding a page to the application forces a decision about what it requires, and asserting the code space's rights object. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 5ba0b49faa18549c0fc167c8e8ceb38e6c5589a6 https://github.com/xwiki-contrib/application-releasenotes/commit/5ba0b49faa1... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ApplicationsPanelEntry.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerFlow.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerGrid.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerList.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerSimple.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/GetChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HTML5Video.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/MigrationFrom1x.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNoteClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfig.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfigClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Report.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebPreferences.xml M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/RequiredRightsTest.java Log Message: ----------- RN-111: The application pages do not declare the rights they require * Raise the five XWiki.WikiMacroClass pages from script to wiki_admin. DefaultWikiMacroFactory.isAllowed checks Right.ADMIN at EntityType.WIKI against the macro document's author for a macro whose visibility is Current Wiki, so capping the author at script left all five macros unregistered and every page using one rendered "Unknown macro". The required-rights analyzer reports script here because no analyzer reads WikiMacroClass visibility, unlike the UI extension and translation bundle ones, so the declared level departs from it on purpose and RequiredRightsTest carries the reason. * Declare the XAR document-model version as 1.6 on the pages carrying enforceRequiredRights, the version that introduced the element. * Read the rights back through DocumentRequiredRightsManager in RequiredRightsTest, as a PageTest, so the assertion is about what the platform enforces rather than about the XML that carries it. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: f7a31d09557c32f36a7b176b6b0ec97945f9a006 https://github.com/xwiki-contrib/application-releasenotes/commit/f7a31d09557... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/RequiredRightsTest.java Log Message: ----------- RN-111: The application pages do not declare the rights they require * Drop the @ComponentList from RequiredRightsTest. MockitoOldcore already mocks DocumentRequiredRightsManager with a stub delegating to the real DocumentRequiredRightsReader, which PageComponentList already provides, so the page test needs no component declaration at all. Naming DefaultDocumentRequiredRightsManager was what replaced that mock with the real implementation and made SimpleDocumentCache missing, so the other two entries were bought to undo the first. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 3899db17fb575b5b3639a3c4653f5c0949edf0ad https://github.com/xwiki-contrib/application-releasenotes/commit/3899db17fb5... Author: Vincent Massol <[email protected]> Date: 2026-09-07 (Mon, 07 Sep 2026) Changed paths: M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ApplicationsPanelEntry.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerFlow.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerGrid.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerList.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerSimple.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/GetChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ContributorsTemplate.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/EntryVelocityMacros.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HTML5Video.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/MigrationFrom1x.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNoteClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfig.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesConfigClass.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Report.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebHome.xml A application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/WebPreferences.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/RequiredRightsTest.java Log Message: ----------- Merge pull request #51 from xwiki-contrib/RN-111 RN-111: The application pages do not declare the rights they require Compare: https://github.com/xwiki-contrib/application-releasenotes/compare/5f0a5aa5c6... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...