Branch: refs/heads/perf/hoist-comment-right-check Home: https://github.com/xwiki-contrib/application-changerequest Commit: cf75aa8e9bb9292e20387cb7f4238702578c06da https://github.com/xwiki-contrib/application-changerequest/commit/cf75aa8e9b... Author: Simon Urli <[email protected]> Date: 2026-09-14 (Mon, 14 Sep 2026) Changed paths: M application-changerequest-ui/src/main/resources/ChangeRequest/Code/ChangeRequestDiscussion.xml M application-changerequest-ui/src/main/resources/ChangeRequest/Code/ChangeRequestMacros.xml M application-changerequest-ui/src/main/resources/ChangeRequest/Code/ChangeRequestSheet.xml Log Message: ----------- [Misc] Avoid recomputing the comment right for every displayed message * Pass the already computed right as a parameter of the displayMessage macro instead of asking the authorization script service again for each message of each discussion. * Reuse the same value for the JSX configuration and for the comment button of the description tab. isAuthorizedToComment ends up in ChangeRequestApproversManager#isApprover which, when the change request carries no explicit approver, iterates over every modified document and resolves the approver groups. Calling it once per message made the cost of the discussions block grow with the number of messages multiplied by the number of modified documents. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-changerequest/settings/notifica...