Branch: refs/heads/misc-logging-best-practices Home: https://github.com/xwiki/xwiki-platform Commit: ffe6e5ff15c0c2950a2ad4e6f2608b164a8ddefe https://github.com/xwiki/xwiki-platform/commit/ffe6e5ff15c0c2950a2ad4e6f2608... Author: Vincent Massol <[email protected]> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/bridge/WikiObjectComponentManagerEventListenerProxy.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/main/java/org/xwiki/eventstream/internal/AbstractAsynchronousEventStore.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-index/src/main/java/org/xwiki/extension/index/internal/DefaultExtensionIndex.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/store/internal/LegacyEventLoader.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/AbstractDocumentNotificationPreferenceProvider.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/WikiNotificationPreferenceProvider.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/DefaultMandatoryDocumentInitializerManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/XWikiRepositoryModel.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/main/java/org/xwiki/sheet/internal/DefaultSheetManager.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-rest/src/main/java/org/xwiki/test/extension/RestExtensionInstaller.java Log Message: ----------- [Misc] Fix broken SLF4J log messages Several log statements never printed the values they promised: * A corrupted placeholder ("[ΒΆ}]" instead of "[{}]") in XWikiRightServiceImpl. * "%s" / "{0}" placeholders, which SLF4J does not substitute, in LegacyEventLoader and WikiObjectComponentManagerEventListenerProxy. * Placeholders with no matching argument in AbstractDocumentNotificationPreferenceProvider and WikiNotificationPreferenceProvider, so the offending target was never shown. * Arguments with no matching placeholder, silently dropped by SLF4J, in AbstractAsynchronousEventStore, DefaultMandatoryDocumentInitializerManager, XWikiRepositoryModel and RestExtensionInstaller. Also fixes "existance" -> "existence" in DefaultExtensionIndex and DefaultSheetManager. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Commit: 032f96f947ebfd2f166d69fc8a01c77953c92ad3 https://github.com/xwiki/xwiki-platform/commit/032f96f947ebfd2f166d69fc8a01c... Author: Vincent Massol <[email protected]> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-mailsender/src/main/java/com/xpn/xwiki/plugin/mailsender/MailSenderPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/input/XWikiAttachmentEventGenerator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/output/PropertyClassOutputFilterStream.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/skin/AbstractResourceSkin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/hibernate/HibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/InternalTemplateManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorData.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/PdfExportImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutor.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/AbstractDataMigrationManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/AbstractResizeMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R140600000XWIKI19869DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R40000XWIKI6990DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyPersistentLoginManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/RegisterAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SkinAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiServletURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/filter/Importer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/velocity/XWikiVelocityManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/store/hibernate/internal/MySQLHibernateAdapter.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-oldcore Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLog... * Replace string concatenation and String.format() in log messages with the parameterized SLF4J signatures, which also removes the now-redundant isDebugEnabled()/isErrorEnabled() guards. * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. * Pass the Throwable to error() where it was previously only logged at debug level, and replace two e.printStackTrace() calls in MonitorPlugin. Along the way this fixes a few log statements that were wrong rather than just badly formatted: * Package.readFromZip() promised a "[{}]" document reference but passed no argument for it, so the failing entry was never identified. * MonitorPlugin reported "endRequest"/"startRequest" from startRequest(), startTimer() and endTimer() due to copy-paste. * MyPersistentLoginManager included the username or password being encrypted/decrypted in its error messages; those values no longer reach the logs. * Typos: "idenfier" -> "identifier", "handler revision" -> "handle revision", "emptry" -> "empty", "produce" -> "produces", "occured" -> "occurred", "decypting" -> "decrypting". Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Compare: https://github.com/xwiki/xwiki-platform/compare/ffe6e5ff15c0%5E...032f96f947... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications