Branch: refs/heads/manuelleduc/xwiki-25234-submitting-the-macro-dialog-with-an Home: https://github.com/xwiki/xwiki-platform Commit: d250ce195e1195037f9852ba5fe7e82df3bdd689 https://github.com/xwiki/xwiki-platform/commit/d250ce195e1195037f9852ba5fe7e... Author: Manuel Leduc <[email protected]> Date: 2026-10-13 (Tue, 13 Oct 2026) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-test/xwiki-platform-ckeditor-test-docker/src/test/it/org/xwiki/ckeditor/test/ui/MacroIT.java M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/variablelist.vm M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/SuggestInputElement.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.css M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-test/xwiki-platform-wysiwyg-test-pageobjects/src/main/java/org/xwiki/wysiwyg/test/po/MacroDialogEditModal.java Log Message: ----------- XWIKI-25234: Submitting the macro dialog with an empty required parameter displayed with a suggest picker gives no visible feedback * Forward the focus from the form field enhanced by Tom Select to the Tom Select control, since that field is only hidden visually and stays focusable. This covers any code focusing the field (macro dialog, Live Data cell edition, in-place property edition), including when the field is focused before being enhanced. * Apply the Bootstrap validation states (has-success, has-warning, has-error) to the Tom Select control, which is not a .form-control. * Expose the state-success-text and state-warning-text Bootstrap variables as CSS variables, as already done for state-danger-text. * Check in MacroIT that submitting the macro dialog without its required reference gives the focus to the reference picker, with a way to click the submit button of the dialog without waiting for a submission result, and a way to know if a suggest input has the focus. Co-Authored-By: Claude Opus 5.5 <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications