Branch: refs/heads/misc-logging-rendering Home: https://github.com/xwiki/xwiki-rendering Commit: 6db8fdadca3ce680e09dff7e939eea508934d10c https://github.com/xwiki/xwiki-rendering/commit/6db8fdadca3ce680e09dff7e939e... Author: Vincent Massol <[email protected]> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M xwiki-rendering-transformations/xwiki-rendering-transformation-linkchecker/src/main/java/org/xwiki/rendering/internal/transformation/linkchecker/DefaultLinkCheckerThread.java M xwiki-rendering-transformations/xwiki-rendering-transformation-linkchecker/src/test/java/org/xwiki/rendering/internal/transformation/linkchecker/LinkCheckerThreadTest.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/main/java/org/xwiki/rendering/internal/macro/DefaultMacroManager.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/test/java/org/xwiki/rendering/internal/macro/DefaultMacroManagerTest.java Log Message: ----------- [Misc] Apply the logging best practices: don't drop the caught exception in a warn() First pass of the xwiki-platform logging audit over xwiki-rendering. Two warn() calls inside a catch never mentioned the exception they were holding, so the reason the operation failed reached no log at all. warn() must not print a stack trace, so the cause goes into a placeholder as ExceptionUtils.getRootCauseMessage(e). Everything else the audit's detector reports in this repo is a non-violation and is recorded in the PR description: the four isDebugEnabled() guards in BlockStateChainingListener (they also skip a `new IllegalStateException()`, which captures a stack trace, so removing them would pay that on every event) and JspWikiSerializer's System.out (an output sink, not logging). Also fixes "continnue" in the comment right above the link-checker change. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications