Branch: refs/heads/XWIKI-22931 Home: https://github.com/xwiki/xwiki-platform Commit: 174d554f1a727a79392cf208cc65eef2ddfbde09 https://github.com/xwiki/xwiki-platform/commit/174d554f1a727a79392cf208cc65e... Author: Simon Urli <[email protected]> Date: 2025-12-18 (Thu, 18 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Fix XWikiDocument#copyAttachment to actually perform a real clone including the copy of the content * Introduce a XWikiAttachment#cloneWithActualContent to clone and copy the content * Introduce a XWikiAttachmentContent#clone(boolean) that allows to decide to skip or not copying the content WIP: right now tests are passing but it shows a regression in logs when running PageTemplatesIT, probably due to the ownerDocument of XWikiAttachmnentContent in clone method Commit: 8cd0370e574f6d0d4526a7d9c5efc76564897d58 https://github.com/xwiki/xwiki-platform/commit/8cd0370e574f6d0d4526a7d9c5efc... Author: Simon Urli <[email protected]> Date: 2025-12-18 (Thu, 18 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/test/java/org/xwiki/store/legacy/store/internal/FilesystemAttachmentVersioningStoreTest.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Get rid of ownerDocument in XWikiAttachmentContent * Properly override new clone method in extended classes * Set the attachment document in XWikiDocument#setAttachment WIP: this still shows a regression in PageTemplatesIT with a stacktrace about a missing attachment. Commit: 3239a82c5071c4eabdc440843895db934d48267f https://github.com/xwiki/xwiki-platform/commit/3239a82c5071c4eabdc440843895d... Author: Simon Urli <[email protected]> Date: 2025-12-18 (Thu, 18 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Small improvments but still having bad stack trace when trying to create page from template related to Solr Compare: https://github.com/xwiki/xwiki-platform/compare/ea737b7fb186...3239a82c5071 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications