Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 4916d7104c5a7e85e50857a86733221929fc7adc https://github.com/xwiki/xwiki-platform/commit/4916d7104c5a7e85e50857a867332... Author: Manuel Leduc <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Administration.xml M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Translations.xml Log Message: ----------- XWIKI-24786: A failed identifier validation leaves the image style creation form unusable * Fall back to the entered name when the entity name validation request fails or returns an unexpected result, so that the creation button gets enabled instead of staying disabled forever with no way for the user to recover * Give that request a timeout, so that a validation page which never answers is handled the same way instead of blocking the form indefinitely * Tell the user, with the new newImageStyle.validationFailed translation, that the name could not be checked and will be used as entered, instead of reporting a normalization that did not happen * Skip the request altogether for an empty name, which has nothing to check * Report the validation error with console.error instead of console.log Commit: 040a889bd62a4a55f0529f0044c64e2d54dbc51b https://github.com/xwiki/xwiki-platform/commit/040a889bd62a4a55f0529f0044c64... Author: Manuel Leduc <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Administration.xml M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/test/java/org/xwiki/image/style/AdministrationPageTest.java Log Message: ----------- XWIKI-24787: The normalized identifier is never displayed in the image style administration * Remove the trailing space in the id of the hint holding the normalized identifier, so that the selector used to fill it in matches it and the hint is actually displayed * Assert, in the page test of the administration, that the hint holding the normalized identifier can be found through the identifier the script uses to fill it in Commit: 18dfce1b09383ee0f5141323d60b6fad71fe1bb5 https://github.com/xwiki/xwiki-platform/commit/18dfce1b09383ee0f5141323d60b6... Author: Manuel Leduc <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Administration.xml M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/test/java/org/xwiki/image/style/AdministrationPageTest.java Log Message: ----------- XWIKI-24788: The 'New Image Style' field hint repeats the field label * Use the newImageStyle.hint translation key, which describes the field, for the hint of the new image style identifier field, instead of the newImageStyle.label key already used for its label * Assert, in the page test of the administration, that the label and the hint of the identifier field render two different translation keys Commit: d657b2589a5d26a40408d706ac7f53d60c8c3def https://github.com/xwiki/xwiki-platform/commit/d657b2589a5d26a40408d706ac7f5... Author: Manuel Leduc <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Administration.xml Log Message: ----------- [Misc] Replace var with const and let in the image style administration script Commit: 471f7f46ab45acb6477351e5f67e57999ef1843b https://github.com/xwiki/xwiki-platform/commit/471f7f46ab45acb6477351e5f67e5... Author: Manuel Leduc <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Administration.xml M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Translations.xml Log Message: ----------- XWIKI-24789: The image style administration does not report an identifier that breaks the naming conventions * Report, with the new newImageStyle.invalidIdentifier translation, that the entered identifier does not follow the naming conventions and is being rewritten, instead of presenting the rewritten identifier as if nothing was wrong * Base that on the isOriginalValid and useValidation values already returned by the entity name validation page, which were both ignored Commit: 7d1186a218d466ccf12f7c04bc15857736d0df25 https://github.com/xwiki/xwiki-platform/commit/7d1186a218d466ccf12f7c04bc158... Author: Manuel Leduc <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Administration.xml M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Translations.xml Log Message: ----------- XWIKI-24790: An expired CSRF token is reported as a naming convention problem in the image style administration * Report, with the new newImageStyle.tokenExpired translation, that the page has to be reloaded when the entity name validation page answers 401 because the CSRF token is no longer valid, instead of blaming the naming conventions * Keep the creation button disabled in that case, since the creation itself would be rejected for the same reason Commit: 2b7daa877ece53d85568a385e2ae761997ff207d https://github.com/xwiki/xwiki-platform/commit/2b7daa877ece53d85568a385e2ae7... Author: Manuel Leduc <[email protected]> Date: 2026-09-03 (Thu, 03 Sep 2026) Changed paths: M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/main/resources/Image/Style/Code/Administration.xml M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-style/xwiki-platform-image-style-ui/src/test/java/org/xwiki/image/style/AdministrationPageTest.java Log Message: ----------- XWIKI-24781: In-place editing of the Image Styles administration properties is broken by undefined $xobject and $xclass variables * Remove the data-property and data-property-type attributes of the two default style property elements, which were serialized from the never defined $xobject variable and were therefore emitted as a literal Velocity string in the administration markup * Remove the class="editableProperty" markers of these two elements, so that the section stops advertising an in-place editing that cannot work: the property is stored on Image.Style.Code.Configuration while editableProperty.js requests the current document, which is XWiki.XWikiPreferences in the administration * Remove the $propertyId #set computed from the never defined $xclass and $xobject variables, which was not used anywhere * Describe, in the remaining comment, the label 'for' attribute that has to match the identifier generated by the display call below, which is what the comment was about * Assert, in the page test of the administration, that the two property elements carry no in-place editing markup and that each of their labels references the field displayed right below it Compare: https://github.com/xwiki/xwiki-platform/compare/8a30d50d3eae...2b7daa877ece To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications