Branch: refs/heads/misc-logging-best-practices Home: https://github.com/xwiki/xwiki-commons Commit: 869070ab4092423c0e437bdb7c79065a0e735b5b https://github.com/xwiki/xwiki-commons/commit/869070ab4092423c0e437bdb7c7906... Author: Vincent Massol <[email protected]> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-classloader/xwiki-commons-classloader-api/src/main/java/org/xwiki/classloader/internal/JarExtendedURLStreamHandler.java M xwiki-commons-core/xwiki-commons-diff/xwiki-commons-diff-api/src/main/java/org/xwiki/diff/internal/DefaultDiffManager.java M xwiki-commons-core/xwiki-commons-environment/xwiki-commons-environment-common/src/main/java/org/xwiki/environment/internal/AbstractEnvironment.java M xwiki-commons-core/xwiki-commons-environment/xwiki-commons-environment-servlet/src/test/java/org/xwiki/environment/internal/ServletEnvironmentTest.java M xwiki-commons-core/xwiki-commons-environment/xwiki-commons-environment-standard/src/test/java/org/xwiki/environment/internal/StandardEnvironmentTest.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/core/DefaultCoreExtensionScanner.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/installed/AbstractInstalledExtensionRepository.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/installed/DefaultInstalledExtensionRepository.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-repositories/xwiki-commons-extension-repository-maven/src/main/java/org/xwiki/extension/repository/maven/internal/MavenExtensionScanner.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-xml/src/main/java/org/xwiki/filter/xml/internal/parser/DefaultXMLParser.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/DefaultGroupedJobInitializerManager.java M xwiki-commons-core/xwiki-commons-legacy/xwiki-commons-legacy-velocity/src/main/java/org/xwiki/velocity/introspection/ChainingUberspector.java M xwiki-commons-core/xwiki-commons-legacy/xwiki-commons-legacy-velocity/src/main/java/org/xwiki/velocity/introspection/LinkingUberspector.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-local/src/main/java/org/xwiki/observation/internal/ObservationContextListener.java M xwiki-commons-core/xwiki-commons-properties/src/main/java/org/xwiki/properties/internal/DefaultBeanDescriptor.java M xwiki-commons-core/xwiki-commons-properties/src/main/java/org/xwiki/properties/internal/converter/ConverterRegistratorListener.java M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLElementSanitizer.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLElementSanitizerTest.java Log Message: ----------- [Misc] Fix log message errors and Logging Best Practices violations Audited all 395 logger calls in main sources against the Logging Best Practices of the Java Code Style guide, plus a read-through of the 304 literal log messages. Message errors: * Typos: "environmennt", "remaning", "know descriptor", "informations", "Unsuported" (x2), "Uknown", "fallbacking", "will not contains". * "Using SecureUberspect" named a class that does not exist, the class is SecureUberspector. * "backward dependency index dependency [{}]" repeated a word. Rule violations: * error() calls that dropped the caught exception entirely now pass it, so that a stack trace is logged as the rules require. * String.format() inside logger calls replaced by the SLF4J parameterized form, and e.getMessage() by ExceptionUtils.getRootCauseMessage(). * Parameters that were not surrounded by [] now are. * error() downgraded to warn() where the code recovers and no stack trace was passed, which is what warn() with getRootCauseMessage() is for. * An anomaly reported at info() downgraded to warn(), info() being reserved for messages the user must see. Collection parameters are deliberately left unbracketed since their toString() already generates brackets. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications