Branch: refs/heads/XWIKI-22931 Home: https://github.com/xwiki/xwiki-platform Commit: a4d64aef37a40b5b6ddbbad62cb97c439785fcda https://github.com/xwiki/xwiki-platform/commit/a4d64aef37a40b5b6ddbbad62cb97... Author: Simon Urli <[email protected]> Date: 2025-12-31 (Wed, 31 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Fix XWikiDocument#copyAttachment to actually perform a real clone including the copy of the content * Introduce a XWikiAttachment#cloneWithActualContent to clone and copy the content * Introduce a XWikiAttachmentContent#clone(boolean) that allows to decide to skip or not copying the content WIP: right now tests are passing but it shows a regression in logs when running PageTemplatesIT, probably due to the ownerDocument of XWikiAttachmnentContent in clone method Commit: 6bc0b2b2bd19899a32018af475054c264de6fdb9 https://github.com/xwiki/xwiki-platform/commit/6bc0b2b2bd19899a32018af475054... Author: Simon Urli <[email protected]> Date: 2025-12-31 (Wed, 31 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/test/java/org/xwiki/store/legacy/store/internal/FilesystemAttachmentVersioningStoreTest.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Get rid of ownerDocument in XWikiAttachmentContent * Properly override new clone method in extended classes * Set the attachment document in XWikiDocument#setAttachment WIP: this still shows a regression in PageTemplatesIT with a stacktrace about a missing attachment. Commit: 50b1ff1dfeddcffe21ce0b2410fc452a856f75c9 https://github.com/xwiki/xwiki-platform/commit/50b1ff1dfeddcffe21ce0b2410fc4... Author: Simon Urli <[email protected]> Date: 2025-12-31 (Wed, 31 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Small improvments but still having bad stack trace when trying to create page from template related to Solr Commit: 16908e058cb9dc334dc65c43bdc9f5113adf8eab https://github.com/xwiki/xwiki-platform/commit/16908e058cb9dc334dc65c43bdc9f... Author: Simon Urli <[email protected]> Date: 2025-12-31 (Wed, 31 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Properly load the file content before cloning it WIP: there's still a problem with the template UC Commit: f4d6863a3f0450faae0883b786b9fcccff999cf9 https://github.com/xwiki/xwiki-platform/commit/f4d6863a3f0450faae0883b786b9f... Author: Simon Urli <[email protected]> Date: 2025-12-31 (Wed, 31 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Fix override Commit: 021e2ac561bc4e484203418ce8444c3ce49d4487 https://github.com/xwiki/xwiki-platform/commit/021e2ac561bc4e484203418ce8444... Author: Simon Urli <[email protected]> Date: 2025-12-31 (Wed, 31 Dec 2025) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template * Fix since Compare: https://github.com/xwiki/xwiki-platform/compare/6dccacd6db85...021e2ac561bc To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications