On Mon, Dec 13, 2010 at 11:12, Jerome Velociter <[email protected]> wrote:
On Mon, Dec 13, 2010 at 11:04 AM, Thomas Mortagne <[email protected]
wrote:
On Mon, Dec 13, 2010 at 10:58, Thomas Mortagne <[email protected]> wrote:
On Mon, Dec 13, 2010 at 10:52, Jerome Velociter <[email protected]> wrote:
On Mon, Dec 13, 2010 at 10:42 AM, Thomas Mortagne < [email protected]
wrote:
On Sat, Dec 11, 2010 at 17:40, Jerome Velociter <[email protected]> wrote:
I've made the change locally : moving org.xwiki.observation.event.AbstractDocumentEvent from xwiki-core-observation-api to xwiki-legacy and creating a new org.xwiki.model.event.AbstractDocumentEvent in xwiki-model.
Waiting for some feedback before I commit this.
Jerome.
On Sat, Dec 11, 2010 at 5:15 PM, Jerome Velociter <[email protected]> wrote:
> Seems my last commit introduced a cyclic dependency by making the > observation API module depend on xwiki-model. > > Need to investigate how to solve that. The solution is maybe to move the > AbstractDocumentEvent (the one that needed the DocumentReference thus > xwiki-model) to xwiki-model directly.
AbstractDocumentEvent has nothing to do in observation API and should goes xwiki-legacy with other document related events.
I guess you mean xwiki-bridge ?
Yes sorry.
I've put it in xwiki-model in the end since this one has no dependency
on
either bridge nor xwiki-core. Ultimately, even new xwiki-model events could extend it, so IMO it's ok like that.
I don't agree.
Having document event now in xwiki-model when the model is not ready is a very bad idea IMO. We will need to improve it a lot more and have things like AbstractEntityEvent etc... Also the current one is very bad (based on string instead of entity references, BTW it's not following at all what i said about making document events based on references...).
The AbstractDocumentEvent in xwiki-model only has a constructor taking a DocumentReference, none taking a string/doc fullName.
new DefaultStringEntityReferenceSerializer().serialize(documentReference) is not what i call being based on reference, it's just a helper for the old String based system.
Now, I don't mind having it in the bridge as well.
I don't mind you don't refactor AbstractDocumentEvent as soon as it's not in xwiki-model ;)
Jerome.
Jerome.
> > WDYT? > > Jerome. > > On Sat, Dec 11, 2010 at 4:59 PM, Hudson <[email protected]> wrote: > >> See <http://hudson.xwiki.org/job/xwiki-platform-core/6666/changes> >> >> Changes: >> >> [Marius Dumitru Florea] XWIKI-5784: TempResource action fails in multiwiki >> mode >> Patch from Ludovic Dubost applied without changes. >> >> [Jerome Velociter] XWIKI-5786 Deprecate Document(Save|Update|Delete)Event >> and add new Document(Created|Updated|Deleted)Event in xwiki-bridge instead >> XWIKI-5787 Add new Document(Creating|Updating|Deleting)Event events being >> notified before the actual actions are performed on the document >> XWIKI-5788 New xwiki-legacy module to host backward compatibility
code
>> >> [Vincent Massol] Revert code committed by error in rev 32011 (XWIKI-5603) >> >> ------------------------------------------ >> Started by an SCM change >> Started by an SCM change >> Started by an SCM change >> Building remotely on agent-2 >> Updating http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk >> A xwiki-bridge/src/main/java/org/xwiki/bridge/event >> AU >>
xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletedEvent.java
>> AU >>
xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatedEvent.java
>> AU >>
xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatedEvent.java
>> AU >>
xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletingEvent.java
>> AU >>
xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatingEvent.java
>> AU >>
xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatingEvent.java
>> U xwiki-bridge/pom.xml >> U >>
xwiki-annotations/xwiki-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java
>> A xwiki-legacy >> A xwiki-legacy/src >> A xwiki-legacy/src/test >> A xwiki-legacy/src/test/java >> A xwiki-legacy/src/test/java/org >> A xwiki-legacy/src/test/java/org/xwiki >> A xwiki-legacy/src/test/java/org/xwiki/observation >> A >> xwiki-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java >> A xwiki-legacy/src/test/java/org/xwiki/observation/event >> AU >>
xwiki-legacy/src/test/java/org/xwiki/observation/LegacyEventDispatcherTest.java
>> A xwiki-legacy/src/main >> A xwiki-legacy/src/main/java >> A xwiki-legacy/src/main/java/org >> A xwiki-legacy/src/main/java/org/xwiki >> A xwiki-legacy/src/main/java/org/xwiki/observation >> A xwiki-legacy/src/main/java/org/xwiki/observation/event >> A >>
xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java
>> A >>
xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java
>> A >>
xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java
>> A >>
xwiki-legacy/src/main/java/org/xwiki/observation/LegacyEventDispatcher.java
>> A xwiki-legacy/src/main/resources >> A xwiki-legacy/src/main/resources/META-INF >> A xwiki-legacy/src/main/resources/META-INF/components.txt >> A xwiki-legacy/pom.xml >> U >>
xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge/src/main/java/org/xwiki/rendering/internal/macro/wikibridge/WikiMacroEventListener.java
>> U >>
xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/test/java/org/xwiki/rendering/RenderingTests.java
>> U xwiki-core/src/test/java/com/xpn/xwiki/XWikiTest.java >> U >>
xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/DefaultDocumentCacheTest.java
>> U >>
xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCacheTest.java
>> U >> xwiki-core/src/test/java/com/xpn/xwiki/internal/WikiMacrosTest.java >> U >>
xwiki-core/src/test/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverterTest.java
>> U >>
xwiki-core/src/main/java/com/xpn/xwiki/render/XWikiMacrosMappingRenderer.java
>> U >> xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiCacheStore.java >> U >>
xwiki-core/src/main/java/com/xpn/xwiki/plugin/rightsmanager/RightsManagerListener.java
>> U xwiki-core/src/main/java/com/xpn/xwiki/plugin/PatternPlugin.java >> U xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java >> U >>
xwiki-core/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverter.java
>> U >>
xwiki-core/src/main/java/com/xpn/xwiki/internal/cache/DefaultDocumentCache.java
>> U >> xwiki-core/src/main/java/com/xpn/xwiki/web/TempResourceAction.java >> U >>
xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java
>> D >>
xwiki-observation/xwiki-observation-api/src/test/java/org/xwiki/observation/DocumentEventTest.java
>> D >>
xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java
>> D >>
xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java
>> D >>
xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java
>> U >>
xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java
>> U xwiki-observation/xwiki-observation-api/pom.xml >> At revision 33351 >> Parsing POMs >> [INFO ] snapshot >> org.xwiki.platform:xwiki-core-rendering-parent:2.5-SNAPSHOT: checking for >> updates from xwiki-externals >> [INFO ] snapshot >> org.xwiki.platform:xwiki-core-rendering-parent:2.5-SNAPSHOT: checking for >> updates from xwiki-snapshots >> [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = >> '98149989ac8abf2f6e9fd52097531d2b3b1176a3'; remote = >> '438d9fb1e32bf9e8242d17a5423f2023f311738f' - RETRYING >> [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = >> '98149989ac8abf2f6e9fd52097531d2b3b1176a3'; remote = >> '438d9fb1e32bf9e8242d17a5423f2023f311738f' - IGNORING >> [INFO ] snapshot org.xwiki.platform:xwiki-core-parent:2.5-SNAPSHOT: >> checking for updates from xwiki-externals >> [INFO ] snapshot org.xwiki.platform:xwiki-core-parent:2.5-SNAPSHOT: >> checking for updates from xwiki-snapshots >> [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = >> 'a973942b53b3000c3ecad5925737e8c934defb8a'; remote = >> 'f55c89977fc9cb996640a9945debda27c54f51f2' - RETRYING >> [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = >> 'a973942b53b3000c3ecad5925737e8c934defb8a'; remote = >> 'f55c89977fc9cb996640a9945debda27c54f51f2' - IGNORING >> [INFO ] snapshot org.xwiki.platform:xwiki-core-parent:2.5-SNAPSHOT: >> checking for updates from reflections-repo >> [INFO ] snapshot org.xwiki.platform:xwiki:37-SNAPSHOT: checking for >> updates from xwiki-externals >> [INFO ] snapshot org.xwiki.platform:xwiki:37-SNAPSHOT: checking for >> updates from xwiki-snapshots >> [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = >> '63972618b17ed2541ac00bbf719b6f9affb79dca'; remote = >> '165d5e99af55d7ce9def3572216cce4c2cf3d20b' - RETRYING >> [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = >> '63972618b17ed2541ac00bbf719b6f9affb79dca'; remote = >> '165d5e99af55d7ce9def3572216cce4c2cf3d20b' - IGNORING >> [INFO ] snapshot org.xwiki.platform:xwiki:37-SNAPSHOT: checking for >> updates from reflections-repo >> [trunk] $ /home/hudsonagent/jdk1.5.0_15/bin/java -Xmx1024m -cp >>
/home/hudsonagent/hudson_root/maven-agent.jar:/home/hudsonagent/maven/boot/classworlds-1.1.jar
>> hudson.maven.agent.Main /home/hudsonagent/maven >> /home/hudsonagent/bin/slave.jar >> /home/hudsonagent/hudson_root/maven-interceptor.jar 57975 >> /home/hudsonagent/hudson_root/maven2.1-interceptor.jar >> <===[HUDSON REMOTING CAPACITY]===> channel started >> Executing Maven: -B -f < >> http://hudson.xwiki.org/job/xwiki-platform-core/ws/trunk/pom.xml> clean >> deploy -Pci -Pintegration-tests >> [INFO] Scanning for projects... >> [INFO] >>
>> [ERROR] BUILD FAILURE >> [INFO] >>
>> [INFO] The projects in the reactor contain a cyclic reference: Edge >> between 'Vertex{label='org.xwiki.platform:xwiki-core-script'}' and >> 'Vertex{label='org.xwiki.platform:xwiki-core-observation-api'}' introduces >> to cycle in the graph org.xwiki.platform:xwiki-core-observation-api --> >> org.xwiki.platform:xwiki-core-model --> org.xwiki.platform:xwiki-core-script >> --> org.xwiki.platform:xwiki-core-observation-api >> [INFO] >>
>> [INFO] For more information, run Maven with the -e switch >> [INFO] >>
>> [INFO] Total time: 5 seconds >> [INFO] Finished at: Sat Dec 11 16:59:29 GMT+01:00 2010 >> [INFO] Final Memory: 9M/55M >> [INFO] >>
>> channel stopped >> >> _______________________________________________ >> notifications mailing list >> [email protected] >> http://lists.xwiki.org/mailman/listinfo/notifications >> > > _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne