Marius Dumitru Florea wrote:
Marius Dumitru Florea wrote:
Hi devs,
Right now JavaScript extensions are included when a document is rendered in WYSIWYG edit mode. This has both advantages and disadvantages.
Pro: If the output of a macro depends on a JavaScript extension, then the result of rendering that macro will be the same in view mode and (WYSIWYG) edit mode.
Con: If the JavaScript extension is not aware of the edit mode then it can modify the DOM document outside of the read-only macro markers which leads to unwanted changes in the content of the edited document (i.e. the modifications done by the JavaScript extension are saved). Such an example is http://jira.xwiki.org/jira/browse/XWIKI-4665 .
WDYT? Should we limit the WYSIWYG in order to make the editing safer?
FYI, I get a JavaScript exception ("XWiki is not defined") if I edit Main.AllDocs when javascript.vm template is not imported in WYSIWYG editing mode. Should the live table macro check if the XWiki JavaScript object is present?
Yes It should. Thanks for catching this. Jerome.
Thanks, Marius
I'm +0.
Thanks, Marius _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs