On Fri, Jan 18, 2019 at 11:27 AM Vincent Massol <[email protected]> wrote:
Hi Adel,
On 17 Jan 2019, at 11:05, Adel Atallah <[email protected]> wrote:
Hi devs,
After discussing with Marius and Thomas, we thought it might be a good idea to do the following to have a document picker in the include and display maros: * Remove the deprecation of the document parameter (only for the include macro).
I don’t understand this part. Sounds counter-intuitive to me since we want users to use the “reference” one. Could you explain?
We currently only have a document picker that we can use for DocumentReferences. To have auto-suggestion on the "reference" parameter, we would need to make another picker for all type of references, not just document.
Thanks -Vincent
* Introduce a new annotation to macro parameters to specify / override its type (different from its actual java type).
The new annotation will mostly be useful for the WYSIWYG side. In our case we want to use the document parameter which is a String. The annotation will allow us to work with a DocumentReference instead which can be used to display the document picker when editing the macro in WYSIWYG mode.
To be clear, here is how we would use it: @PropertyType(DocumentReference.class) public void setDocument(String document)
WDYT?
Thanks, Adel