I believe I am the writer. I'll fix it on Monday. Thanks for the review. Marius
Hi,
There are some pb with PeriodFactoryTest. For example:
public void testDayPeriodStartEndCode()... 40 { 41 1 Period day = PeriodFactory.createDayPeriod(System.currentTimeMillis()); 42 1 SimpleDateFormat sdf = new SimpleDateFormat("yyyyMMdd"); 43 1 try { 44 1 long start = sdf.parse(String.valueOf(day.getStartCode())).getTime(); 45 1 long end = sdf.parse(String.valueOf(day.getEndCode())).getTime(); 46 1 assertTrue("Start code must be less than end code", start < end); 47 } catch (ParseException e) { 48 0 assertTrue(e.getMessage(), false); 49 } 50 } 51
This test isn't expecting an exception to be raised and thus it should: * throw an Exception in its signature * remove the try/catch block
The other test methods should also be fixed similarly.
Could the writer of this test please fix this?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs