Here is the history: * first version of the script service introduce a the method you used * "WTF guys specifying a version here makes it totally unusable for an extension we need a method that just take the extension id and subpath" On Fri, Aug 25, 2017 at 11:13 AM, Thomas Mortagne <[email protected]> wrote:
The issue with the one with a version is that it's very fragile, your code work only with a very specific version of the library and impossible to upgrade it without breaking everything or having several extension depending on the same webjar library.
On Fri, Aug 25, 2017 at 11:09 AM, Krzysiek Płachno <[email protected]> wrote:
Hmmm - the documentation here: http://extensions.xwiki.org/xwiki/bin/view/Extension/WebJars%20Integration allowed both methods. But ok, I use the one without specifying version.
I'll update the documentation when I combat the issue mentioned by Ecaterina.
Anyway - thanks again for feedback :)
Best, Krzysztof
2017-08-24 21:56 GMT+02:00 Thomas Mortagne <[email protected]>:
Yes you don't need to indicate the version, the example use the wrong webjar script service API. Did not noticed it (bad mentor, bad).
Le 24 août 2017 17:28, "Paul Libbrecht" <[email protected]> a écrit :
Hey Krysiek,
this looks really really really cool! And the mathjs example is cute. Do you think that there would be a way to remove the version number from the require?
thank you very much for this.
Paul
On 24 Aug 2017, at 13:18, Krzysiek Płachno <[email protected]> wrote:
Hello XWiki team!
I just write to brag a bit about *Extension Repository Connector - NPM* that I created in 3rd phase of GSoC ;) You can read about it here: http://extensions.xwiki.org/xwiki/bin/view/Extension/ Extension%20Repository%20Connector%20-%20NPM/ and test it if you wish (there's an example to follow).
As before - any feedback highly appreciated :)
Have a nice day! Best, Krzysztof
-- Thomas Mortagne
-- Thomas Mortagne