On Feb 20, 2013, at 12:35 PM, Denis Gervalle <[email protected]> wrote:
On Wed, Feb 20, 2013 at 12:23 PM, Thomas Mortagne <[email protected]
wrote:
No one against, applied on master.
I'm -0 (behaviour change) to apply it on 4.5 branch but will apply it if there is other people who agree with Denis on this part.
Does it make sense that $services.model.resolveAttachment("myfile.png") gives "[email protected]" and not "[email protected]" ? The same for resolveObject.
I agree that there may have been a tricky usage of $services.model.resolveDocument("") that currently give "currentSpace.WebHome" and will give "currentSpace.currentPage" with this change.
I am still convinced that more we wait, more we have our users confused. This is a bug, and we should fix it ASAP.
+0 to backport in 4.5 Thanks -Vincent
On Tue, Feb 19, 2013 at 2:38 PM, Thomas Mortagne <[email protected]> wrote:
Hi devs,
Right now the model script service use "currentmixed" as default resolver and it should use "current" one IMO: 1) it's behavior is not very clear for a newcomer 2) it's pretty much unusable for attachments
The difference between the two resolver is that "currentmixed" resolve document name beased on default (WebHome) instead of current document. AFAIK this resolver as been introduced for retro compatibility purpose because in some old APIs like XWikiDocument contructors the document name was resolver as WebHome and not based on the current document.
So I propose to change the default resolver to "current".
Here is my +1.
This script service is not much used yet, I doubt anybody is using it expecting to get WebHome when resolving the document name but since it's a behaviour change 5.0 is the right time for it.
-- Thomas Mortagne