On 05/22/2014 01:32 AM, Thomas Mortagne wrote:
On Wed, May 21, 2014 at 7:47 PM, Sergiu Dumitriu <[email protected]> wrote:
On 05/21/2014 01:44 PM, Thomas Mortagne wrote:
On Wed, May 21, 2014 at 7:25 PM, walid yaich <[email protected]> wrote:
As I said in the preview mail data is the XWikiContext. I'm sorry, i didn't understand exactly what you mean by "data is the XWikiContext."
You are in the following method:
void onEvent(Event event, Object source, Object data)
the second parameter is called data in your code and it's already a XWikiContext object you don't have to do a hack to get it.
Note that the xcontext is sent as the "data" parameter as a convenience, since historically there was no other way of getting hold of it. It is not guaranteed that this will continue to happen. The preferred method is still to access the execution context.
I don't agree, changing parameters coming with an event is a breakage. There will be new events with the new model and those may not pass the XWikiContext but that's all.
Agreed, as long as the event is the same, the parameters will be the same, but we will deprecate org.xwiki.bridge.event.* at some point, once the bridge is no longer relevant. So, in order to make the transition to the future events smoother, it is better to use the future-proof way of accessing the context. Actually, when the bridge won't be needed, XWikiContext will be useless as well. -- Sergiu Dumitriu http://purl.org/net/sergiu