On Thu, Jan 7, 2010 at 18:50, Jerome Velociter <[email protected]> wrote:
On Thu, Jan 7, 2010 at 17:53, Jerome Velociter <[email protected]> wrote:
Hello developers,
In the course of rewriting the import UI (XWIKI-4692), I've also integrated a modified version of Ludovic's patch for XWIKI-831 "Import wizard should conserve version history".
It's not a huge refactoring, but since I'm deprecating APIs and introducing new ones, I'd like to be sure it's ok with you before I commit. The goal was not to rewrite the whole plugin (which would be needed thought), but rather to fix major bugs and make possible the "add a version to existing document" option upon import.
As I wrote on JIRA, here's basically what the patch does:
* Â It deprecated the notions of backupPack, preserveVersion and isWithVersions in the installer (or "PackageAPI") * It introduces a notion of HistoryStrategy (an enum with 3 options: ADD, REPLACE and RESET) that replace the former preserveVersion and
What is RESET ?
It means "Import and set the imported version to be 1.1" (ignore the package's history if any, delete the existing document history if there is one)"
IMO there is two different aspects mixed in your enum: - add or replace - with or without history so it should be two different parameters IMO. I agree that ADD+HISTORY is not easy to do but you can indicate in the javadoc that right now history parameter is not taken into account with ADD.
[snip]
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne