On Mon, Dec 13, 2010 at 11:10, Vincent Massol <[email protected]> wrote:
On Dec 13, 2010, at 10:01 AM, Jerome Velociter wrote:
On Mon, Dec 13, 2010 at 9:17 AM, Vincent Massol <[email protected]> wrote:
On Dec 11, 2010, at 11:37 AM, jvelociter (SVN) wrote:
Author: jvelociter Date: 2010-12-11 11:37:21 +0100 (Sat, 11 Dec 2010) New Revision: 33349
Added: platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/
platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatedEvent.java
platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatingEvent.java
platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletedEvent.java
platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletingEvent.java
platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatedEvent.java
platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatingEvent.java
platform/core/trunk/xwiki-legacy/ platform/core/trunk/xwiki-legacy/pom.xml platform/core/trunk/xwiki-legacy/src/ platform/core/trunk/xwiki-legacy/src/main/ platform/core/trunk/xwiki-legacy/src/main/java/ platform/core/trunk/xwiki-legacy/src/main/java/org/ platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/ platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/
platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/LegacyEventDispatcher.java
platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/
platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java
platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java
platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java
platform/core/trunk/xwiki-legacy/src/main/resources/ platform/core/trunk/xwiki-legacy/src/main/resources/META-INF/
platform/core/trunk/xwiki-legacy/src/main/resources/META-INF/components.txt
platform/core/trunk/xwiki-legacy/src/test/ platform/core/trunk/xwiki-legacy/src/test/java/ platform/core/trunk/xwiki-legacy/src/test/java/org/ platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/ platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/
platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java
platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/LegacyEventDispatcherTest.java
platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/event/
Removed:
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/test/java/org/xwiki/observation/DocumentEventTest.java
Modified:
platform/core/trunk/xwiki-annotations/xwiki-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java
platform/core/trunk/xwiki-bridge/pom.xml platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/internal/cache/DefaultDocumentCache.java
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverter.java
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/PatternPlugin.java
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/rightsmanager/RightsManagerListener.java
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/XWikiMacrosMappingRenderer.java
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiCacheStore.java
platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java
platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/XWikiTest.java
platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/WikiMacrosTest.java
platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/DefaultDocumentCacheTest.java
platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCacheTest.java
platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverterTest.java
platform/core/trunk/xwiki-observation/xwiki-observation-api/pom.xml
platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java
platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge/src/main/java/org/xwiki/rendering/internal/macro/wikibridge/WikiMacroEventListener.java
Log: XWIKI-5786 Deprecate Document(Save|Update|Delete)Event and add new Document(Created|Updated|Deleted)Event in xwiki-bridge instead XWIKI-5787 Add new Document(Creating|Updating|Deleting)Event events being notified before the actual actions are performed on the document XWIKI-5788 New xwiki-legacy module to host backward compatibility code
Jerome, my bad i haven't followed the discussion too closely but could you explain why you have used the xwiki-bridge module?
The goal is to remove that module, not to add to it I think :)
I'd have put the event bridge in xwiki-legacy. Why not put it there?
Hi Vincent,
The goal is to have xwiki-legacy as backward-compatibility only. It means none of our modules should depend on it.
We've decided to put the new events in xwiki-bridge since they get XWikiDocument passed as source and XWikiContext as data. When we can have new events that do not depend on xwiki-core (at runtime that is), we will create them in xwiki-model and move the ones in bridge in xwiki-legacy.
I thought we had agree to pass References to them instead of XWiki Document?
You are mixing the event object and what you can find in source/data which are still XWikiDocument and XWikiContext.
I'm not sure what's the point of adding these new events now since they're not "final" and will have to be redone soon enough thus causing troubles for users when they'll have code based on them?
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne