On Sep 24, 2009, at 8:54 AM, Marius Dumitru Florea wrote:
Hi Vincent,
vmassol (SVN) wrote:
Author: vmassol Date: 2009-09-23 23:45:22 +0200 (Wed, 23 Sep 2009) New Revision: 23882
Modified: enterprise/branches/xwiki-enterprise-2.0/distribution-test/ wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/LinkTest.java Log: Try to fix flickering test
Modified: enterprise/branches/xwiki-enterprise-2.0/distribution- test/wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/ LinkTest.java =================================================================== --- enterprise/branches/xwiki-enterprise-2.0/distribution-test/ wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/LinkTest.java 2009-09-23 21:22:39 UTC (rev 23881) +++ enterprise/branches/xwiki-enterprise-2.0/distribution-test/ wysiwyg-tests/src/test/it/com/xpn/xwiki/it/selenium/LinkTest.java 2009-09-23 21:45:22 UTC (rev 23882) @@ -167,7 +167,7 @@ /** * Test the basic feature for adding a link to a new page in a new space. * - * @see http://jira.xwiki.org/jira/browse/XWIKI-3511 + * @see <a href="http://jira.xwiki.org/jira/browse/ XWIKI-3511">XWIKI-3511</a> */ public void testCreateLinkToNewPageInNewSpace() { @@ -931,7 +931,7 @@ /** * Test that editing a link with custom parameters set from wiki syntax preserves the parameters of the link. * - * @see http://jira.xwiki.org/jira/browse/XWIKI-3568 + * @see <a href="http://jira.xwiki.org/jira/browse/ XWIKI-3568">XWIKI-3568</a> */ public void testEditLinkPreservesCustomParameters() { @@ -988,8 +988,8 @@ /** * Test that quotes in link tooltips are correctly escaped. * - * @see http://jira.xwiki.org/jira/browse/XWIKI-3569 - * @see http://jira.xwiki.org/jira/browse/XWIKI-3575 + * @see <a href="http://jira.xwiki.org/jira/browse/ XWIKI-3569">XWIKI-3569</a> + * @see <a href="http://jira.xwiki.org/jira/browse/ XWIKI-3569">XWIKI-3575</a> */ public void testQuoteInLinkTooltip() { @@ -1267,7 +1267,7 @@ /** * Test that a relative link is correctly edited. * - * @see http://jira.xwiki.org/jira/browse/XWIKI-3676 + * @see <a href="http://jira.xwiki.org/jira/browse/ XWIKI-3676">XWIKI-3676</a> */ public void testEditRelativeLink() { @@ -1851,7 +1851,7 @@
protected void waitForStepToLoad(String name) { - waitForCondition("selenium.isElementPresent('// *[contains(@class, \"" + name + "\")]');");
+ assertAndWaitForElement("//*[contains(@class, '" + name + "')]");
I find "assertAndWait.." a bit confusing since I'm thinking that it asserts something and then waits for the element to be present. From the code it looks like the method just waits for the element to be present. Why not simply "waitForElement"?
Agreed. Thanks -Vincent