On Mon, Sep 27, 2010 at 3:04 PM, Jean-Vincent Drean <[email protected]> wrote:
On Fri, Sep 24, 2010 at 5:37 PM, Vincent Massol <[email protected]> wrote:
1) If the module is named xwiki-users then it's obvious it's about user mgmt in xwiki and not just handling a specific use case and letting other parts of xwiki handle other parts of xwiki user mgmt 2) if you expose the XWikiUsers class elsewhere then you're forbidding from introducing a different implementation and you're exposing internal details of implementation.
I'm not questioning that JV wants something for his very specific use case. This is fine. I'm questioning JV's need with the introduction of what was presented as the XWiki Users management module. If it's just some "shortcuts" as you say then stuff it in xwiki-core with the user mgmt api there.
If the xwiki users module is meant to be the XWiki Users Mgmt module then it needs more thoughts IMO. I'm again fine with a first impl like this one BUT it's definitely not good from an architecture POV and will be broken completely as soon as we start thinking globally about the architecture of such a module. If we agree with this I'm fine. Users should be warned to not use this api or risk being broken.
Last comment: I don't have the feeling this user module proposal was thought out of the box, by going back to business needs. It seems it was thought out from a very specific use case POV. Thus it won't be able to address the general needs for sure and will need to evolve a lot in the future.
The current module covers 3 needs: display users in the user directory, display users in the administration, display users in the rights UI. Those are specific use cases and I understand your concerns about the search/matching not being extensible enough, wdyt about the user criterion proposal from Thomas ?
Update: http://dev.xwiki.org/xwiki/bin/view/Design/UsersModule#HAPIproposal2
Thanks -Vincent
PS: I've not answered the other points above because I don't agree with them and I'm not sure what we are discussing here. It seems we're discussing 2 things mixed: - a temporary api just to satisfy one specific use case - a general xwiki users architecture
Thanks, Anca
errr? We're talking about APIs here.... why would I? Simply because there's a notion of local and global users so we need an api to return local users, global users, all users, etc.
There's a notion of local and global wiki pages, but should it matter for user management ?
Whenever you talk specific without being able to do something generic you can be sure your API is flawed and this is my main concern with the proposal: I see it very focused on a single need and IMO it hasn't been thought to be generic. While I'm fine with this we need to know it's going to have to be broken very soon and thus it's not really an API and should be internal instead.
I think we know enough our needs to be able to define a specific API that won't have to be broken.
Thanks, JV.
It's ok to be minimalistic but it's not ok not to prepare for all the use cases because you'll have to break the api later on.
Thanks -Vincent
> Thanks > -Vincent > > On Sep 17, 2010, at 11:39 AM, Jean-Vincent Drean wrote: > >> Up! >> >> I could commit the code I have if we agree that it is going in the >> good direction. >> I'm thinking about the component implementation proposal in particular: >> http://dev.xwiki.org/xwiki/bin/view/Design/UsersModule#HUsersComponent >> >> Thanks, >> JV. >> >> On Wed, Aug 4, 2010 at 11:30 AM, Jean-Vincent Drean >> <[email protected]> wrote: >>> Hi Devs, >>> >>> I'd like to introduce a new configuration property that would define >>> at which level users should be handled in a farm. >>> See the proposition about the new entry in xwiki.properties, it should >>> be self-explanatory: >>> >>> --------------------------------8<-------------------------------- >>> #-# [Since 2.5M1] >>> #-# Define at which level users and groups should be handled in the >>> farm. Available modes: >>> #-# >>> #-# mixed (default): >>> #-# - user registration available in the main wiki and local wikis >>> #-# - users from the current wiki and the main wiki will be displayed >>> in the rights interface and user suggests >>> #-# - user administration is present in all the wikis >>> #-# >>> #-# local: >>> #-# - user registration available in the main wiki and local wikis >>> #-# - only users from the current wiki will be displayed in the rights >>> interface and user suggests >>> #-# - user administration is present in all the wikis >>> #-# >>> #-# global: >>> #-# - user registration available in the main wiki only, the register >>> link in local wikis will point to the main wiki >>> #-# - only users from the main wiki will be displayed in the rights >>> interface and user suggests >>> #-# - user administration is present in the main wiki only >>> core.virtual.users=mixed >>> -------------------------------->8-------------------------------- >>> >>> More details are available here: >>> http://dev.xwiki.org/xwiki/bin/view/Design/UsersModule >>> >>> WDYT ? >>> >>> Thanks, >>> JV.
devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs