On Jan 5, 2009, at 4:15 PM, Jerome Velociter wrote:
+1 for the general layout.
As a side note, I'd like we consider introducing a hook for macros to provide their own insertion dialog (in place of the generic 2bis). This would allow to have restrictions on parameter combinations. (for example: user can define a value for param2 only if param1 has been set to a specific value - this is the case for the map macro : we could say width and height parameters are meaningless unless the size parameter has been set to "custom"). I suppose we could also define those rules in the rendering with new annotations and still use a generic dialog, but it would probably be overkill compared to custom dialogs provided by the macro itself.
Yes but Dialog is about UI. We cannot have UI in the macro itself. We could have separate WYSIWYG extensions but it would be done in the WYSIWYG not in the Rendering/Macro. What we can have in macros are constraints/validation information. Thanks -Vincent
Anyway, just an idea.
Jerome.
Jean-Vincent Drean wrote:
Hi,
I've made a mockup for the macro dialog in the WYSIWYG editor : http://incubator.myxwiki.org/xwiki/bin/download/Mockups/WebHome/MacroDialogs...
I've assumed that using a tree to browse macros was : - Scalable. - Consistent with link dialogs. Shout if you think about another way of displaying them.
Note that the second dialog is generated dynamically and will vary a lot according to macros needs (see 2 bis), its layout must remain as simple as possible.
Here's my +1.
JV.