Results: http://www.xwiki.org/xwiki/bin/view/Blog/Pull+Request+Day+%231 Thanks -Vincent On 6 Jun 2014 at 09:33:35, [email protected] ([email protected](mailto:[email protected])) wrote:
Hi,
I’ve started a blog post (not published at this point) to recap the work done: http://www.xwiki.org/xwiki/bin/view/Blog/Pull+Request+Day+%231
Please add what you’ve done in it so that we can publish it later today!
Thanks to everyone who participated! -Vincent
On 5 Jun 2014 at 09:43:30, Thomas Mortagne ([email protected](mailto:[email protected])) wrote:
+1
I doubt be need to record applied PRs since we can just look at closed PR I guess.
On Thu, Jun 5, 2014 at 9:06 AM, [email protected] wrote:
Hi devs,
We’re Thursday and Thursday is XWiki Day! :)
I’d like to propose that we do our first PR Review Day today. The goal is to review all the JIRA issues that have patches or PRs in them (http://jira.xwiki.org/secure/IssueNavigator.jspa?reset=true&mode=hide&jqlQue...) and:
- apply them if possible - comment on them if something is missing/not right - set the proper “Pull Request Status” field value: Awaiting Committer Feedback, Awaiting Contributor Feedback, None - ping the contributor if we’ve already asked for some info and we didn’t get it - if some PR are almost good then spend the extra time to finish them to allow applying the PR
Process: - when you start reviewing a PR please assign it to yourself to set the lock on it - when you’re done, if the issue wasn’t closed, then unassign yourself
Please record: - how many issues you’ve reviewed - how many PRs you’ve applied
WDYT?
Let’s do it! :)
Thanks -Vincent