htmlheader.vm is not really a standard place but I agree that this information is kind of provided there already which means there is a risk of having two informations not in sync. Maybe we should do what Guillaume suggest but also make what is in htmlheader.vm dynamic (i.e. generate it based on the skin property). On Mon, Jan 5, 2015 at 1:35 PM, Ecaterina Moraru (Valica) <[email protected]> wrote:
+0 if it's really needed.
From an user perspective it's a shame that we are polluting the Skin class with a setting that will be rarely used and that we cannot auto-determine the doctype from the skin's htmlheader.vm
Thanks, Caty
On Mon, Jan 5, 2015 at 2:18 PM, Guillaume "Louis-Marie" Delhumeau < [email protected]> wrote:
Hi.
Problem: in XWiki, we have currently 2 main skins, Colibri (to be deprecated) and Flamingo, that did not share the same doctype. Colibri templates are using the XHTML 1.0 syntax, meanwhile Flamingo uses the HTML 5 syntax.
Currently, we have hard-coded in a lot of places the fact that we use XHTML 1.0 syntax, but I would like to replace this by a new setting, skin-dependant, to select the rendering syntax we want. It would enable us to generate valid code (with the HTML cleaner, among other things) for each skin we support.
This setting will be located in the XWiki.XWikiSkins objects, and in the skin.properties file for file system skins. Of course we also need to add a new API to get the current rendering syntax.
The alternative is to create a global setting or constant to set the rendering syntax for the whole XWiki instance.
Some discussions about this there: http://jira.xwiki.org/browse/XWIKI-11602
Here is my +1,
Thanks, -- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne