On 2 Jun 2014 at 18:49:53, Sergiu Dumitriu ([email protected](mailto:[email protected])) wrote:
On 06/02/2014 12:46 PM, [email protected] wrote:
Note: Maybe it’s time to think about a generic mapping between naming rules from xwiki.properties and naming rules from xproperties (eg XWikiPreferences properties)...
How about this for a rule:
Stop adding properties to XWikiProperties!
Well you need to explain your thoughts more :) The goal of xwiki.properties is to: - define config values even when there’s no wiki page - define config values for all wikis Also note that we have a global Configuration system. You just ask for a property value knowing it’s name and it’ll find it for you by looking in all places. Those places are configurable (it can be in a properties file, in LDAP, in a DB, in wiki pages, etc). The issue I was raising is that we’re naming properties with “<module>.<name>[.<subname>]” in xwiki.properties while this is not a current convention in xproperties (actually we don’t have any convention ATM for xproperty naming AFAIK, sometimes it’s with “_” as in “smtp_host”, sometimes it’s in camelcase as in “displayHiddenDocuments" , sometimes with “.” as in “xwiki.preferences.redirect”). Thanks -Vincent
Sergiu Dumitriu