For the specific use case of the logo yes having it in the color theme never been a good idea IMO. But people will probably still want to customize a bit existing color themes to feet they internal colors and stuff like these. On Mon, Apr 23, 2018 at 1:48 PM, Guillaume Delhumeau <[email protected]> wrote:
2018-04-23 13:46 GMT+02:00 Ecaterina Moraru (Valica) <[email protected]>:
I don't know why I don't like this "copy" solution. Maybe because everything will feel less "wiki" like. Everything will become like a template, including color themes. Lot's of duplication instead of relying on the history.
Another solution (that applies only for the use case of Color Themes and Skins) would be to externalize the Logo property.
+10000
On Mon, Apr 23, 2018 at 2:38 PM, Thomas Mortagne < [email protected]> wrote:
Yes that's why I sent this mail.
But as I suggested there is always ways to make them not do that if we want those theme to stay standard. For example the UI could automate a bit the creation of a copy of the standard theme you want to customize (ask you the new name, etc.).
On Mon, Apr 23, 2018 at 12:47 PM, Ecaterina Moraru (Valica) <[email protected]> wrote:
The major problem is that some users reused the Color Themes as they were, but they have "customized" them by adding their own logo.
On Mon, Apr 23, 2018 at 1:29 PM, Thomas Mortagne < [email protected]> wrote:
Hi xwikiers,
Following new XAR entry type mail here is a question about color themes we provide in standard XWiki (Cerulean, Charcoal, etc.).
1) Standard stuff, if you want a custom color theme create a new one (would be nice to be able to copy a standard one and propose it when you try to edit a standard one).
2) Demo content, edit and delete it all you want and upgrade won't touch a customized theme to avoid surprises (background color changed a bit in the standard version which now collide with your logo)
3) Same as 2 but delete is bad (same as home page)
WDYT ?
I'm think I prefer 1) but I'm OK with 3) if other think it's more example than standard material. Let's say -0 for 2).
Thanks, -- Thomas Mortagne
-- Thomas Mortagne
-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne