Hi Marius, Thanks for the feedback, see below On Mon, May 7, 2012 at 10:07 AM, Marius Dumitru Florea <[email protected]> wrote:
On Sat, May 5, 2012 at 8:33 PM, Jerome Velociter <[email protected]> wrote:
Hi team,
Just to let you know I've started splitting the WYSIWYG module in order to create a standalone distribution of the editor, to make it easier to use outside XWiki.
Great!
The new structure of the module would be :
├── xwiki-platform-wysiwyg-client │ ├── xwiki-platform-wysiwyg-client-standalone │ └── xwiki-platform-wysiwyg-client-xwiki ├── xwiki-platform-wysiwyg-plugin-api ├── xwiki-platform-wysiwyg-server └── xwiki-platform-wysiwyg-war ├── xwiki-platform-wysiwyg-war-standalone └── xwiki-platform-wysiwyg-war-xwiki
+1
Note that the standalone WAR distribution would only be built when releasing, otherwise it means we almost double the overall time of the WYSIWYG build. I'm not sure we can work around that so easily due to the way GWT works ; Marius maybe you can hint me here.
You can't reuse the artefacts generated by the standalone war (the generated JavaScript) in the XWiki war build so I don't see other option to win time than building the standalone war only when releasing.
You can check out the split here : https://github.com/jvelo/xwiki-platform/compare/XWIKI-7785
I made a few comments. Looks good.
I've addressed some of them in a new commit : https://github.com/jvelo/xwiki-platform/commit/6463884b2cfb1567142f1c01a4c62... I've also moved the image plugin, the importer plugin, the "widget/wizard" code (though I plan to move back some of it : non-XWiki specific interfaces and abstract classes), the gadget-related classes. I wanted to move the macro plugin as well, but the read-only plugin depends on it right now. I think we would need to invert the way read-only compatible commands are declared: plugins should declare them, instead of listing them in the read-only plugin directly. Jerome
Thanks, Marius
Jerome _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs