If it's part of the core modules, there would be no need to declare the dependency on the extension. I am hesitating between declaring it as a core extension and splitting it in 2 modules: one for basic CRUD operations, and one for the complex ones (rename backlinks, etc...). But this second solution would need more work and may not be pertinent. Thanks, Guillaume 2015-08-31 18:26 GMT+02:00 Eduard Moraru <[email protected]>:
I`m not very familiar with the refactoring module and its contents, but it feels wrong to have extensions have to depend on it and use it in order to achieve basic model (CRUD) operations.
Thanks, Eduard
On Mon, Aug 31, 2015 at 6:54 PM, [email protected] <[email protected]> wrote:
Hi,
Right now almost all func tests fail to delete pages when they do getUtil().deletePage(…). They fail with:
Caused by: org.xwiki.component.manager.ComponentLookupException: Can't find descriptor for the component [role = [interface org.xwiki.job.Job] hint = [delete]]
The reason is that since XWIKI-12268 the Delete action cannot work if the Refactoring module isn't bundled, which makes the Refactoring module a core module. And this module is not part of the core modules ATM. I’ve added it to the PackageMojo for now but we need to decide what to do.
Personally I’ve always viewed Refactoring as optional and advanced features.
I don’t consider basic delete, basic copy and basic rename/move as refactoring options. However there are some parts of them that are refactorings. For example when Renaming, also check for wiki pages having the renamed page as parent and updating them or updating wiki links in pages.
So we need to decide if:
* We consider the Refactoring module as core. * Introduce a new module and move some of the core actions such as delete, move, etc to it and keep the refactoring module for non-core refactoring * Split the refactoring into basic refactorings and advanced ones. Have basic delete, copy, rename + advanced options for them separately * Others?
WDYT?
Still hesitating on my side.
Thanks -Vincent
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Delhumeau ([email protected]) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project