On Oct 10, 2012, at 4:39 PM, Fabio Mancinelli <[email protected]> wrote:
Hi everybody,
I will try to go forward in committing REST API improvements made by Ludovic and me.
Looking at the discussion about the pull request I opened https://github.com/xwiki/xwiki-platform/pull/68 Thomas pointed out the fact that it brings "xwiki-platform-wiki-manager-api" as a dependency in XE, and this might require a vote.
xwiki-platform-wiki-manager-api is something that was bundled only in XEM and not in XE.
I added it as a dependency because I use its code for performing wiki creation and XAR importing.
Thomas' comment is here: https://github.com/xwiki/xwiki-platform/pull/68#discussion_r1335333
So the vote is about the bundling of xwiki-platform-wiki-manager-api in XE for merging this pull request.
I am +1, of course.
-1 ATM until convinced otherwise. This would be a mess. Our goal is to do the opposite and remove dependencies not create new ones :) Each module should bring its own REST resources so the wiki creation REST resource should go in wiki-manager-api or in a new wiki-manager-rest module. Same for XAR importing. There should one XAR importing REST API that works without wiki-manager-api (just using oldcore's Packager) and possibily another one in wiki-manager-api which may extend the simpler one (or create a new one altogether) for importing in several wikis. Thanks -Vincent