Le 16 févr. 2012 18:38, "Eduard Moraru" <[email protected]> a écrit :
Hi devs,
Based on the work done by Anca and Sorin doring the XWiki 2011 Seminar Hackaton, I`ve made the following pull request [1] to integrate their work with minor changes.
A summary of the changes contained by the pull request are described in
the
jira issue [2].
The problem at the current stage, as Jerome also hinted, is that we need to do a migration script to make the existing annotations (in an upgrade scenario) use the XWikiComments class instead so that they can be picked up by commentsinline.vm. However, this might lose the possibility to provide custom annotations.
An alternative would be to make commentsinline.vm use the annotation service and handle and retrieve both Annotation and XWikiComment objects. This way, the current annotations should need no migration script since they are using a class configured in the AnnotationConfig page that the annotation service knows how to handle.
WDYT?
I'm tending to prefer a proper migration. I've played in the past with aggregation of both classes on a small "recent reviews" macro, and I recall some (non-trivial) HQL queries were a pain to write, when doable in a single query at all. I can look for specific examples if needed. I fear that if we let both classes live together, some potential future UI or service or whatever that exposes boths in a unified manner might be harder to implement. Jérôme
Thanks, Eduard
---------- [1] https://github.com/xwiki/xwiki-platform/pull/34 [2] http://jira.xwiki.org/browse/XWIKI-7540 _______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs