On Tue, Mar 20, 2012 at 11:36 PM, Sergiu Dumitriu <[email protected]> wrote:
On 03/20/2012 03:39 AM, Thomas Mortagne wrote:
Hi devs,
In HTTP specifications a redirect is always absolute URL which is probably why we use absolute URL with sendRedirect.
However sendRedirect does not produce direct HTTP response but allows relative URL and delegate to the application server the job of producing proper absolute URL.
IMO XWiki should always use relative URL everywhere it can so I propose to change our practice to use relative URL instead of absolute URL with HttpSevletResponse#sendRedirect when possible.
The only reasons I see to use external URLs are: * interwiki URL in a domain based multiwiki * html/pdf export for links pointing on not exported pages or non view actions
WDYT ?
I don't think this will actually solve the problem.
What problem ? If you are talking about http://jira.xwiki.org/browse/XWIKI-7632 it did fixed the issue in this specific use case as I said on the issue itself.
As long as XWiki doesn't know the correct URL to use, I doubt that the container will do any better. I just tested this on Apache HTTPD + mod_proxy_http going to Jetty, and it didn't solve the problem.
Probably mean you did not properly configured your reverse proxy but in my use case it was done right.
For the PDF export, all URLs must be external. A relative URL in a PDF doesn't have a base URL to work with, since the PDF is a standalone document. That's why we use a special URLFactory when exporting PDFs.
I know we are using a special URLFactory for pdf export. If a document pointing to itself or to another document exported in the same pdf is an external URL with sheme/host/port then there is something pretty wrong in the pdf export. Anyway that's not really the subject of the proposal.
Here is my +1. We very often fix bugs in the way to produce external URL and it's still not OK (see http://jira.xwiki.org/browse/XWIKI-7632) so lets reduce the scope for this need as much as possible.
-- Sergiu Dumitriu http://purl.org/net/sergiu/
_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne