On Nov 14, 2011, at 2:28 PM, Anca Luca wrote:
On 11/14/2011 01:51 PM, Vincent Massol wrote:
On Nov 14, 2011, at 1:41 PM, Eduard Moraru wrote:
+1,
Also, what about the Dashboard macro itself? Can it be moved inside something like xwiki-platform/xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro? It's a wiki macro. I wouldn't create a new app just for it. IMO it's very fine in the Dashboard app and would be overkill to create a new app just for 1 page (I also don't see what it would bring more).
?
dashboard macro is not a 'wiki macro' as in it's not in a wiki page, it's in a java module. It would make a bit sense to move it in it's own module since it's a bit of a rebel macro: it uses and depends on the platform-oldcore which is not really what rendering macros do…
My bad. I mixed it with the activity macro. Indeed it's not a wiki macro and I completely agree with Eddy's suggestion :)
Otherwise I have nothing against putting all that in a dashboard application ( 0 ), as long as it's preserving the behaviour.
Just as an experience to share: upgrading Main.WebHome is really really annoying, on multiwikis, we need to make a script or so everytime we make changes in the default main.webhome, so in this case too. I gained this experience when i changed the main.webhome in order to introduce dashboards on it, and everybody that upgraded farms complained about having to upgrade each main.webhome manually. We should avoid this.
Actually someone upgrading will see have its Main.Dashboard page present unless we removes it. So it should be fine. However I agree that it would be great to have some wiki migrators. Do you have a suggestion? Thanks -Vincent
Thanks, Anca
Thanks -Vincent
Thus, we would also have something like xwiki-platform/xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-ui for the xwiki pages. This would organize it more like a feature.
WDYT?
Thanks, Eduard
On Mon, Nov 14, 2011 at 1:18 PM, Thomas Mortagne <[email protected]>wrote:
+1
On Mon, Nov 14, 2011 at 11:23 AM, Vincent Massol<[email protected]> wrote:
Hi devs,
I'd like to introduce a Dashboard Application in a xwiki-platform/xwiki-platform-core/xwiki-platform-dashboard/ module. It would contain the following pages:
1/ Main.Dashboard.xml (currently in XE's app) 2/ The pages making up the user dashboard (XWiki.UserDashboardPreferencesClass, XWiki.XWikiUserDashboardSheet) (currently in Admin app) 3/ A new page which will have the logic to choose to display the user dashboard or the main shared dashboard (currently this code is in Main.WebHome in XE's app) Also I'd like to suggest introducing a Dashboard space and have all the above-mentioned pages in that space. Dashboard.WebHome would contain 3/.
And Main.WebHome would simply do an include of Dashboard.WebHome.
Note that this would allow the following: * Ability to cleanly document the Dashboard feature on extensions.xwiki.org and have it visible on enterprise.xwiki.org for example * It goes in the direction of splitting our XE XAR in discrete application * It groups together (functionally) a domain (dashboard) which means that if a user doesn't want the dashboard feature, we can simply not install it or remove it easily. WDYT?
Thanks -Vincent