Re: [xwiki-devs] [xwiki-notifications] r21683 - platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart

Hi,

- return new File("./chart.png");

...

+ return new File("./target/chart.png");

This is very bad. You should never hardcode maven directories location.

Shall I leave it the way it was? The problem with that was a chart image gets left behind after the tests, and since it is not inside the target/ directory it is not cleaned by maven. May be override the tearDown() method and cleanup the file? But I'm not sure if this is possible with the way rendering tests are done. Thanks. - Asiri

Thanks -Vincent

_______________________________________________ devs mailing list [email protected] http://lists.xwiki.org/mailman/listinfo/devs