On Tue, May 26, 2009 at 9:47 AM, Asiri Rathnayake < [email protected]> wrote:
Hi Guillaume,
On Mon, May 25, 2009 at 8:58 PM, Guillaume Lerouge <[email protected]>wrote:
Great. Both seem fine to me. A potential issue will arise when / if a wiki has a lot of spaces. You could maybe add a check and if the wiki has more than 50 spaces replace the select box with a text input with autosuggest, or make autosuggest the default.
I will work on this little later, first I need to fix js-disabled case :)
To implement these two features I used bit of javascript which I embedded in the XWiki.OfficeImporter page (inside <script> tags). I didn't bother using JSX because this javascript fragment is really small. Is this ok?
In the first feature, the user can select one of existing spaces. If he selects the [New Space] option, a javascript un-hides a text field into which the user can type in the new space name. Question; should I worry about browsers with javascript disabled? Any hints about how to handle such a scenario? :)
You can add a layer:
1. Default state: text input is shown, space selector is hidden 2. When loading the page, a JS command switches both inputs (text input is now hidden and space selector is shown) 3. When selecting "New space", a JS command switches the text input to show it
This way if JS is disabled only the text input is shown and if JS is available your current behavior keeps working.
Cool, will do that :)
Can you make them available on incubator.myxwiki.org for review?
http://incubator.myxwiki.org/xwiki/bin/view/XWiki/OfficeImporter
This is really out-dated and I don't think we have an active openoffice server deployed at myxwiki.org. But anyways an openoffice server is not required for officeimporter application UI demos.
U don't have admin rights for incubator.myxwiki.org, can you give me admin rights so that i can update the application? :)
Correction: "I don't have admin rights...."
Thanks.
- Asiri