On 28 Nov 2014 at 18:06:05, Eduard Moraru ([email protected](mailto:[email protected])) wrote:
Hi,
I believe there are 2 aspects here:
1) For top level projects, like XWiki Platform, Enterprise, Commons and Rendering it makes no sense for a non-committer to assign himself (or anyone else for the matter) when he has no commit access (to merge his Pull Request)
Of course it does make sense, otherwise I wouldn’t have proposed it! :) I probably should have stated it (I thought it was obvious): - The idea is to see who’s working on a given issue. That’s what the assignee field is for: it’s used to indicate that someone is “assigned” (ie. working on it) - Since we said in the thread started by Caty that we want to give attribution to the contributor using the “assignee” field when they do PR (when it’s merged), they’ll be the one “assigned” in the end on the issue, so it does make sense that they are assigned when they start to work on the issue. I see no reason why committers would be allowed to be assigned when they start working on an issue and not contributors. The only thing that doesn’t make sense (with the way we work) is for people to assign other people but in JIRA it’s not possible to separate the 2 notions as I mentioned in my first email.
and not even close issue access to mark it as done. It is the commiter's job to validte a PR, close the issue and set the assigned person for that issue.
BTW it’s pretty wrong to set the “assign” field to the contributor when all the work has already been done (that’s related the other thread started by Caty). Ideally their name should be set in a “Fixed By” field but not an “Assignee" one since assign means *before* the work is done ;) Now if they’re assigned from the beginning, suddenly it makes sense that their name is set in the “assignee” field :)
2) For contrib projects we can either use the “XWiki Open for Contrib” schema that allows anyone to do anything,
Yup and I’d like to generalize it to all projects since we also need to fix point 1.
or we can just do what we do fo github: whenever a new user joins the github contrib group (i.e. we add them to the group), we also add them to the jira group creates specially for contrib users on contrib projects, so they (and not anyone) have the proper rights to manage issues for conrib projects.
This is what I mentioned in my first email and I wouldn’t want to do that myself (I’d like to reduce overhead, not increase it). Now if you volunteer to do that all the time, I don’t have any issue. I already spend enough time creating jira projects and fixing permissions and maintenance in general.
Allowing anyone to assign issues at random is too risky IMO, in the way that we are very few people and we will tend to stay away from issues that are already "assigned" to not step on each-other's toes. If the assignment was not done in a responsible way, we will have issues.
Sure and I’ll agree if we get problems. It’s funny because you’re developing a wiki and the main concept of wiki is openness: Open everything and only close it only if it becomes a problem. What I’m proposing is exactly that: try to open it, see if there are too many problems and if so, find a less open solution. And seen the way we monitor JIRA activity I don’t feel we have any substantial risk of having people assign other people and us not realizing it. BTW I would still not recommend allowing people to assign issues in the JIRA Creation step since some people may think that they need to fill all fields… It wouldn’t be hard to try this for a few weeks and see where it goes. Thanks -Vincent
Thanks, Eduard
On Fri, Nov 28, 2014 at 3:50 PM, Thomas Mortagne wrote:
+1
On Fri, Nov 28, 2014 at 2:22 PM, [email protected] wrote:
Hi committers,
So far we’re allowing only committers (and some special contributors) the permission to assign themselves and others (there’s no permission to only allow someone to assign himself in JIRA!). We did this because we didn’t want people assigning issues to others.
However this is causing several problems:
* It would be nice that contributors working on a project in the xwiki github orgzanition be able to assign themselves to issues for which they wish to send PRs * For Contrib projects, since we allow anyone to become a committer there, it’s even more important that contrib developers be able to assign themselves to issues
We could of course do this in an ad-hoc manner and wait for people to ask a committer on IRC or on the mailing list to be given the permission. However this is painful for everyone.
Thus I propose to reopen again the “Assign issues” permission in JIRA for the “XWiki Open” permission scheme.
WDYT?
Thanks -Vincent